|
 |
9119d9 |
From c2a9261d3c438f74553062b4e5d5aa31d7ae5354 Mon Sep 17 00:00:00 2001
|
|
|
9119d9 |
Message-Id: <c2a9261d3c438f74553062b4e5d5aa31d7ae5354@dist-git>
|
|
|
9119d9 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
9119d9 |
Date: Wed, 21 Jan 2015 13:07:44 +0100
|
|
|
9119d9 |
Subject: [PATCH] CVE-2015-0236: qemu: Check ACLs when dumping security info
|
|
|
9119d9 |
from snapshots
|
|
|
9119d9 |
|
|
|
9119d9 |
The ACL check didn't check the VIR_DOMAIN_XML_SECURE flag and the
|
|
|
9119d9 |
appropriate permission for it. Found via code inspection while fixing
|
|
|
9119d9 |
permissions for save images.
|
|
|
9119d9 |
|
|
|
9119d9 |
(Upstream ID not available yet)
|
|
|
9119d9 |
|
|
|
9119d9 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
9119d9 |
---
|
|
|
9119d9 |
src/qemu/qemu_driver.c | 2 +-
|
|
|
9119d9 |
src/remote/remote_protocol.x | 1 +
|
|
|
9119d9 |
2 files changed, 2 insertions(+), 1 deletion(-)
|
|
|
9119d9 |
|
|
|
9119d9 |
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
|
|
|
9119d9 |
index 960bea6..a62e429 100644
|
|
|
9119d9 |
--- a/src/qemu/qemu_driver.c
|
|
|
9119d9 |
+++ b/src/qemu/qemu_driver.c
|
|
|
9119d9 |
@@ -14344,7 +14344,7 @@ qemuDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot,
|
|
|
9119d9 |
if (!(vm = qemuDomObjFromSnapshot(snapshot)))
|
|
|
9119d9 |
return NULL;
|
|
|
9119d9 |
|
|
|
9119d9 |
- if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def) < 0)
|
|
|
9119d9 |
+ if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def, flags) < 0)
|
|
|
9119d9 |
goto cleanup;
|
|
|
9119d9 |
|
|
|
9119d9 |
if (!(snap = qemuSnapObjFromSnapshot(vm, snapshot)))
|
|
|
9119d9 |
diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
|
|
|
9119d9 |
index 1265060..04d842e 100644
|
|
|
9119d9 |
--- a/src/remote/remote_protocol.x
|
|
|
9119d9 |
+++ b/src/remote/remote_protocol.x
|
|
|
9119d9 |
@@ -4434,6 +4434,7 @@ enum remote_procedure {
|
|
|
9119d9 |
* @generate: both
|
|
|
9119d9 |
* @priority: high
|
|
|
9119d9 |
* @acl: domain:read
|
|
|
9119d9 |
+ * @acl: domain:read_secure:VIR_DOMAIN_XML_SECURE
|
|
|
9119d9 |
*/
|
|
|
9119d9 |
REMOTE_PROC_DOMAIN_SNAPSHOT_GET_XML_DESC = 186,
|
|
|
9119d9 |
|
|
|
9119d9 |
--
|
|
|
9119d9 |
2.2.1
|
|
|
9119d9 |
|