Blame SOURCES/libtirpc-0.2.4-CVE-2017-8779.patch

42131c
diff -up libtirpc-0.2.4/src/rpcb_prot.c.orig libtirpc-0.2.4/src/rpcb_prot.c
42131c
--- libtirpc-0.2.4/src/rpcb_prot.c.orig	2013-12-09 15:59:51.000000000 -0500
42131c
+++ libtirpc-0.2.4/src/rpcb_prot.c	2017-05-17 13:05:47.562168877 -0400
42131c
@@ -41,6 +41,7 @@
42131c
 #include <rpc/types.h>
42131c
 #include <rpc/xdr.h>
42131c
 #include <rpc/rpcb_prot.h>
42131c
+#include "rpc_com.h"
42131c
 
42131c
 bool_t
42131c
 xdr_rpcb(xdrs, objp)
42131c
@@ -53,13 +54,13 @@ xdr_rpcb(xdrs, objp)
42131c
 	if (!xdr_u_int32_t(xdrs, &objp->r_vers)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->r_netid, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->r_netid, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->r_addr, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->r_addr, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->r_owner, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->r_owner, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
 	return (TRUE);
42131c
@@ -159,19 +160,19 @@ xdr_rpcb_entry(xdrs, objp)
42131c
 	XDR *xdrs;
42131c
 	rpcb_entry *objp;
42131c
 {
42131c
-	if (!xdr_string(xdrs, &objp->r_maddr, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->r_maddr, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->r_nc_netid, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->r_nc_netid, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
 	if (!xdr_u_int32_t(xdrs, &objp->r_nc_semantics)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->r_nc_protofmly, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->r_nc_protofmly, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->r_nc_proto, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->r_nc_proto, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
 	return (TRUE);
42131c
@@ -292,7 +293,7 @@ xdr_rpcb_rmtcallres(xdrs, p)
42131c
 	bool_t dummy;
42131c
 	struct r_rpcb_rmtcallres *objp = (struct r_rpcb_rmtcallres *)(void *)p;
42131c
 
42131c
-	if (!xdr_string(xdrs, &objp->addr, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->addr, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
 	if (!xdr_u_int(xdrs, &objp->results.results_len)) {
42131c
@@ -312,6 +313,11 @@ xdr_netbuf(xdrs, objp)
42131c
 	if (!xdr_u_int32_t(xdrs, (u_int32_t *) &objp->maxlen)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
+
42131c
+	if (objp->maxlen > RPC_MAXDATASIZE) {
42131c
+		return (FALSE);
42131c
+	}
42131c
+
42131c
 	dummy = xdr_bytes(xdrs, (char **)&(objp->buf),
42131c
 			(u_int *)&(objp->len), objp->maxlen);
42131c
 	return (dummy);
42131c
diff -up libtirpc-0.2.4/src/rpcb_st_xdr.c.orig libtirpc-0.2.4/src/rpcb_st_xdr.c
42131c
--- libtirpc-0.2.4/src/rpcb_st_xdr.c.orig	2013-12-09 15:59:51.000000000 -0500
42131c
+++ libtirpc-0.2.4/src/rpcb_st_xdr.c	2017-05-17 13:05:47.562168877 -0400
42131c
@@ -38,6 +38,7 @@
42131c
 #include <sys/cdefs.h>
42131c
 
42131c
 #include <rpc/rpc.h>
42131c
+#include "rpc_com.h"
42131c
 
42131c
 /* Link list of all the stats about getport and getaddr */
42131c
 
42131c
@@ -59,7 +60,7 @@ xdr_rpcbs_addrlist(xdrs, objp)
42131c
 	    if (!xdr_int(xdrs, &objp->failure)) {
42131c
 		return (FALSE);
42131c
 	    }
42131c
-	    if (!xdr_string(xdrs, &objp->netid, (u_int)~0)) {
42131c
+	    if (!xdr_string(xdrs, &objp->netid, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	    }
42131c
 
42131c
@@ -110,7 +111,7 @@ xdr_rpcbs_rmtcalllist(xdrs, objp)
42131c
 		IXDR_PUT_INT32(buf, objp->failure);
42131c
 		IXDR_PUT_INT32(buf, objp->indirect);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->netid, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->netid, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
 	if (!xdr_pointer(xdrs, (char **)&objp->next,
42131c
@@ -148,7 +149,7 @@ xdr_rpcbs_rmtcalllist(xdrs, objp)
42131c
 		objp->failure = (int)IXDR_GET_INT32(buf);
42131c
 		objp->indirect = (int)IXDR_GET_INT32(buf);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->netid, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->netid, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
 	if (!xdr_pointer(xdrs, (char **)&objp->next,
42131c
@@ -176,7 +177,7 @@ xdr_rpcbs_rmtcalllist(xdrs, objp)
42131c
 	if (!xdr_int(xdrs, &objp->indirect)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
-	if (!xdr_string(xdrs, &objp->netid, (u_int)~0)) {
42131c
+	if (!xdr_string(xdrs, &objp->netid, RPC_MAXDATASIZE)) {
42131c
 		return (FALSE);
42131c
 	}
42131c
 	if (!xdr_pointer(xdrs, (char **)&objp->next,
42131c
diff -up libtirpc-0.2.4/src/rpc_generic.c.orig libtirpc-0.2.4/src/rpc_generic.c
42131c
--- libtirpc-0.2.4/src/rpc_generic.c.orig	2013-12-09 15:59:51.000000000 -0500
42131c
+++ libtirpc-0.2.4/src/rpc_generic.c	2017-05-17 13:05:47.562168877 -0400
42131c
@@ -615,6 +615,9 @@ __rpc_taddr2uaddr_af(int af, const struc
42131c
 
42131c
 	switch (af) {
42131c
 	case AF_INET:
42131c
+		if (nbuf->len < sizeof(*sin)) {
42131c
+			return NULL;
42131c
+		}
42131c
 		sin = nbuf->buf;
42131c
 		if (inet_ntop(af, &sin->sin_addr, namebuf, sizeof namebuf)
42131c
 		    == NULL)
42131c
@@ -626,6 +629,9 @@ __rpc_taddr2uaddr_af(int af, const struc
42131c
 		break;
42131c
 #ifdef INET6
42131c
 	case AF_INET6:
42131c
+		if (nbuf->len < sizeof(*sin6)) {
42131c
+			return NULL;
42131c
+		}
42131c
 		sin6 = nbuf->buf;
42131c
 		if (inet_ntop(af, &sin6->sin6_addr, namebuf6, sizeof namebuf6)
42131c
 		    == NULL)
42131c
@@ -668,6 +674,8 @@ __rpc_uaddr2taddr_af(int af, const char
42131c
 
42131c
 	port = 0;
42131c
 	sin = NULL;
42131c
+	if (uaddr == NULL)
42131c
+		return NULL;
42131c
 	addrstr = strdup(uaddr);
42131c
 	if (addrstr == NULL)
42131c
 		return NULL;
42131c
diff -up libtirpc-0.2.4/src/xdr.c.orig libtirpc-0.2.4/src/xdr.c
42131c
--- libtirpc-0.2.4/src/xdr.c.orig	2013-12-09 15:59:51.000000000 -0500
42131c
+++ libtirpc-0.2.4/src/xdr.c	2017-05-17 13:05:47.563168892 -0400
42131c
@@ -43,8 +43,10 @@
42131c
 #include <stdlib.h>
42131c
 #include <string.h>
42131c
 
42131c
+#include <rpc/rpc.h>
42131c
 #include <rpc/types.h>
42131c
 #include <rpc/xdr.h>
42131c
+#include <rpc/rpc_com.h>
42131c
 
42131c
 typedef quad_t          longlong_t;     /* ANSI long long type */
42131c
 typedef u_quad_t        u_longlong_t;   /* ANSI unsigned long long type */
42131c
@@ -54,7 +56,6 @@ typedef u_quad_t        u_longlong_t;
42131c
  */
42131c
 #define XDR_FALSE	((long) 0)
42131c
 #define XDR_TRUE	((long) 1)
42131c
-#define LASTUNSIGNED	((u_int) 0-1)
42131c
 
42131c
 /*
42131c
  * for unit alignment
42131c
@@ -630,6 +631,7 @@ xdr_bytes(xdrs, cpp, sizep, maxsize)
42131c
 {
42131c
 	char *sp = *cpp;  /* sp is the actual string pointer */
42131c
 	u_int nodesize;
42131c
+	bool_t ret, allocated = FALSE;
42131c
 
42131c
 	/*
42131c
 	 * first deal with the length since xdr bytes are counted
42131c
@@ -653,6 +655,7 @@ xdr_bytes(xdrs, cpp, sizep, maxsize)
42131c
 		}
42131c
 		if (sp == NULL) {
42131c
 			*cpp = sp = mem_alloc(nodesize);
42131c
+			allocated = TRUE;
42131c
 		}
42131c
 		if (sp == NULL) {
42131c
 			warnx("xdr_bytes: out of memory");
42131c
@@ -661,7 +664,14 @@ xdr_bytes(xdrs, cpp, sizep, maxsize)
42131c
 		/* FALLTHROUGH */
42131c
 
42131c
 	case XDR_ENCODE:
42131c
-		return (xdr_opaque(xdrs, sp, nodesize));
42131c
+		ret = xdr_opaque(xdrs, sp, nodesize);
42131c
+		if ((xdrs->x_op == XDR_DECODE) && (ret == FALSE)) {
42131c
+			if (allocated == TRUE) {
42131c
+				free(sp);
42131c
+				*cpp = NULL;
42131c
+			}
42131c
+		}
42131c
+		return (ret);
42131c
 
42131c
 	case XDR_FREE:
42131c
 		if (sp != NULL) {
42131c
@@ -755,6 +765,7 @@ xdr_string(xdrs, cpp, maxsize)
42131c
 	char *sp = *cpp;  /* sp is the actual string pointer */
42131c
 	u_int size;
42131c
 	u_int nodesize;
42131c
+	bool_t ret, allocated = FALSE;
42131c
 
42131c
 	/*
42131c
 	 * first deal with the length since xdr strings are counted-strings
42131c
@@ -794,8 +805,10 @@ xdr_string(xdrs, cpp, maxsize)
42131c
 	switch (xdrs->x_op) {
42131c
 
42131c
 	case XDR_DECODE:
42131c
-		if (sp == NULL)
42131c
+		if (sp == NULL) {
42131c
 			*cpp = sp = mem_alloc(nodesize);
42131c
+			allocated = TRUE;
42131c
+		}
42131c
 		if (sp == NULL) {
42131c
 			warnx("xdr_string: out of memory");
42131c
 			return (FALSE);
42131c
@@ -804,7 +817,14 @@ xdr_string(xdrs, cpp, maxsize)
42131c
 		/* FALLTHROUGH */
42131c
 
42131c
 	case XDR_ENCODE:
42131c
-		return (xdr_opaque(xdrs, sp, size));
42131c
+		ret = xdr_opaque(xdrs, sp, size);
42131c
+		if ((xdrs->x_op == XDR_DECODE) && (ret == FALSE)) {
42131c
+			if (allocated == TRUE) {
42131c
+				free(sp);
42131c
+				*cpp = NULL;
42131c
+			}
42131c
+		}
42131c
+		return (ret);
42131c
 
42131c
 	case XDR_FREE:
42131c
 		mem_free(sp, nodesize);
42131c
@@ -824,7 +844,7 @@ xdr_wrapstring(xdrs, cpp)
42131c
 	XDR *xdrs;
42131c
 	char **cpp;
42131c
 {
42131c
-	return xdr_string(xdrs, cpp, LASTUNSIGNED);
42131c
+	return xdr_string(xdrs, cpp, RPC_MAXDATASIZE);
42131c
 }
42131c
 
42131c
 /*