|
 |
8d8ca0 |
From 585cc28a93be27d6938f276af0011401b9f7c0ca Mon Sep 17 00:00:00 2001
|
|
|
8d8ca0 |
From: Hugo Lefeuvre <hle@owl.eu.com>
|
|
|
8d8ca0 |
Date: Mon, 24 Dec 2018 06:43:48 +0100
|
|
|
8d8ca0 |
Subject: [PATCH] a/ulaw: fix multiple buffer overflows (#432)
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
i2ulaw_array() and i2alaw_array() fail to handle ptr [count] = INT_MIN
|
|
|
8d8ca0 |
properly, leading to buffer underflow. INT_MIN is a special value
|
|
|
8d8ca0 |
since - INT_MIN cannot be represented as int.
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
In this case round - INT_MIN to INT_MAX and proceed as usual.
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
f2ulaw_array() and f2alaw_array() fail to handle ptr [count] = NaN
|
|
|
8d8ca0 |
properly, leading to null pointer dereference.
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
In this case, arbitrarily set the buffer value to 0.
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
This commit fixes #429 (CVE-2018-19661 and CVE-2018-19662) and
|
|
|
8d8ca0 |
fixes #344 (CVE-2017-17456 and CVE-2017-17457).
|
|
|
8d8ca0 |
---
|
|
|
8d8ca0 |
src/alaw.c | 9 +++++++--
|
|
|
8d8ca0 |
src/ulaw.c | 9 +++++++--
|
|
|
8d8ca0 |
2 files changed, 14 insertions(+), 4 deletions(-)
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
diff --git a/src/alaw.c b/src/alaw.c
|
|
|
8d8ca0 |
index 063fd1a2..4220224c 100644
|
|
|
8d8ca0 |
--- a/src/alaw.c
|
|
|
8d8ca0 |
+++ b/src/alaw.c
|
|
|
8d8ca0 |
@@ -19,6 +19,7 @@
|
|
|
8d8ca0 |
#include "sfconfig.h"
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
#include <math.h>
|
|
|
8d8ca0 |
+#include <limits.h>
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
#include "sndfile.h"
|
|
|
8d8ca0 |
#include "common.h"
|
|
|
8d8ca0 |
@@ -326,7 +327,9 @@ s2alaw_array (const short *ptr, int count, unsigned char *buffer)
|
|
|
8d8ca0 |
static inline void
|
|
|
8d8ca0 |
i2alaw_array (const int *ptr, int count, unsigned char *buffer)
|
|
|
8d8ca0 |
{ while (--count >= 0)
|
|
|
8d8ca0 |
- { if (ptr [count] >= 0)
|
|
|
8d8ca0 |
+ { if (ptr [count] == INT_MIN)
|
|
|
8d8ca0 |
+ buffer [count] = alaw_encode [INT_MAX >> (16 + 4)] ;
|
|
|
8d8ca0 |
+ else if (ptr [count] >= 0)
|
|
|
8d8ca0 |
buffer [count] = alaw_encode [ptr [count] >> (16 + 4)] ;
|
|
|
8d8ca0 |
else
|
|
|
8d8ca0 |
buffer [count] = 0x7F & alaw_encode [- ptr [count] >> (16 + 4)] ;
|
|
|
8d8ca0 |
@@ -346,7 +349,9 @@ f2alaw_array (const float *ptr, int count, unsigned char *buffer, float normfact
|
|
|
8d8ca0 |
static inline void
|
|
|
8d8ca0 |
d2alaw_array (const double *ptr, int count, unsigned char *buffer, double normfact)
|
|
|
8d8ca0 |
{ while (--count >= 0)
|
|
|
8d8ca0 |
- { if (ptr [count] >= 0)
|
|
|
8d8ca0 |
+ { if (!isfinite (ptr [count]))
|
|
|
8d8ca0 |
+ buffer [count] = 0 ;
|
|
|
8d8ca0 |
+ else if (ptr [count] >= 0)
|
|
|
8d8ca0 |
buffer [count] = alaw_encode [lrint (normfact * ptr [count])] ;
|
|
|
8d8ca0 |
else
|
|
|
8d8ca0 |
buffer [count] = 0x7F & alaw_encode [- lrint (normfact * ptr [count])] ;
|
|
|
8d8ca0 |
diff --git a/src/ulaw.c b/src/ulaw.c
|
|
|
8d8ca0 |
index e50b4cb5..b6070ade 100644
|
|
|
8d8ca0 |
--- a/src/ulaw.c
|
|
|
8d8ca0 |
+++ b/src/ulaw.c
|
|
|
8d8ca0 |
@@ -19,6 +19,7 @@
|
|
|
8d8ca0 |
#include "sfconfig.h"
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
#include <math.h>
|
|
|
8d8ca0 |
+#include <limits.h>
|
|
|
8d8ca0 |
|
|
|
8d8ca0 |
#include "sndfile.h"
|
|
|
8d8ca0 |
#include "common.h"
|
|
|
8d8ca0 |
@@ -827,7 +828,9 @@ s2ulaw_array (const short *ptr, int count, unsigned char *buffer)
|
|
|
8d8ca0 |
static inline void
|
|
|
8d8ca0 |
i2ulaw_array (const int *ptr, int count, unsigned char *buffer)
|
|
|
8d8ca0 |
{ while (--count >= 0)
|
|
|
8d8ca0 |
- { if (ptr [count] >= 0)
|
|
|
8d8ca0 |
+ { if (ptr [count] == INT_MIN)
|
|
|
8d8ca0 |
+ buffer [count] = ulaw_encode [INT_MAX >> (16 + 2)] ;
|
|
|
8d8ca0 |
+ else if (ptr [count] >= 0)
|
|
|
8d8ca0 |
buffer [count] = ulaw_encode [ptr [count] >> (16 + 2)] ;
|
|
|
8d8ca0 |
else
|
|
|
8d8ca0 |
buffer [count] = 0x7F & ulaw_encode [-ptr [count] >> (16 + 2)] ;
|
|
|
8d8ca0 |
@@ -847,7 +850,9 @@ f2ulaw_array (const float *ptr, int count, unsigned char *buffer, float normfact
|
|
|
8d8ca0 |
static inline void
|
|
|
8d8ca0 |
d2ulaw_array (const double *ptr, int count, unsigned char *buffer, double normfact)
|
|
|
8d8ca0 |
{ while (--count >= 0)
|
|
|
8d8ca0 |
- { if (ptr [count] >= 0)
|
|
|
8d8ca0 |
+ { if (!isfinite (ptr [count]))
|
|
|
8d8ca0 |
+ buffer [count] = 0 ;
|
|
|
8d8ca0 |
+ else if (ptr [count] >= 0)
|
|
|
8d8ca0 |
buffer [count] = ulaw_encode [lrint (normfact * ptr [count])] ;
|
|
|
8d8ca0 |
else
|
|
|
8d8ca0 |
buffer [count] = 0x7F & ulaw_encode [- lrint (normfact * ptr [count])] ;
|