|
 |
28bab8 |
From 2886582f6e48258d7b8c941725a4456ed62578e9 Mon Sep 17 00:00:00 2001
|
|
|
28bab8 |
From: Jakub Filak <jfilak@redhat.com>
|
|
|
28bab8 |
Date: Tue, 28 Jan 2014 16:58:04 +0100
|
|
|
28bab8 |
Subject: [LIBREPORT PATCH 16/17] report-cli: use the Client API for
|
|
|
28bab8 |
communication to user
|
|
|
28bab8 |
|
|
|
28bab8 |
Closes rhbz#1058845
|
|
|
28bab8 |
|
|
|
28bab8 |
Signed-off-by: Jakub Filak <jfilak@redhat.com>
|
|
|
28bab8 |
---
|
|
|
28bab8 |
src/cli/cli-report.c | 30 ++++--------------------------
|
|
|
28bab8 |
1 file changed, 4 insertions(+), 26 deletions(-)
|
|
|
28bab8 |
|
|
|
28bab8 |
diff --git a/src/cli/cli-report.c b/src/cli/cli-report.c
|
|
|
28bab8 |
index 5b32fbc..68baa8b 100644
|
|
|
28bab8 |
--- a/src/cli/cli-report.c
|
|
|
28bab8 |
+++ b/src/cli/cli-report.c
|
|
|
28bab8 |
@@ -408,26 +408,6 @@ static int run_report_editor(problem_data_t *problem_data)
|
|
|
28bab8 |
}
|
|
|
28bab8 |
|
|
|
28bab8 |
/**
|
|
|
28bab8 |
- * Asks user for a text response.
|
|
|
28bab8 |
- * @param question
|
|
|
28bab8 |
- * Question displayed to user.
|
|
|
28bab8 |
- * @param result
|
|
|
28bab8 |
- * Output array.
|
|
|
28bab8 |
- * @param result_size
|
|
|
28bab8 |
- * Maximum byte count to be written.
|
|
|
28bab8 |
- */
|
|
|
28bab8 |
-static void read_from_stdin(const char *question, char *result, int result_size)
|
|
|
28bab8 |
-{
|
|
|
28bab8 |
- assert(result_size > 1);
|
|
|
28bab8 |
- printf("%s", question);
|
|
|
28bab8 |
- fflush(NULL);
|
|
|
28bab8 |
- if (NULL == fgets(result, result_size, stdin))
|
|
|
28bab8 |
- result[0] = '\0';
|
|
|
28bab8 |
- // Remove the trailing newline
|
|
|
28bab8 |
- strchrnul(result, '\n')[0] = '\0';
|
|
|
28bab8 |
-}
|
|
|
28bab8 |
-
|
|
|
28bab8 |
-/**
|
|
|
28bab8 |
* Asks user for missing information
|
|
|
28bab8 |
*/
|
|
|
28bab8 |
static void ask_for_missing_settings(const char *event_name)
|
|
|
28bab8 |
@@ -731,17 +711,15 @@ static int choose_number_from_range(unsigned min, unsigned max, const char *mess
|
|
|
28bab8 |
unsigned ii;
|
|
|
28bab8 |
for (ii = 0; ii < 3; ++ii)
|
|
|
28bab8 |
{
|
|
|
28bab8 |
- char answer[16];
|
|
|
28bab8 |
-
|
|
|
28bab8 |
- read_from_stdin(message, answer, sizeof(answer));
|
|
|
28bab8 |
- if (!*answer)
|
|
|
28bab8 |
- continue;
|
|
|
28bab8 |
+ char *answer = ask(message);
|
|
|
28bab8 |
|
|
|
28bab8 |
picked = xatou(answer);
|
|
|
28bab8 |
if (min <= picked && picked <= max)
|
|
|
28bab8 |
return picked;
|
|
|
28bab8 |
|
|
|
28bab8 |
- printf("%s (%u - %u)\n", _("You have chosen number out of range"), min, max);
|
|
|
28bab8 |
+ char *msg = xasprintf("%s (%u - %u)\n", _("You have chosen number out of range"), min, max);
|
|
|
28bab8 |
+ alert(msg);
|
|
|
28bab8 |
+ free(msg);
|
|
|
28bab8 |
}
|
|
|
28bab8 |
|
|
|
28bab8 |
error_msg_and_die(_("Invalid input, exiting."));
|
|
|
28bab8 |
--
|
|
|
28bab8 |
1.8.3.1
|
|
|
28bab8 |
|