|
 |
135360 |
From 480d4e70b53487da92a4add51395b4068f2e73c0 Mon Sep 17 00:00:00 2001
|
|
|
135360 |
From: Pranav Kant <pranavk@libreoffice.org>
|
|
|
135360 |
Date: Sun, 10 Jan 2016 22:50:46 +0530
|
|
|
135360 |
Subject: [PATCH 384/398] lokdocview: Use shared_ptr to fix a possible memory
|
|
|
135360 |
leak
|
|
|
135360 |
|
|
|
135360 |
Possible because boost::property_tree can throw an exception.
|
|
|
135360 |
|
|
|
135360 |
Change-Id: I68394ce3b30d448d40d8e22555bafdff1ffa6092
|
|
|
135360 |
Reviewed-on: https://gerrit.libreoffice.org/21309
|
|
|
135360 |
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
|
135360 |
Tested-by: David Tardon <dtardon@redhat.com>
|
|
|
135360 |
(cherry picked from commit 02b49890d51ec463d32846f1108344159664a9eb)
|
|
|
135360 |
Reviewed-on: https://gerrit.libreoffice.org/21345
|
|
|
135360 |
Tested-by: Jenkins <ci@libreoffice.org>
|
|
|
135360 |
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
|
135360 |
(cherry picked from commit 1673606de9a520e615e1a32da94f28d55ebaea20)
|
|
|
135360 |
---
|
|
|
135360 |
libreofficekit/source/gtk/lokdocview.cxx | 12 ++++++------
|
|
|
135360 |
1 file changed, 6 insertions(+), 6 deletions(-)
|
|
|
135360 |
|
|
|
135360 |
diff --git a/libreofficekit/source/gtk/lokdocview.cxx b/libreofficekit/source/gtk/lokdocview.cxx
|
|
|
135360 |
index 5cf44e98c796..b6febbd9fe66 100644
|
|
|
135360 |
--- a/libreofficekit/source/gtk/lokdocview.cxx
|
|
|
135360 |
+++ b/libreofficekit/source/gtk/lokdocview.cxx
|
|
|
135360 |
@@ -10,6 +10,7 @@
|
|
|
135360 |
#include <sal/types.h>
|
|
|
135360 |
#include <math.h>
|
|
|
135360 |
#include <string.h>
|
|
|
135360 |
+#include <memory>
|
|
|
135360 |
#include <vector>
|
|
|
135360 |
#include <string>
|
|
|
135360 |
#include <iostream>
|
|
|
135360 |
@@ -344,13 +345,12 @@ doSearch(LOKDocView* pDocView, const char* pText, bool bBackwards, bool highligh
|
|
|
135360 |
boost::property_tree::ptree aTree;
|
|
|
135360 |
GtkWidget* drawingWidget = GTK_WIDGET(pDocView);
|
|
|
135360 |
GdkWindow* drawingWindow = gtk_widget_get_window(drawingWidget);
|
|
|
135360 |
- cairo_region_t* cairoVisRegion = gdk_window_get_visible_region(drawingWindow);
|
|
|
135360 |
+ std::shared_ptr<cairo_region_t> cairoVisRegion( gdk_window_get_visible_region(drawingWindow),
|
|
|
135360 |
+ cairo_region_destroy);
|
|
|
135360 |
cairo_rectangle_int_t cairoVisRect;
|
|
|
135360 |
- int x, y;
|
|
|
135360 |
-
|
|
|
135360 |
- cairo_region_get_rectangle(cairoVisRegion, 0, &cairoVisRect);
|
|
|
135360 |
- x = pixelToTwip (cairoVisRect.x, priv->m_fZoom);
|
|
|
135360 |
- y = pixelToTwip (cairoVisRect.y, priv->m_fZoom);
|
|
|
135360 |
+ cairo_region_get_rectangle(cairoVisRegion.get(), 0, &cairoVisRect);
|
|
|
135360 |
+ int x = pixelToTwip (cairoVisRect.x, priv->m_fZoom);
|
|
|
135360 |
+ int y = pixelToTwip (cairoVisRect.y, priv->m_fZoom);
|
|
|
135360 |
|
|
|
135360 |
aTree.put(boost::property_tree::ptree::path_type("SearchItem.SearchString/type", '/'), "string");
|
|
|
135360 |
aTree.put(boost::property_tree::ptree::path_type("SearchItem.SearchString/value", '/'), pText);
|
|
|
135360 |
--
|
|
|
135360 |
2.12.0
|
|
|
135360 |
|