Blame SOURCES/0246-gtktiledviewer-initial-column-headers-for-spreadshee.patch

f325b2
From 7d7a5c94be66cbe7dc571a8bfb56f6e30b869303 Mon Sep 17 00:00:00 2001
f325b2
From: Miklos Vajna <vmiklos@collabora.co.uk>
f325b2
Date: Fri, 30 Oct 2015 14:57:16 +0100
f325b2
Subject: [PATCH 246/398] gtktiledviewer: initial column headers for
f325b2
 spreadsheet documents
f325b2
f325b2
Change-Id: I10e88b4ff4ab0cfb29e97fa608d8acd69ce0f062
f325b2
(cherry picked from commit 18bf71a2002b979dbf80d85c8863af39783bf87d)
f325b2
---
f325b2
 .../qa/gtktiledviewer/gtktiledviewer.cxx           | 131 +++++++++++++--------
f325b2
 1 file changed, 83 insertions(+), 48 deletions(-)
f325b2
f325b2
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
f325b2
index 9ee6ce8a39fb..08058e8699c9 100644
f325b2
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
f325b2
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
f325b2
@@ -32,8 +32,8 @@ static int help()
f325b2
     return 1;
f325b2
 }
f325b2
 
f325b2
-/// Represents the row header widget for spreadsheets.
f325b2
-class TiledRowBar
f325b2
+/// Represents the row or column header widget for spreadsheets.
f325b2
+class TiledRowColumnBar
f325b2
 {
f325b2
 public:
f325b2
     /// Stores size and content of a single row header.
f325b2
@@ -48,17 +48,21 @@ public:
f325b2
         }
f325b2
     };
f325b2
 
f325b2
-    static const int HEADER_WIDTH = 50;
f325b2
+    enum TiledBarType { ROW, COLUMN };
f325b2
+
f325b2
+    static const int ROW_HEADER_WIDTH = 50;
f325b2
+    static const int COLUMN_HEADER_HEIGHT = 20;
f325b2
 
f325b2
     GtkWidget* m_pDrawingArea;
f325b2
     std::vector<Header> m_aHeaders;
f325b2
-    int m_nHeightPixel = 0;
f325b2
+    /// Height for row bar, width for column bar.
f325b2
+    int m_nSizePixel;
f325b2
+    TiledBarType m_eType;
f325b2
 
f325b2
-    TiledRowBar(GtkWidget* pDocView);
f325b2
+    TiledRowColumnBar(TiledBarType eType);
f325b2
     static gboolean draw(GtkWidget* pWidget, cairo_t* pCairo, gpointer pData);
f325b2
     gboolean drawImpl(GtkWidget* pWidget, cairo_t* pCairo);
f325b2
     static gboolean docConfigureEvent(GtkWidget* pWidget, GdkEventConfigure* pEvent, gpointer pData);
f325b2
-    gboolean docConfigureEventImpl(GtkWidget* pWidget, GdkEventConfigure* pEvent);
f325b2
     /// Draws rText at the center of rRectangle on pCairo.
f325b2
     static void drawText(cairo_t* pCairo, const GdkRectangle& rRectangle, const std::string& rText);
f325b2
 };
f325b2
@@ -87,7 +91,8 @@ public:
f325b2
     GtkWidget* m_pFindbarEntry;
f325b2
     GtkWidget* m_pFindbarLabel;
f325b2
     bool m_bFindAll;
f325b2
-    std::shared_ptr<TiledRowBar> m_pRowBar;
f325b2
+    std::shared_ptr<TiledRowColumnBar> m_pRowBar;
f325b2
+    std::shared_ptr<TiledRowColumnBar> m_pColumnBar;
f325b2
 
f325b2
     TiledWindow()
f325b2
         : m_pDocView(0),
f325b2
@@ -124,21 +129,24 @@ static TiledWindow& lcl_getTiledWindow(GtkWidget* pWidget)
f325b2
     return g_aWindows[pToplevel];
f325b2
 }
f325b2
 
f325b2
-TiledRowBar::TiledRowBar(GtkWidget* pDocView)
f325b2
+TiledRowColumnBar::TiledRowColumnBar(TiledBarType eType)
f325b2
     : m_pDrawingArea(gtk_drawing_area_new()),
f325b2
-    m_nHeightPixel(0)
f325b2
+    m_nSizePixel(0),
f325b2
+    m_eType(eType)
f325b2
 {
f325b2
-    gtk_widget_set_size_request(m_pDrawingArea, HEADER_WIDTH, -1);
f325b2
-    g_signal_connect(m_pDrawingArea, "draw", G_CALLBACK(TiledRowBar::draw), this);
f325b2
-    g_signal_connect(pDocView, "configure-event", G_CALLBACK(TiledRowBar::docConfigureEvent), this);
f325b2
+    if (m_eType == ROW)
f325b2
+        gtk_widget_set_size_request(m_pDrawingArea, ROW_HEADER_WIDTH, -1);
f325b2
+    else
f325b2
+        gtk_widget_set_size_request(m_pDrawingArea, -1, COLUMN_HEADER_HEIGHT);
f325b2
+    g_signal_connect(m_pDrawingArea, "draw", G_CALLBACK(TiledRowColumnBar::draw), this);
f325b2
 }
f325b2
 
f325b2
-gboolean TiledRowBar::draw(GtkWidget* pWidget, cairo_t* pCairo, gpointer pData)
f325b2
+gboolean TiledRowColumnBar::draw(GtkWidget* pWidget, cairo_t* pCairo, gpointer pData)
f325b2
 {
f325b2
-    return static_cast<TiledRowBar*>(pData)->drawImpl(pWidget, pCairo);
f325b2
+    return static_cast<TiledRowColumnBar*>(pData)->drawImpl(pWidget, pCairo);
f325b2
 }
f325b2
 
f325b2
-void TiledRowBar::drawText(cairo_t* pCairo, const GdkRectangle& rRectangle, const std::string& rText)
f325b2
+void TiledRowColumnBar::drawText(cairo_t* pCairo, const GdkRectangle& rRectangle, const std::string& rText)
f325b2
 {
f325b2
     cairo_text_extents_t extents;
f325b2
     cairo_text_extents(pCairo, rText.c_str(), &extents);
f325b2
@@ -147,7 +155,7 @@ void TiledRowBar::drawText(cairo_t* pCairo, const GdkRectangle& rRectangle, cons
f325b2
     cairo_show_text(pCairo, rText.c_str());
f325b2
 }
f325b2
 
f325b2
-gboolean TiledRowBar::drawImpl(GtkWidget* /*pWidget*/, cairo_t* pCairo)
f325b2
+gboolean TiledRowColumnBar::drawImpl(GtkWidget* /*pWidget*/, cairo_t* pCairo)
f325b2
 {
f325b2
     cairo_set_source_rgb(pCairo, 0, 0, 0);
f325b2
 
f325b2
@@ -155,56 +163,76 @@ gboolean TiledRowBar::drawImpl(GtkWidget* /*pWidget*/, cairo_t* pCairo)
f325b2
     for (const Header& rHeader : m_aHeaders)
f325b2
     {
f325b2
         GdkRectangle aRectangle;
f325b2
-        aRectangle.x = 0;
f325b2
-        aRectangle.y = nTotal - 1;
f325b2
-        aRectangle.width = HEADER_WIDTH - 1;
f325b2
-        aRectangle.height = rHeader.m_nSize;
f325b2
-        // Bottom line.
f325b2
-        cairo_rectangle(pCairo, aRectangle.x, aRectangle.y + aRectangle.height, aRectangle.width, 1);
f325b2
-        cairo_fill(pCairo);
f325b2
-        // Left line.
f325b2
-        cairo_rectangle(pCairo, aRectangle.width, aRectangle.y, 1, aRectangle.height);
f325b2
-        cairo_fill(pCairo);
f325b2
+        if (m_eType == ROW)
f325b2
+        {
f325b2
+            aRectangle.x = 0;
f325b2
+            aRectangle.y = nTotal - 1;
f325b2
+            aRectangle.width = ROW_HEADER_WIDTH - 1;
f325b2
+            aRectangle.height = rHeader.m_nSize;
f325b2
+            // Bottom line.
f325b2
+            cairo_rectangle(pCairo, aRectangle.x, aRectangle.y + aRectangle.height, aRectangle.width, 1);
f325b2
+            cairo_fill(pCairo);
f325b2
+            // Right line.
f325b2
+            cairo_rectangle(pCairo, aRectangle.width, aRectangle.y, 1, aRectangle.height);
f325b2
+            cairo_fill(pCairo);
f325b2
+        }
f325b2
+        else
f325b2
+        {
f325b2
+            aRectangle.x = nTotal -1;
f325b2
+            aRectangle.y = 0;
f325b2
+            aRectangle.width = rHeader.m_nSize;
f325b2
+            aRectangle.height = COLUMN_HEADER_HEIGHT - 1;
f325b2
+            // Right line.
f325b2
+            cairo_rectangle(pCairo, aRectangle.x + aRectangle.width , aRectangle.y, 1, aRectangle.height);
f325b2
+            cairo_fill(pCairo);
f325b2
+            // Bottom line.
f325b2
+            cairo_rectangle(pCairo, aRectangle.x, aRectangle.height, aRectangle.width, 1);
f325b2
+            cairo_fill(pCairo);
f325b2
+        }
f325b2
         drawText(pCairo, aRectangle, rHeader.m_aText);
f325b2
         nTotal += rHeader.m_nSize;
f325b2
-        if (nTotal > m_nHeightPixel)
f325b2
+        if (nTotal > m_nSizePixel)
f325b2
             break;
f325b2
     }
f325b2
 
f325b2
     return FALSE;
f325b2
 }
f325b2
 
f325b2
-gboolean TiledRowBar::docConfigureEvent(GtkWidget* pWidget, GdkEventConfigure* pEvent, gpointer pData)
f325b2
-{
f325b2
-    return static_cast<TiledRowBar*>(pData)->docConfigureEventImpl(pWidget, pEvent);
f325b2
-}
f325b2
-
f325b2
-gboolean TiledRowBar::docConfigureEventImpl(GtkWidget* pDocView, GdkEventConfigure* /*pEvent*/)
f325b2
+gboolean TiledRowColumnBar::docConfigureEvent(GtkWidget* pDocView, GdkEventConfigure* /*pEvent*/, gpointer /*pData*/)
f325b2
 {
f325b2
-    if (g_aWindows.find(gtk_widget_get_toplevel(pDocView)) == g_aWindows.end())
f325b2
-        return TRUE;
f325b2
-
f325b2
     TiledWindow& rWindow = lcl_getTiledWindow(pDocView);
f325b2
     GtkAdjustment* pVAdjustment = gtk_scrolled_window_get_vadjustment(GTK_SCROLLED_WINDOW(rWindow.m_pScrolledWindow));
f325b2
-    m_nHeightPixel = gtk_adjustment_get_page_size(pVAdjustment);
f325b2
+    rWindow.m_pRowBar->m_nSizePixel = gtk_adjustment_get_page_size(pVAdjustment);
f325b2
+    GtkAdjustment* pHAdjustment = gtk_scrolled_window_get_hadjustment(GTK_SCROLLED_WINDOW(rWindow.m_pScrolledWindow));
f325b2
+    rWindow.m_pColumnBar->m_nSizePixel = gtk_adjustment_get_page_size(pHAdjustment);
f325b2
 
f325b2
     LibreOfficeKitDocument* pDocument = lok_doc_view_get_document(LOK_DOC_VIEW(pDocView));
f325b2
     if (pDocument && pDocument->pClass->getDocumentType(pDocument) == LOK_DOCTYPE_SPREADSHEET)
f325b2
     {
f325b2
-        m_aHeaders.clear();
f325b2
         char* pValues = pDocument->pClass->getCommandValues(pDocument, ".uno:ViewRowColumnHeaders");
f325b2
         std::stringstream aStream(pValues);
f325b2
         free(pValues);
f325b2
         assert(!aStream.str().empty());
f325b2
         boost::property_tree::ptree aTree;
f325b2
         boost::property_tree::read_json(aStream, aTree);
f325b2
+
f325b2
+        rWindow.m_pRowBar->m_aHeaders.clear();
f325b2
         for (boost::property_tree::ptree::value_type& rValue : aTree.get_child("rows"))
f325b2
         {
f325b2
             Header aHeader(std::atoi(rValue.second.get<std::string>("size").c_str()), rValue.second.get<std::string>("text"));
f325b2
-            m_aHeaders.push_back(aHeader);
f325b2
+            rWindow.m_pRowBar->m_aHeaders.push_back(aHeader);
f325b2
+        }
f325b2
+        gtk_widget_show(rWindow.m_pRowBar->m_pDrawingArea);
f325b2
+        gtk_widget_queue_draw(rWindow.m_pRowBar->m_pDrawingArea);
f325b2
+
f325b2
+        rWindow.m_pColumnBar->m_aHeaders.clear();
f325b2
+        for (boost::property_tree::ptree::value_type& rValue : aTree.get_child("columns"))
f325b2
+        {
f325b2
+            Header aHeader(std::atoi(rValue.second.get<std::string>("size").c_str()), rValue.second.get<std::string>("text"));
f325b2
+            rWindow.m_pColumnBar->m_aHeaders.push_back(aHeader);
f325b2
         }
f325b2
-        gtk_widget_show(m_pDrawingArea);
f325b2
-        gtk_widget_queue_draw(m_pDrawingArea);
f325b2
+        gtk_widget_show(rWindow.m_pColumnBar->m_pDrawingArea);
f325b2
+        gtk_widget_queue_draw(rWindow.m_pColumnBar->m_pDrawingArea);
f325b2
     }
f325b2
 
f325b2
     return TRUE;
f325b2
@@ -915,17 +943,22 @@ static GtkWidget* createWindow(TiledWindow& rWindow)
f325b2
 
f325b2
     gtk_box_pack_end(GTK_BOX(rWindow.m_pVBox), rWindow.m_pFindbar, FALSE, FALSE, 0);
f325b2
 
f325b2
-    // Horizontal box for the row bar + doc view.
f325b2
-    GtkWidget* pHBox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
f325b2
-    gtk_container_add(GTK_CONTAINER(rWindow.m_pVBox), pHBox);
f325b2
-    rWindow.m_pRowBar.reset(new TiledRowBar(rWindow.m_pDocView));
f325b2
-    gtk_box_pack_start(GTK_BOX(pHBox), rWindow.m_pRowBar->m_pDrawingArea, FALSE, FALSE, 0);
f325b2
+    // Grid for the row/column bar + doc view.
f325b2
+    GtkWidget* pGrid = gtk_grid_new();
f325b2
+    gtk_container_add(GTK_CONTAINER(rWindow.m_pVBox), pGrid);
f325b2
+    rWindow.m_pRowBar.reset(new TiledRowColumnBar(TiledRowColumnBar::ROW));
f325b2
+    // "A2" cell of the grid.
f325b2
+    gtk_grid_attach(GTK_GRID(pGrid), rWindow.m_pRowBar->m_pDrawingArea, 0, 1, 1, 1);
f325b2
+    rWindow.m_pColumnBar.reset(new TiledRowColumnBar(TiledRowColumnBar::COLUMN));
f325b2
+    // "B1" cell of the grid.
f325b2
+    gtk_grid_attach(GTK_GRID(pGrid), rWindow.m_pColumnBar->m_pDrawingArea, 1, 0, 1, 1);
f325b2
 
f325b2
     // Scrolled window for DocView
f325b2
     rWindow.m_pScrolledWindow = gtk_scrolled_window_new(0, 0);
f325b2
     gtk_widget_set_hexpand(rWindow.m_pScrolledWindow, TRUE);
f325b2
     gtk_widget_set_vexpand(rWindow.m_pScrolledWindow, TRUE);
f325b2
-    gtk_container_add(GTK_CONTAINER(pHBox), rWindow.m_pScrolledWindow);
f325b2
+    // "B2" cell of the grid
f325b2
+    gtk_grid_attach(GTK_GRID(pGrid), rWindow.m_pScrolledWindow, 1, 1, 1, 1);
f325b2
 
f325b2
     gtk_container_add(GTK_CONTAINER(rWindow.m_pScrolledWindow), rWindow.m_pDocView);
f325b2
 
f325b2
@@ -942,10 +975,12 @@ static GtkWidget* createWindow(TiledWindow& rWindow)
f325b2
     gtk_widget_show_all(pWindow);
f325b2
     // Hide the findbar by default.
f325b2
     gtk_widget_hide(rWindow.m_pFindbar);
f325b2
-    // Same for the row bar.
f325b2
+    // Same for the row/column bar.
f325b2
     gtk_widget_hide(rWindow.m_pRowBar->m_pDrawingArea);
f325b2
+    gtk_widget_hide(rWindow.m_pColumnBar->m_pDrawingArea);
f325b2
 
f325b2
     g_aWindows[pWindow] = rWindow;
f325b2
+    g_signal_connect(rWindow.m_pDocView, "configure-event", G_CALLBACK(TiledRowColumnBar::docConfigureEvent), 0);
f325b2
     return pWindow;
f325b2
 }
f325b2
 
f325b2
-- 
f325b2
2.12.0
f325b2