Blame SOURCES/0195-editeng-sw-sc-use-comphelper-string-join.patch

135360
From eacd7a0d10a02292f723031080884a8914fc496f Mon Sep 17 00:00:00 2001
135360
From: Miklos Vajna <vmiklos@collabora.co.uk>
135360
Date: Thu, 8 Oct 2015 08:37:12 +0200
135360
Subject: [PATCH 195/398] editeng, sw, sc: use comphelper::string::join()
135360
135360
(cherry picked from commit 1cb13d87b5d887718f6d81a842444b7251dc64cf)
135360
135360
Change-Id: I9b0a32271a965bc4089720ccb61b26b67ceab7b2
135360
---
135360
 sc/source/ui/view/gridwin.cxx | 13 ++++---------
135360
 1 file changed, 4 insertions(+), 9 deletions(-)
135360
135360
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
135360
index cfc0b5e27dd1..1320e27cb104 100644
135360
--- a/sc/source/ui/view/gridwin.cxx
135360
+++ b/sc/source/ui/view/gridwin.cxx
135360
@@ -134,6 +134,7 @@
135360
 #include <svx/sdr/overlay/overlaymanager.hxx>
135360
 #include <vcl/svapp.hxx>
135360
 #include <svx/sdr/overlay/overlayselection.hxx>
135360
+#include <comphelper/string.hxx>
135360
 
135360
 #define LOK_USE_UNSTABLE_API
135360
 #include <LibreOfficeKit/LibreOfficeKitEnums.h>
135360
@@ -5899,9 +5900,8 @@ static void updateLibreOfficeKitSelection(ScViewData* pViewData, ScDrawLayer* pD
135360
     double nPPTY = pViewData->GetPPTY();
135360
 
135360
     Rectangle aBoundingBox;
135360
-    std::stringstream ss;
135360
+    std::vector<OString> aRectangles;
135360
 
135360
-    bool bIsFirst = true;
135360
     for (auto aRectangle : rRectangles)
135360
     {
135360
         aRectangle.Right() += 1;
135360
@@ -5909,14 +5909,9 @@ static void updateLibreOfficeKitSelection(ScViewData* pViewData, ScDrawLayer* pD
135360
 
135360
         aBoundingBox.Union(aRectangle);
135360
 
135360
-        if (bIsFirst)
135360
-            bIsFirst = false;
135360
-        else
135360
-            ss << "; ";
135360
-
135360
         Rectangle aRect(aRectangle.Left() / nPPTX, aRectangle.Top() / nPPTY,
135360
                 aRectangle.Right() / nPPTX, aRectangle.Bottom() / nPPTY);
135360
-        ss << aRect.toString().getStr();
135360
+        aRectangles.push_back(aRect.toString());
135360
     }
135360
 
135360
     // selection start handle
135360
@@ -5930,7 +5925,7 @@ static void updateLibreOfficeKitSelection(ScViewData* pViewData, ScDrawLayer* pD
135360
     pDrawLayer->libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION_END, aEnd.toString().getStr());
135360
 
135360
     // the selection itself
135360
-    pDrawLayer->libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION, ss.str().c_str());
135360
+    pDrawLayer->libreOfficeKitCallback(LOK_CALLBACK_TEXT_SELECTION, comphelper::string::join("; ", aRectangles).getStr());
135360
 }
135360
 
135360
 void ScGridWindow::UpdateCursorOverlay()
135360
-- 
135360
2.12.0
135360