|
 |
dc0b3e |
From ffd8369b909c86653ef30593fddf67c9f5308583 Mon Sep 17 00:00:00 2001
|
|
|
dc0b3e |
From: Stephan Bergmann <sbergman@redhat.com>
|
|
|
dc0b3e |
Date: Mon, 5 Feb 2018 17:17:17 +0100
|
|
|
dc0b3e |
Subject: [PATCH] rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName
|
|
|
dc0b3e |
props
|
|
|
dc0b3e |
|
|
|
dc0b3e |
8f44fb5ee0bd21d192820ffd359504f6d1c68a52 "Mark Base window titles for
|
|
|
dc0b3e |
localisation" localized some uses of ooSetupFactoryUIName in
|
|
|
dc0b3e |
officecfg/registry/data/org/openoffice/Setup.xcu, but failed to mark the prop as
|
|
|
dc0b3e |
oor:localized="true" in officecfg/registry/schema/org/openoffice/Setup.xcs. (So
|
|
|
dc0b3e |
some arbitrary localized version of the prop would win at runtime, potentially
|
|
|
dc0b3e |
displaying certain window titles in wrong languages.)
|
|
|
dc0b3e |
|
|
|
dc0b3e |
Other uses of ooSetupFactoryUIName in Setup.xcu (for "Calc", "Impress",
|
|
|
dc0b3e |
"Writer", etc.) have never been localized, and are probably not meant to be
|
|
|
dc0b3e |
localized. AFAICS, irrespective of oor:localized="true" in Setup.xcs, their
|
|
|
dc0b3e |
values not being marked with xml:lang="en-US" in Setup.xcu will mean that they
|
|
|
dc0b3e |
will not appear in
|
|
|
dc0b3e |
translations/source/*/officecfg/registry/data/org/openoffice.po and will not
|
|
|
dc0b3e |
accidentally start to be translated after this commit.
|
|
|
dc0b3e |
|
|
|
dc0b3e |
(Theoretically, inconsistencies between oor:localized in xcs and uses of
|
|
|
dc0b3e |
xml:lang in xcu could statically be caught at build time, e.g., with
|
|
|
dc0b3e |
officecfg/util/sanity.xsl. However, those checks work on each XML file
|
|
|
dc0b3e |
individually, so don't have the schema information available when looking at
|
|
|
dc0b3e |
the data in the xcu file. And those checks are written in XSLT, which makes
|
|
|
dc0b3e |
writing new checks rather, erm, unpleasant.)
|
|
|
dc0b3e |
|
|
|
dc0b3e |
Change-Id: I9c61e8ebf75d3d54f7e5b6688eac47a6ed8dc5c3
|
|
|
dc0b3e |
Reviewed-on: https://gerrit.libreoffice.org/49252
|
|
|
dc0b3e |
Tested-by: Jenkins <ci@libreoffice.org>
|
|
|
dc0b3e |
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
dc0b3e |
---
|
|
|
dc0b3e |
officecfg/registry/schema/org/openoffice/Setup.xcs | 2 +-
|
|
|
dc0b3e |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
dc0b3e |
|
|
|
dc0b3e |
diff --git a/officecfg/registry/schema/org/openoffice/Setup.xcs b/officecfg/registry/schema/org/openoffice/Setup.xcs
|
|
|
dc0b3e |
index f55e3698f58f..31db1eca9af4 100644
|
|
|
dc0b3e |
--- a/officecfg/registry/schema/org/openoffice/Setup.xcs
|
|
|
dc0b3e |
+++ b/officecfg/registry/schema/org/openoffice/Setup.xcs
|
|
|
dc0b3e |
@@ -149,7 +149,7 @@
|
|
|
dc0b3e |
<desc>Specifies the short name of the factory.</desc>
|
|
|
dc0b3e |
</info>
|
|
|
dc0b3e |
</prop>
|
|
|
dc0b3e |
- <prop oor:name="ooSetupFactoryUIName" oor:type="xs:string">
|
|
|
dc0b3e |
+ <prop oor:name="ooSetupFactoryUIName" oor:type="xs:string" oor:localized="true">
|
|
|
dc0b3e |
|
|
|
dc0b3e |
<info>
|
|
|
dc0b3e |
<desc>Specifies the UI name of the factory.</desc>
|
|
|
dc0b3e |
--
|
|
|
dc0b3e |
2.14.3
|
|
|
dc0b3e |
|