|
 |
91334d |
From b6b0f7b99b68c66ea2b5e8e507c52801796b4d97 Mon Sep 17 00:00:00 2001
|
|
|
91334d |
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
|
|
|
91334d |
Date: Wed, 18 Oct 2017 11:05:20 +0100
|
|
|
91334d |
Subject: [PATCH] a11y: crash in use after dispose
|
|
|
91334d |
|
|
|
91334d |
calc, chart in tab 3 with a11y enabled, select chart
|
|
|
91334d |
switch to tab 1, crash cause mpParent has been deleted, IsDisposed
|
|
|
91334d |
is correctly set, but shape accesses parent anyway
|
|
|
91334d |
|
|
|
91334d |
Change-Id: I6f57a798bfcc82eebb883291cec54e157ff5187b
|
|
|
91334d |
|
|
|
91334d |
potential deref of empty xStateSet
|
|
|
91334d |
|
|
|
91334d |
Change-Id: I83d876b0d966b18cdf85249b7e856e4e4f4dec27
|
|
|
91334d |
---
|
|
|
91334d |
svx/source/accessibility/AccessibleShape.cxx | 6 ++++--
|
|
|
91334d |
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
|
91334d |
|
|
|
91334d |
diff --git a/svx/source/accessibility/AccessibleShape.cxx b/svx/source/accessibility/AccessibleShape.cxx
|
|
|
91334d |
index 043ba8e..47c0aca 100644
|
|
|
91334d |
--- a/svx/source/accessibility/AccessibleShape.cxx
|
|
|
91334d |
+++ b/svx/source/accessibility/AccessibleShape.cxx
|
|
|
91334d |
@@ -410,7 +410,9 @@ uno::Reference<XAccessibleStateSet> SAL_CALL
|
|
|
91334d |
::osl::MutexGuard aGuard (maMutex);
|
|
|
91334d |
Reference<XAccessibleStateSet> xStateSet;
|
|
|
91334d |
|
|
|
91334d |
- if (IsDisposed())
|
|
|
91334d |
+ bool bDisposed = IsDisposed();
|
|
|
91334d |
+
|
|
|
91334d |
+ if (bDisposed)
|
|
|
91334d |
{
|
|
|
91334d |
// Return a minimal state set that only contains the DEFUNC state.
|
|
|
91334d |
xStateSet = AccessibleContextBase::getAccessibleStateSet ();
|
|
|
91334d |
@@ -461,7 +463,7 @@ uno::Reference<XAccessibleStateSet> SAL_CALL
|
|
|
91334d |
xStateSet.set( new ::utl::AccessibleStateSetHelper (*pStateSet));
|
|
|
91334d |
}
|
|
|
91334d |
}
|
|
|
91334d |
- if (mpParent && mpParent->IsDocumentSelAll())
|
|
|
91334d |
+ if (!bDisposed && xStateSet.is() && mpParent && mpParent->IsDocumentSelAll())
|
|
|
91334d |
{
|
|
|
91334d |
::utl::AccessibleStateSetHelper* pStateSet =
|
|
|
91334d |
static_cast< ::utl::AccessibleStateSetHelper*>(xStateSet.get());
|
|
|
91334d |
--
|
|
|
91334d |
2.9.5
|
|
|
91334d |
|