Blame SOURCES/0004-CAB-block-input-buffer-is-one-byte-too-small-for-max.patch

927c2f
From fe3e1a4e9e41712b1ec115fa218af74f3286c2fe Mon Sep 17 00:00:00 2001
927c2f
From: Stuart Caie <kyzer@cabextract.org.uk>
927c2f
Date: Wed, 17 Oct 2018 11:33:35 +0100
927c2f
Subject: [PATCH 4/5] CAB block input buffer is one byte too small for maximal
927c2f
 Quantum block
927c2f
927c2f
(cherry picked from commit 40ef1b4093d77ad3a5cfcee1f5cb6108b3a3bcc2)
927c2f
---
927c2f
 libmspack/trunk/mspack/cab.h | 12 ++++++++++--
927c2f
 1 file changed, 10 insertions(+), 2 deletions(-)
927c2f
927c2f
diff --git a/libmspack/trunk/mspack/cab.h b/libmspack/trunk/mspack/cab.h
927c2f
index 59cf95e..25cebcb 100644
927c2f
--- a/libmspack/trunk/mspack/cab.h
927c2f
+++ b/libmspack/trunk/mspack/cab.h
927c2f
@@ -1,5 +1,5 @@
927c2f
 /* This file is part of libmspack.
927c2f
- * (C) 2003-2004 Stuart Caie.
927c2f
+ * (C) 2003-2018 Stuart Caie.
927c2f
  *
927c2f
  * libmspack is free software; you can redistribute it and/or modify it under
927c2f
  * the terms of the GNU Lesser General Public License (LGPL) version 2.1
927c2f
@@ -70,6 +70,14 @@
927c2f
 #define CAB_BLOCKMAX (32768)
927c2f
 #define CAB_INPUTMAX (CAB_BLOCKMAX+6144)
927c2f
 
927c2f
+/* input buffer needs to be CAB_INPUTMAX + 1 byte to allow for max-sized block
927c2f
+ * plus 1 trailer byte added by cabd_sys_read_block() for Quantum alignment.
927c2f
+ *
927c2f
+ * When MSCABD_PARAM_SALVAGE is set, block size is not checked so can be
927c2f
+ * up to 65535 bytes, so max input buffer size needed is 65535 + 1
927c2f
+ */
927c2f
+#define CAB_INPUTBUF (65535 + 1)
927c2f
+
927c2f
 /* There are no more than 65535 data blocks per folder, so a folder cannot
927c2f
  * be more than 32768*65535 bytes in length. As files cannot span more than
927c2f
  * one folder, this is also their max offset, length and offset+length limit.
927c2f
@@ -100,7 +108,7 @@ struct mscabd_decompress_state {
927c2f
   struct mspack_file *infh;          /* input file handle                    */
927c2f
   struct mspack_file *outfh;         /* output file handle                   */
927c2f
   unsigned char *i_ptr, *i_end;      /* input data consumed, end             */
927c2f
-  unsigned char input[CAB_INPUTMAX]; /* one input block of data              */
927c2f
+  unsigned char input[CAB_INPUTBUF]; /* one input block of data              */
927c2f
 };
927c2f
 
927c2f
 struct mscab_decompressor_p {
927c2f
-- 
927c2f
2.19.0.rc0
927c2f