e91cda
From cc34aab2a455546431da8e8abb0d854a70c71962 Mon Sep 17 00:00:00 2001
e91cda
From: Paolo Bonzini <pbonzini@redhat.com>
e91cda
Date: Tue, 9 Oct 2018 15:14:16 +0100
e91cda
Subject: [PATCH 3/6] sync: remove unnecessary checks
e91cda
e91cda
RH-Author: Paolo Bonzini <pbonzini@redhat.com>
e91cda
Message-id: <20181009151419.20418-4-pbonzini@redhat.com>
e91cda
Patchwork-id: 82506
e91cda
O-Subject: [RHEL8 libiscsi PATCH 3/6] sync: remove unnecessary checks
e91cda
Bugzilla: 1634541
e91cda
RH-Acked-by: Thomas Huth <thuth@redhat.com>
e91cda
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
e91cda
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
e91cda
e91cda
state is always non-NULL in iscsi_sync_cb and iscsi_discovery_cb.
e91cda
e91cda
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
e91cda
(cherry picked from commit f507c94774bff0c851880813d95f5d0a8fbdace8)
e91cda
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
e91cda
---
e91cda
 lib/sync.c | 14 +++++---------
e91cda
 1 file changed, 5 insertions(+), 9 deletions(-)
e91cda
e91cda
diff --git a/lib/sync.c b/lib/sync.c
e91cda
index 9fb78e7..34ed64e 100644
e91cda
--- a/lib/sync.c
e91cda
+++ b/lib/sync.c
e91cda
@@ -85,10 +85,8 @@ iscsi_sync_cb(struct iscsi_context *iscsi _U_, int status,
e91cda
 {
e91cda
 	struct iscsi_sync_state *state = private_data;
e91cda
 
e91cda
-	if (state != NULL) {
e91cda
-		state->status    = status;
e91cda
-		state->finished = 1;
e91cda
-	}
e91cda
+	state->status    = status;
e91cda
+	state->finished = 1;
e91cda
 }
e91cda
 
e91cda
 int
e91cda
@@ -1818,11 +1816,9 @@ iscsi_discovery_cb(struct iscsi_context *iscsi _U_, int status,
e91cda
                 }
e91cda
         }
e91cda
 
e91cda
-	if (state != NULL) {
e91cda
-		state->status    = status;
e91cda
-		state->finished = 1;
e91cda
-                state->ptr = dahead;
e91cda
-	}
e91cda
+	state->status    = status;
e91cda
+	state->finished = 1;
e91cda
+	state->ptr = dahead;
e91cda
 }
e91cda
 
e91cda
 struct iscsi_discovery_address *
e91cda
-- 
e91cda
1.8.3.1
e91cda