|
 |
a30de4 |
From db196dc098d213638d7513bb98a72d1778658299 Mon Sep 17 00:00:00 2001
|
|
|
a30de4 |
From: Pino Toscano <ptoscano@redhat.com>
|
|
|
a30de4 |
Date: Tue, 5 Dec 2017 15:36:34 +0100
|
|
|
a30de4 |
Subject: [PATCH] lib: libvirt: stop using <shareable/> for appliance disk
|
|
|
a30de4 |
(RHBZ#1518517)
|
|
|
a30de4 |
|
|
|
a30de4 |
Commit aa9e0057b19e29f76c9a81f9aebeeb1cb5bf1fdb made the libvirt backend
|
|
|
a30de4 |
use <shareable/> for the disk of the appliance, since at that time all
|
|
|
a30de4 |
the instances were using the disk directly.
|
|
|
a30de4 |
OTOH, commit 3ad44c866042919374e2d840502e53da2ed8aef0 switched to
|
|
|
a30de4 |
overlays for read-only disks, including the appliance, so effectively
|
|
|
a30de4 |
protecting the appliance.
|
|
|
a30de4 |
|
|
|
a30de4 |
Because of this, the libvirt backend does not need <shareable/> anymore.
|
|
|
a30de4 |
|
|
|
a30de4 |
Thanks to: Daniel Berrange, Richard W.M. Jones, Peter Krempa.
|
|
|
a30de4 |
---
|
|
|
a30de4 |
lib/launch-libvirt.c | 6 ------
|
|
|
a30de4 |
1 file changed, 6 deletions(-)
|
|
|
a30de4 |
|
|
|
a30de4 |
diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c
|
|
|
a30de4 |
index d10c7cb40..05c398ba0 100644
|
|
|
a30de4 |
--- a/lib/launch-libvirt.c
|
|
|
a30de4 |
+++ b/lib/launch-libvirt.c
|
|
|
a30de4 |
@@ -969,10 +969,6 @@ static int construct_libvirt_xml_appliance (guestfs_h *g, const struct libvirt_x
|
|
|
a30de4 |
} \
|
|
|
a30de4 |
} while (0)
|
|
|
a30de4 |
|
|
|
a30de4 |
-/* <element/> */
|
|
|
a30de4 |
-#define empty_element(element) \
|
|
|
a30de4 |
- do { start_element(element) {} end_element (); } while (0)
|
|
|
a30de4 |
-
|
|
|
a30de4 |
/* key=value attribute of the current element. */
|
|
|
a30de4 |
#define attribute(key,value) \
|
|
|
a30de4 |
if (xmlTextWriterWriteAttribute (xo, BAD_CAST (key), BAD_CAST (value)) == -1){ \
|
|
|
a30de4 |
@@ -1758,8 +1754,6 @@ construct_libvirt_xml_appliance (guestfs_h *g,
|
|
|
a30de4 |
== -1)
|
|
|
a30de4 |
return -1;
|
|
|
a30de4 |
|
|
|
a30de4 |
- empty_element ("shareable");
|
|
|
a30de4 |
-
|
|
|
a30de4 |
} end_element ();
|
|
|
a30de4 |
|
|
|
a30de4 |
return 0;
|
|
|
a30de4 |
--
|
|
|
a30de4 |
2.14.3
|
|
|
a30de4 |
|