Blame SOURCES/0057-v2v-o-rhv-upload-Make-oo-rhv-cafile-optional-in-all-.patch

da373f
From fdf461e88c464de697c14adea2e8e61644811844 Mon Sep 17 00:00:00 2001
3efd08
From: "Richard W.M. Jones" <rjones@redhat.com>
3efd08
Date: Wed, 15 Jan 2020 11:12:17 +0000
3efd08
Subject: [PATCH] v2v: -o rhv-upload: Make -oo rhv-cafile optional in all cases
3efd08
 (RHBZ#1791240).
3efd08
3efd08
This is actually not required, because ovirtsdk4 will use the system's
3efd08
global trust store if necessary.  Therefore we can make it optional in
3efd08
all cases.
3efd08
3efd08
(cherry picked from commit 65ee9387d4be0e3c5cd214b967fef7a1a8841233
3efd08
in virt-v2v)
3efd08
---
3efd08
 v2v/output_rhv_upload.ml    | 2 --
3efd08
 v2v/virt-v2v-output-rhv.pod | 5 ++++-
3efd08
 2 files changed, 4 insertions(+), 3 deletions(-)
3efd08
3efd08
diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
3efd08
index 2c8c18732..e1d06867b 100644
3efd08
--- a/v2v/output_rhv_upload.ml
3efd08
+++ b/v2v/output_rhv_upload.ml
3efd08
@@ -81,8 +81,6 @@ let parse_output_options options =
3efd08
   let rhv_direct = !rhv_direct in
3efd08
   let rhv_verifypeer = !rhv_verifypeer in
3efd08
   let rhv_disk_uuids = Option.map List.rev !rhv_disk_uuids in
3efd08
-  if rhv_verifypeer && rhv_cafile = None then
3efd08
-     error (f_"-o rhv-upload: must use ‘-oo rhv-cafile’ to supply the path to the oVirt or RHV user’s ‘ca.pem’ file");
3efd08
 
3efd08
   { rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer; rhv_disk_uuids }
3efd08
 
3efd08
diff --git a/v2v/virt-v2v-output-rhv.pod b/v2v/virt-v2v-output-rhv.pod
3efd08
index 04a894268..4520c9184 100644
3efd08
--- a/v2v/virt-v2v-output-rhv.pod
3efd08
+++ b/v2v/virt-v2v-output-rhv.pod
3efd08
@@ -101,7 +101,10 @@ The storage domain.
3efd08
 The F<ca.pem> file (Certificate Authority), copied from
3efd08
 F</etc/pki/ovirt-engine/ca.pem> on the oVirt engine.
3efd08
 
3efd08
-This option must be specified if I<-oo rhv-verifypeer> is enabled.
3efd08
+If I<-oo rhv-verifypeer> is enabled then this option can
3efd08
+be used to control which CA is used to verify the client’s
3efd08
+identity.  If this option is not used then the system’s
3efd08
+global trust store is used.
3efd08
 
3efd08
 =item I<-oo rhv-cluster=>C<CLUSTERNAME>
3efd08
 
3efd08
-- 
da373f
2.18.4
3efd08