|
 |
a55b49 |
From cb2ac63562447e2780bd7103ed060fd6013b9054 Mon Sep 17 00:00:00 2001
|
|
|
d0ea73 |
From: "Richard W.M. Jones" <rjones@redhat.com>
|
|
|
d0ea73 |
Date: Tue, 7 Jul 2015 09:28:03 -0400
|
|
|
d0ea73 |
Subject: [PATCH] RHEL 8: Reject use of libguestfs-winsupport features except
|
|
|
d0ea73 |
for virt-* tools (RHBZ#1240276).
|
|
|
d0ea73 |
|
|
|
a55b49 |
Fix the tests: it doesn't let us use guestfish for arbitrary Windows
|
|
|
a55b49 |
edits.
|
|
|
d0ea73 |
---
|
|
|
a55b49 |
generator/c.ml | 16 ++++++++++++++++
|
|
|
a55b49 |
test-data/phony-guests/make-windows-img.sh | 1 +
|
|
|
a55b49 |
tests/charsets/test-charset-fidelity.c | 2 ++
|
|
|
a55b49 |
3 files changed, 19 insertions(+)
|
|
|
d0ea73 |
|
|
|
d0ea73 |
diff --git a/generator/c.ml b/generator/c.ml
|
|
|
a55b49 |
index 86d3b26f8..a625361a9 100644
|
|
|
d0ea73 |
--- a/generator/c.ml
|
|
|
d0ea73 |
+++ b/generator/c.ml
|
|
|
a55b49 |
@@ -1846,6 +1846,22 @@ and generate_client_actions actions () =
|
|
|
d0ea73 |
check_args_validity c_name style;
|
|
|
d0ea73 |
trace_call name c_name style;
|
|
|
d0ea73 |
|
|
|
d0ea73 |
+ (* RHEL 8 *)
|
|
|
d0ea73 |
+ if name = "mount" || name = "mount_ro" || name = "mount_options" ||
|
|
|
d0ea73 |
+ name = "mount_vfs" then (
|
|
|
d0ea73 |
+ pr " if (g->program && !STRPREFIX (g->program, \"virt-\")) {\n";
|
|
|
d0ea73 |
+ pr " CLEANUP_FREE char *vfs_type = guestfs_vfs_type (g, mountable);\n";
|
|
|
d0ea73 |
+ pr " if (vfs_type && STREQ (vfs_type, \"ntfs\")) {\n";
|
|
|
d0ea73 |
+ pr " error (g, \"mount: unsupported filesystem type\");\n";
|
|
|
d0ea73 |
+ pr " if (trace_flag)\n";
|
|
|
d0ea73 |
+ pr " guestfs_int_trace (g, \"%%s = %%s (error)\",\n";
|
|
|
d0ea73 |
+ pr " \"%s\", \"-1\");\n" name;
|
|
|
d0ea73 |
+ pr " return %s;\n" (string_of_errcode errcode);
|
|
|
d0ea73 |
+ pr " }\n";
|
|
|
d0ea73 |
+ pr " }\n";
|
|
|
d0ea73 |
+ pr "\n";
|
|
|
d0ea73 |
+ );
|
|
|
d0ea73 |
+
|
|
|
d0ea73 |
(* Calculate the total size of all FileIn arguments to pass
|
|
|
d0ea73 |
* as a progress bar hint.
|
|
|
d0ea73 |
*)
|
|
|
a55b49 |
diff --git a/test-data/phony-guests/make-windows-img.sh b/test-data/phony-guests/make-windows-img.sh
|
|
|
a55b49 |
index 30908a918..73cf5144e 100755
|
|
|
a55b49 |
--- a/test-data/phony-guests/make-windows-img.sh
|
|
|
a55b49 |
+++ b/test-data/phony-guests/make-windows-img.sh
|
|
|
a55b49 |
@@ -37,6 +37,7 @@ fi
|
|
|
a55b49 |
|
|
|
a55b49 |
# Create a disk image.
|
|
|
a55b49 |
guestfish <
|
|
|
a55b49 |
+set-program virt-testing
|
|
|
a55b49 |
sparse windows.img-t 512M
|
|
|
a55b49 |
run
|
|
|
a55b49 |
|
|
|
a55b49 |
diff --git a/tests/charsets/test-charset-fidelity.c b/tests/charsets/test-charset-fidelity.c
|
|
|
a55b49 |
index 39ccc2068..2b2e2d8a9 100644
|
|
|
a55b49 |
--- a/tests/charsets/test-charset-fidelity.c
|
|
|
a55b49 |
+++ b/tests/charsets/test-charset-fidelity.c
|
|
|
a55b49 |
@@ -94,6 +94,8 @@ main (int argc, char *argv[])
|
|
|
a55b49 |
if (g == NULL)
|
|
|
a55b49 |
error (EXIT_FAILURE, 0, "failed to create handle");
|
|
|
a55b49 |
|
|
|
a55b49 |
+ guestfs_set_program (g, "virt-testing");
|
|
|
a55b49 |
+
|
|
|
a55b49 |
if (guestfs_add_drive_scratch (g, 1024*1024*1024, -1) == -1)
|
|
|
a55b49 |
exit (EXIT_FAILURE);
|
|
|
a55b49 |
|
|
|
d0ea73 |
--
|
|
|
a55b49 |
2.31.1
|
|
|
d0ea73 |
|