|
 |
7cfb7a |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
7cfb7a |
From: "Eduardo Lima (Etrunko)" <etrunko@redhat.com>
|
|
|
7cfb7a |
Date: Wed, 10 May 2017 16:12:01 -0300
|
|
|
7cfb7a |
Subject: [PATCH] storage-domain: use explicit initialization of struct
|
|
|
7cfb7a |
OvirtXmlElement members
|
|
|
7cfb7a |
|
|
|
7cfb7a |
Also, members have been reordered and the xml_node field has been
|
|
|
7cfb7a |
renamed to more proper xml_path.
|
|
|
7cfb7a |
|
|
|
7cfb7a |
Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
|
|
7cfb7a |
|
|
|
7cfb7a |
govirt/ovirt-storage-domain.c | 46 ++++++++++++++++++++++++++
|
|
|
7cfb7a |
1 file changed, 34 insertions(+), 12 deletions(-)
|
|
|
7cfb7a |
|
|
|
7cfb7a |
diff
|
|
|
7cfb7a |
index 4087d75..07c0ef0 100644
|
|
|
7cfb7a |
|
|
|
7cfb7a |
|
|
|
7cfb7a |
@@ -323,9 +323,9 @@ end:
|
|
|
7cfb7a |
}
|
|
|
7cfb7a |
|
|
|
7cfb7a |
typedef struct {
|
|
|
7cfb7a |
- const char *xml_node;
|
|
|
7cfb7a |
- GType type;
|
|
|
7cfb7a |
const char *prop_name;
|
|
|
7cfb7a |
+ GType type;
|
|
|
7cfb7a |
+ const char *xml_path;
|
|
|
7cfb7a |
} OvirtXmlElement;
|
|
|
7cfb7a |
|
|
|
7cfb7a |
static gboolean
|
|
|
7cfb7a |
@@ -336,11 +336,12 @@ ovirt_resource_parse_xml(OvirtResource *resource,
|
|
|
7cfb7a |
g_return_val_if_fail(OVIRT_IS_RESOURCE(resource), FALSE);
|
|
|
7cfb7a |
g_return_val_if_fail(elements != NULL, FALSE);
|
|
|
7cfb7a |
|
|
|
7cfb7a |
- for (;elements->xml_node != NULL; elements++) {
|
|
|
7cfb7a |
+ for (;elements->xml_path != NULL; elements++) {
|
|
|
7cfb7a |
const char *value_str;
|
|
|
7cfb7a |
GValue value = { 0, };
|
|
|
7cfb7a |
|
|
|
7cfb7a |
- value_str = ovirt_rest_xml_node_get_content_from_path(node, elements->xml_node);
|
|
|
7cfb7a |
+ value_str = ovirt_rest_xml_node_get_content_from_path(node, elements->xml_path);
|
|
|
7cfb7a |
+
|
|
|
7cfb7a |
g_value_init(&value, elements->type);
|
|
|
7cfb7a |
if (_set_property_value_from_type(&value, elements->type, value_str, node))
|
|
|
7cfb7a |
g_object_set_property(G_OBJECT(resource), elements->prop_name, &value);
|
|
|
7cfb7a |
@@ -355,14 +356,35 @@ ovirt_storage_domain_refresh_from_xml(OvirtStorageDomain *domain,
|
|
|
7cfb7a |
RestXmlNode *node)
|
|
|
7cfb7a |
{
|
|
|
7cfb7a |
OvirtXmlElement storage_domain_elements[] = {
|
|
|
7cfb7a |
- { "type", OVIRT_TYPE_STORAGE_DOMAIN_TYPE, "type" },
|
|
|
7cfb7a |
- { "master", G_TYPE_BOOLEAN, "master" },
|
|
|
7cfb7a |
- { "available", G_TYPE_UINT64, "available" },
|
|
|
7cfb7a |
- { "used", G_TYPE_UINT64, "used" },
|
|
|
7cfb7a |
- { "committed", G_TYPE_UINT64, "committed" },
|
|
|
7cfb7a |
- { "storage_format", OVIRT_TYPE_STORAGE_DOMAIN_FORMAT_VERSION, "version" },
|
|
|
7cfb7a |
- { "status/state", OVIRT_TYPE_STORAGE_DOMAIN_STATE, "state" },
|
|
|
7cfb7a |
- { NULL, G_TYPE_INVALID, NULL }
|
|
|
7cfb7a |
+ { .prop_name = "type",
|
|
|
7cfb7a |
+ .type = OVIRT_TYPE_STORAGE_DOMAIN_TYPE,
|
|
|
7cfb7a |
+ .xml_path = "type",
|
|
|
7cfb7a |
+ },
|
|
|
7cfb7a |
+ { .prop_name = "master",
|
|
|
7cfb7a |
+ .type = G_TYPE_BOOLEAN,
|
|
|
7cfb7a |
+ .xml_path = "master",
|
|
|
7cfb7a |
+ },
|
|
|
7cfb7a |
+ { .prop_name = "available",
|
|
|
7cfb7a |
+ .type = G_TYPE_UINT64,
|
|
|
7cfb7a |
+ .xml_path = "available",
|
|
|
7cfb7a |
+ },
|
|
|
7cfb7a |
+ { .prop_name = "used",
|
|
|
7cfb7a |
+ .type = G_TYPE_UINT64,
|
|
|
7cfb7a |
+ .xml_path = "used",
|
|
|
7cfb7a |
+ },
|
|
|
7cfb7a |
+ { .prop_name = "committed",
|
|
|
7cfb7a |
+ .type = G_TYPE_UINT64,
|
|
|
7cfb7a |
+ .xml_path = "committed",
|
|
|
7cfb7a |
+ },
|
|
|
7cfb7a |
+ { .prop_name = "version",
|
|
|
7cfb7a |
+ .type = OVIRT_TYPE_STORAGE_DOMAIN_FORMAT_VERSION,
|
|
|
7cfb7a |
+ .xml_path = "storage_format",
|
|
|
7cfb7a |
+ },
|
|
|
7cfb7a |
+ { .prop_name = "state",
|
|
|
7cfb7a |
+ .type = OVIRT_TYPE_STORAGE_DOMAIN_STATE,
|
|
|
7cfb7a |
+ .xml_path = "status/state",
|
|
|
7cfb7a |
+ },
|
|
|
7cfb7a |
+ { NULL , }
|
|
|
7cfb7a |
};
|
|
|
7cfb7a |
|
|
|
7cfb7a |
return ovirt_resource_parse_xml(OVIRT_RESOURCE(domain), node, storage_domain_elements);
|