Blame SOURCES/libgcrypt-1.5.3-rsa-fips-keygen.patch

241384
diff -up libgcrypt-1.5.3/cipher/primegen.c.fips-keygen libgcrypt-1.5.3/cipher/primegen.c
241384
--- libgcrypt-1.5.3/cipher/primegen.c.fips-keygen	2014-10-21 15:05:59.434189992 +0200
241384
+++ libgcrypt-1.5.3/cipher/primegen.c	2014-10-21 15:05:59.458190534 +0200
241384
@@ -1189,6 +1189,22 @@ gcry_prime_check (gcry_mpi_t x, unsigned
241384
   return gcry_error (err);
241384
 }
241384
 
241384
+/* Check whether the number X is prime according to FIPS 186-4 table C.2.  */
241384
+gpg_err_code_t
241384
+_gcry_fips186_4_prime_check (gcry_mpi_t x, unsigned int bits)
241384
+{
241384
+  gpg_err_code_t ec = GPG_ERR_NO_ERROR;
241384
+  gcry_mpi_t val_2 = mpi_alloc_set_ui (2); /* Used by the Fermat test. */
241384
+
241384
+  /* We use 5 or 4 rounds as specified in table C.2 */
241384
+  if (! check_prime (x, val_2, bits > 1024 ? 4 : 5, NULL, NULL))
241384
+    ec = GPG_ERR_NO_PRIME;
241384
+
241384
+  mpi_free (val_2);
241384
+
241384
+  return ec;
241384
+}
241384
+
241384
 /* Find a generator for PRIME where the factorization of (prime-1) is
241384
    in the NULL terminated array FACTORS. Return the generator as a
241384
    newly allocated MPI in R_G.  If START_G is not NULL, use this as s
241384
diff -up libgcrypt-1.5.3/cipher/rsa.c.fips-keygen libgcrypt-1.5.3/cipher/rsa.c
241384
--- libgcrypt-1.5.3/cipher/rsa.c.fips-keygen	2014-10-21 15:05:59.423189744 +0200
241384
+++ libgcrypt-1.5.3/cipher/rsa.c	2014-10-21 15:12:45.200350340 +0200
241384
@@ -328,6 +328,279 @@ generate_std (RSA_secret_key *sk, unsign
241384
 }
241384
 
241384
 
241384
+/****************
241384
+ * Generate a key pair with a key of size NBITS.
241384
+ * USE_E = 0 let Libcgrypt decide what exponent to use.
241384
+ *       = 1 request the use of a "secure" exponent; this is required by some
241384
+ *           specification to be 65537.
241384
+ *       > 2 Use this public exponent.  If the given exponent
241384
+ *           is not odd one is internally added to it.
241384
+ * TESTPARMS: If set, do not generate but test whether the p,q is probably prime
241384
+ *            Returns key with zeroes to not break code calling this function.
241384
+ * TRANSIENT_KEY:  If true, generate the primes using the standard RNG.
241384
+ * Returns: 2 structures filled with all needed values
241384
+ */
241384
+static gpg_err_code_t
241384
+generate_fips (RSA_secret_key *sk, unsigned int nbits, unsigned long use_e,
241384
+               gcry_sexp_t testparms, int transient_key)
241384
+{
241384
+  gcry_mpi_t p, q; /* the two primes */
241384
+  gcry_mpi_t d;    /* the private key */
241384
+  gcry_mpi_t u;
241384
+  gcry_mpi_t p1, q1;
241384
+  gcry_mpi_t n;    /* the public key */
241384
+  gcry_mpi_t e;    /* the exponent */
241384
+  gcry_mpi_t g;
241384
+  gcry_mpi_t minp;
241384
+  gcry_mpi_t diff, mindiff;
241384
+  gcry_random_level_t random_level;
241384
+  unsigned int pbits = nbits/2;
241384
+  unsigned int i;
241384
+  int pqswitch;
241384
+  gpg_err_code_t ec = GPG_ERR_NO_PRIME;
241384
+
241384
+  if (nbits < 1024 || (nbits & 0x1FF))
241384
+      return GPG_ERR_INV_VALUE;
241384
+  if (_gcry_enforced_fips_mode() && nbits != 2048 && nbits != 3072)
241384
+      return GPG_ERR_INV_VALUE;
241384
+
241384
+  /* The random quality depends on the transient_key flag.  */
241384
+  random_level = transient_key ? GCRY_STRONG_RANDOM : GCRY_VERY_STRONG_RANDOM;
241384
+
241384
+  if (testparms)
241384
+      {
241384
+        /* Parameters to derive the key are given.  */
241384
+        /* Note that we explicitly need to setup the values of tbl
241384
+           because some compilers (e.g. OpenWatcom, IRIX) don't allow
241384
+           to initialize a structure with automatic variables.  */
241384
+        struct { const char *name; gcry_mpi_t *value; } tbl[] = {
241384
+          { "e" },
241384
+          { "p" },
241384
+          { "q" },
241384
+          { NULL }
241384
+        };
241384
+        int idx;
241384
+        gcry_sexp_t oneparm;
241384
+
241384
+        tbl[0].value = &e;
241384
+        tbl[1].value = &p;
241384
+        tbl[2].value = &q;
241384
+
241384
+        for (idx=0; tbl[idx].name; idx++)
241384
+          {
241384
+            oneparm = gcry_sexp_find_token (testparms, tbl[idx].name, 0);
241384
+            if (oneparm)
241384
+              {
241384
+                *tbl[idx].value = gcry_sexp_nth_mpi (oneparm, 1,
241384
+                                                     GCRYMPI_FMT_USG);
241384
+                gcry_sexp_release (oneparm);
241384
+              }
241384
+          }
241384
+        for (idx=0; tbl[idx].name; idx++)
241384
+          if (!*tbl[idx].value)
241384
+            break;
241384
+        if (tbl[idx].name)
241384
+          {
241384
+            /* At least one parameter is missing.  */
241384
+            for (idx=0; tbl[idx].name; idx++)
241384
+              gcry_mpi_release (*tbl[idx].value);
241384
+            return GPG_ERR_MISSING_VALUE;
241384
+          }
241384
+      }
241384
+  else
241384
+      {
241384
+        if (use_e < 65537)
241384
+          use_e = 65537;  /* This is the smallest value allowed by FIPS */
241384
+
241384
+        e = mpi_alloc( (32+BITS_PER_MPI_LIMB-1)/BITS_PER_MPI_LIMB );
241384
+
241384
+        use_e |= 1; /* make sure this is odd */
241384
+        mpi_set_ui (e, use_e);
241384
+
241384
+        p = gcry_mpi_snew (pbits);
241384
+        q = gcry_mpi_snew (pbits);
241384
+      }
241384
+
241384
+  n = gcry_mpi_new (nbits);
241384
+  d = gcry_mpi_snew (nbits);
241384
+  u = gcry_mpi_snew (nbits);
241384
+
241384
+  /* prepare approximate minimum p and q */
241384
+  minp = gcry_mpi_new (pbits);
241384
+  mpi_set_ui (minp, 0xB504F334);
241384
+  gcry_mpi_lshift (minp, minp, pbits - 32); 
241384
+
241384
+  /* prepare minimum p and q difference */
241384
+  diff = gcry_mpi_new (pbits);
241384
+  mindiff = gcry_mpi_new (pbits - 99);
241384
+  mpi_set_ui (mindiff, 1);
241384
+  gcry_mpi_lshift (mindiff, mindiff, pbits - 100);
241384
+
241384
+  p1 = gcry_mpi_snew (pbits);
241384
+  q1 = gcry_mpi_snew (pbits);
241384
+  g  = gcry_mpi_snew (pbits);
241384
+
241384
+retry:
241384
+  /* generate p and q */
241384
+  for (i = 0; i < 5 * pbits; i++)
241384
+    {
241384
+    ploop:
241384
+      if (!testparms)
241384
+        {
241384
+          gcry_mpi_randomize (p, pbits, random_level);
241384
+        }
241384
+      if (mpi_cmp (p, minp) < 0)
241384
+        {
241384
+          if (testparms) goto err;
241384
+          goto ploop;
241384
+        }
241384
+
241384
+      mpi_sub_ui (p1, p, 1);
241384
+      if (gcry_mpi_gcd (g, p1, e))
241384
+        {
241384
+          if (_gcry_fips186_4_prime_check (p, pbits) != GPG_ERR_NO_ERROR)
241384
+            {
241384
+              /* not a prime */
241384
+              if (testparms) goto err;
241384
+            }
241384
+          else
241384
+            break;
241384
+        } 
241384
+      else if (testparms) goto err;
241384
+    }
241384
+  if (i >= 5 * pbits)
241384
+    goto err;
241384
+
241384
+  for (i = 0; i < 5 * pbits; i++)
241384
+    {
241384
+    qloop:
241384
+      if (!testparms)
241384
+        {
241384
+          gcry_mpi_randomize (q, pbits, random_level);
241384
+        }
241384
+      if (mpi_cmp (q, minp) < 0)
241384
+        {
241384
+          if (testparms) goto err;
241384
+          goto qloop;
241384
+        }
241384
+      if (mpi_cmp (p, q) > 0)
241384
+        {
241384
+          pqswitch = 1;
241384
+          mpi_sub (diff, p, q);
241384
+        }      
241384
+      else
241384
+        {
241384
+          pqswitch = 0;
241384
+          mpi_sub (diff, q, p);
241384
+        }
241384
+      if (mpi_cmp (diff, mindiff) < 0)
241384
+        {
241384
+          if (testparms) goto err;
241384
+          goto qloop;
241384
+        }
241384
+
241384
+      mpi_sub_ui (q1, q, 1);
241384
+      if (gcry_mpi_gcd (g, q1, e))
241384
+        {
241384
+          if (_gcry_fips186_4_prime_check (q, pbits) != GPG_ERR_NO_ERROR)
241384
+            {
241384
+              /* not a prime */
241384
+              if (testparms) goto err;
241384
+            }
241384
+          else
241384
+            break;
241384
+        }
241384
+      else if (testparms) goto err;
241384
+    }
241384
+  if (i >= 5 * pbits)
241384
+    goto err;
241384
+
241384
+  if (testparms)
241384
+    {
241384
+       mpi_clear (p);
241384
+       mpi_clear (q);
241384
+    }
241384
+  else
241384
+    {
241384
+      gcry_mpi_t f;
241384
+
241384
+      if (pqswitch)
241384
+        {
241384
+          gcry_mpi_t tmp;
241384
+
241384
+          tmp = p;
241384
+          p = q;
241384
+          q = tmp;
241384
+        }
241384
+
241384
+      f = gcry_mpi_snew (nbits);
241384
+
241384
+      /* calculate the modulus */
241384
+      mpi_mul(n, p, q);
241384
+
241384
+      /* calculate the secret key d = e^1 mod phi */
241384
+      gcry_mpi_gcd (g, p1, q1);
241384
+      mpi_fdiv_q (f, p1, g);
241384
+      mpi_mul (f, f, q1);
241384
+      
241384
+      mpi_invm (d, e, f);
241384
+
241384
+      gcry_mpi_release (f);
241384
+
241384
+      if (mpi_get_nbits (d) < pbits) goto retry;
241384
+
241384
+      /* calculate the inverse of p and q (used for chinese remainder theorem)*/
241384
+      mpi_invm(u, p, q );
241384
+    }
241384
+
241384
+  ec = 0;
241384
+
241384
+  if( DBG_CIPHER )
241384
+    {
241384
+      log_mpidump("  p= ", p );
241384
+      log_mpidump("  q= ", q );
241384
+      log_mpidump("  n= ", n );
241384
+      log_mpidump("  e= ", e );
241384
+      log_mpidump("  d= ", d );
241384
+      log_mpidump("  u= ", u );
241384
+    }
241384
+
241384
+err:
241384
+
241384
+  gcry_mpi_release (p1);
241384
+  gcry_mpi_release (q1);
241384
+  gcry_mpi_release (g);
241384
+  gcry_mpi_release (minp);
241384
+  gcry_mpi_release (mindiff);
241384
+  gcry_mpi_release (diff);
241384
+
241384
+  sk->n = n;
241384
+  sk->e = e;
241384
+  sk->p = p;
241384
+  sk->q = q;
241384
+  sk->d = d;
241384
+  sk->u = u;
241384
+
241384
+  /* Now we can test our keys. */
241384
+  if (ec || (!testparms && test_keys (sk, nbits - 64)))
241384
+    {
241384
+      gcry_mpi_release (sk->n); sk->n = NULL;
241384
+      gcry_mpi_release (sk->e); sk->e = NULL;
241384
+      gcry_mpi_release (sk->p); sk->p = NULL;
241384
+      gcry_mpi_release (sk->q); sk->q = NULL;
241384
+      gcry_mpi_release (sk->d); sk->d = NULL;
241384
+      gcry_mpi_release (sk->u); sk->u = NULL;
241384
+      if (!ec)
241384
+        {
241384
+          fips_signal_error ("self-test after key generation failed");
241384
+          return GPG_ERR_SELFTEST_FAILED;
241384
+        }
241384
+    }
241384
+
241384
+  return ec;
241384
+}
241384
+
241384
+
241384
 /* Helper for generate_x931.  */
241384
 static gcry_mpi_t
241384
 gen_x931_parm_xp (unsigned int nbits)
241384
@@ -812,7 +1085,7 @@ rsa_generate_ext (int algo, unsigned int
241384
         }
241384
     }
241384
 
241384
-  if (deriveparms || use_x931 || fips_mode ())
241384
+  if (deriveparms || use_x931)
241384
     {
241384
       int swapped;
241384
       ec = generate_x931 (&sk, nbits, evalue, deriveparms, &swapped);
241384
@@ -841,8 +1114,14 @@ rsa_generate_ext (int algo, unsigned int
241384
           transient_key = 1;
241384
           gcry_sexp_release (l1);
241384
         }
241384
+      deriveparms = (genparms?
241384
+                 gcry_sexp_find_token (genparms, "test-parms", 0) : NULL);
241384
       /* Generate.  */
241384
-      ec = generate_std (&sk, nbits, evalue, transient_key);
241384
+      if (deriveparms || fips_mode())
241384
+	ec = generate_fips (&sk, nbits, evalue, deriveparms, transient_key);
241384
+      else
241384
+        ec = generate_std (&sk, nbits, evalue, transient_key);
241384
+      gcry_sexp_release (deriveparms);
241384
     }
241384
 
241384
   if (!ec)
241384
diff -up libgcrypt-1.5.3/src/g10lib.h.fips-keygen libgcrypt-1.5.3/src/g10lib.h
241384
--- libgcrypt-1.5.3/src/g10lib.h.fips-keygen	2013-07-25 11:10:04.000000000 +0200
241384
+++ libgcrypt-1.5.3/src/g10lib.h	2014-10-21 15:05:59.459190556 +0200
241384
@@ -195,6 +195,9 @@ gpg_err_code_t _gcry_generate_fips186_3_
241384
                   int *r_counter,
241384
                   void **r_seed, size_t *r_seedlen, int *r_hashalgo);
241384
 
241384
+gpg_err_code_t _gcry_fips186_4_prime_check
241384
+                 (const gcry_mpi_t x, unsigned int bits);
241384
+
241384
 
241384
 /* Replacements of missing functions (missing-string.c).  */
241384
 #ifndef HAVE_STPCPY
241384
diff -up libgcrypt-1.5.3/tests/keygen.c.fips-keygen libgcrypt-1.5.3/tests/keygen.c
241384
--- libgcrypt-1.5.3/tests/keygen.c.fips-keygen	2014-10-21 15:05:59.424189766 +0200
241384
+++ libgcrypt-1.5.3/tests/keygen.c	2014-10-21 15:05:59.459190556 +0200
241384
@@ -190,12 +190,12 @@ check_rsa_keys (void)
241384
 
241384
 
241384
   if (verbose)
241384
-    fprintf (stderr, "creating 1024 bit RSA key with e=257\n");
241384
+    fprintf (stderr, "creating 1024 bit RSA key with e=65539\n");
241384
   rc = gcry_sexp_new (&keyparm,
241384
                       "(genkey\n"
241384
                       " (rsa\n"
241384
                       "  (nbits 4:1024)\n"
241384
-                      "  (rsa-use-e 3:257)\n"
241384
+                      "  (rsa-use-e 5:65539)\n"
241384
                       " ))", 0, 1);
241384
   if (rc)
241384
     die ("error creating S-expression: %s\n", gpg_strerror (rc));
241384
@@ -204,7 +204,7 @@ check_rsa_keys (void)
241384
   if (rc)
241384
     die ("error generating RSA key: %s\n", gpg_strerror (rc));
241384
 
241384
-  check_generated_rsa_key (key, 257);
241384
+  check_generated_rsa_key (key, 65539);
241384
   gcry_sexp_release (key);
241384
 
241384
   if (verbose)