Blame SOURCES/0170-tests-Add-more-notes-about-umockdev-recording-creati.patch

73b847
From 10086a20c80dc067607a5b73c10f0eae215846c7 Mon Sep 17 00:00:00 2001
73b847
From: Benjamin Berg <bberg@redhat.com>
73b847
Date: Tue, 7 Jan 2020 13:45:33 +0100
73b847
Subject: [PATCH 170/181] tests: Add more notes about umockdev recording
73b847
 creation
73b847
73b847
umockdev recordings are usually not usable as is. Add some notes to the
73b847
README to summarise what kind of changes may be required.
73b847
---
73b847
 tests/README-umockdev | 31 ++++++++++++++++++++++++++++++-
73b847
 1 file changed, 30 insertions(+), 1 deletion(-)
73b847
73b847
diff --git a/tests/README-umockdev b/tests/README-umockdev
73b847
index cabbace..eec3598 100644
73b847
--- a/tests/README-umockdev
73b847
+++ b/tests/README-umockdev
73b847
@@ -21,4 +21,33 @@ To create a new umockdev test, you should:
73b847
 Please note, there is no need to use a real finger print in this case. If
73b847
 you would like to avoid submitting your own fingerprint then please just
73b847
 use e.g. the side of your finger, arm, or anything else that will produce
73b847
-an image with the device.
73b847
\ No newline at end of file
73b847
+an image with the device.
73b847
+
73b847
+
73b847
+Note that umockdev-record groups URBs aggressively. In most cases, manual
73b847
+intervention is unfortunately required. In most cases, drivers do a chain
73b847
+of commands like e.g. A then B each with a different reply. Umockdev will
73b847
+create a file like:
73b847
+
73b847
+A
73b847
+ reply 1
73b847
+ reply 2
73b847
+B
73b847
+ reply 1
73b847
+ reply 2
73b847
+
73b847
+which then needs to be re-ordered to be:
73b847
+
73b847
+A
73b847
+ reply 1
73b847
+B
73b847
+ reply 1
73b847
+A
73b847
+ reply 2
73b847
+B
73b847
+ reply 2
73b847
+
73b847
+Other changes may be needed to get everything working. For example the elan
73b847
+driver relies on a timeout that is not reported correctly. In this case the
73b847
+driver works around it by interpreting the protocol error differently in
73b847
+the virtual environment.
73b847
\ No newline at end of file
73b847
-- 
73b847
2.24.1
73b847