|
 |
f51234 |
From 28d26ba51dac6565a796a4e2c68ad28f89af398f Mon Sep 17 00:00:00 2001
|
|
|
f51234 |
From: Bastien Nocera <hadess@hadess.net>
|
|
|
f51234 |
Date: Tue, 29 Oct 2013 11:42:31 +0100
|
|
|
f51234 |
Subject: [PATCH 3/3] Fix clang warning
|
|
|
f51234 |
|
|
|
f51234 |
dmap-md5.c:187:26: warning: 'memset' call operates on objects of type 'MD5_CTX'
|
|
|
f51234 |
while the size is based on a different
|
|
|
f51234 |
type 'MD5_CTX *' [-Wsizeof-pointer-memaccess]
|
|
|
f51234 |
memset (ctx, 0, sizeof (ctx)); /* In case it's sensitive */
|
|
|
f51234 |
~~~ ^~~
|
|
|
f51234 |
|
|
|
f51234 |
That should be "sizeof(*ctx)" instead.
|
|
|
f51234 |
|
|
|
f51234 |
See https://bugzilla.redhat.com/show_bug.cgi?id=1023528
|
|
|
f51234 |
|
|
|
f51234 |
https://bugzilla.gnome.org/show_bug.cgi?id=711063
|
|
|
f51234 |
---
|
|
|
f51234 |
libdmapsharing/dmap-md5.c | 2 +-
|
|
|
f51234 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
f51234 |
|
|
|
f51234 |
diff --git a/libdmapsharing/dmap-md5.c b/libdmapsharing/dmap-md5.c
|
|
|
f51234 |
index 4472472..c646d6c 100644
|
|
|
f51234 |
--- a/libdmapsharing/dmap-md5.c
|
|
|
f51234 |
+++ b/libdmapsharing/dmap-md5.c
|
|
|
f51234 |
@@ -176,7 +176,7 @@ DMAP_MD5Final (DMAPHashContext * ctx, unsigned char digest[16])
|
|
|
f51234 |
MD5Transform (ctx->buf, (guint32 *) ctx->in, ctx->version);
|
|
|
f51234 |
byteReverse ((unsigned char *) ctx->buf, 4);
|
|
|
f51234 |
memcpy (digest, ctx->buf, 16);
|
|
|
f51234 |
- memset (ctx, 0, sizeof (ctx)); /* In case it's sensitive */
|
|
|
f51234 |
+ memset (ctx, 0, sizeof (*ctx)); /* In case it's sensitive */
|
|
|
f51234 |
|
|
|
f51234 |
return;
|
|
|
f51234 |
}
|
|
|
f51234 |
--
|
|
|
f51234 |
1.8.3.1
|
|
|
f51234 |
|