5af5b2
Reference docs don't define what happens if you call krb5_realm_compare() with
5af5b2
malformed krb5_principal structures.  Define a behavior which keeps it from
5af5b2
crashing if applications don't check ahead of time.
5af5b2
4be148
--- krb5/src/lib/krb5/krb/princ_comp.c
4be148
+++ krb5/src/lib/krb5/krb/princ_comp.c
4be148
@@ -41,6 +41,10 @@ realm_compare_flags(krb5_context context
4be148
     const krb5_data *realm1 = &princ1->realm;
4be148
     const krb5_data *realm2 = &princ2->realm;
5af5b2
 
4be148
+    if (princ1 == NULL || princ2 == NULL)
5af5b2
+        return FALSE;
4be148
+    if (realm1 == NULL || realm2 == NULL)
5af5b2
+        return FALSE;
5af5b2
     if (realm1->length != realm2->length)
5af5b2
         return FALSE;
4be148
     if (realm1->length == 0)
5af5b2
@@ -92,6 +98,9 @@ krb5_principal_compare_flags(krb5_contex
5af5b2
     krb5_principal upn2 = NULL;
5af5b2
     krb5_boolean ret = FALSE;
5af5b2
 
4be148
+    if (princ1 == NULL || princ2 == NULL)
5af5b2
+        return FALSE;
5af5b2
+
5af5b2
     if (flags & KRB5_PRINCIPAL_COMPARE_ENTERPRISE) {
5af5b2
         /* Treat UPNs as if they were real principals */
4be148
         if (princ1->type == KRB5_NT_ENTERPRISE_PRINCIPAL) {