|
 |
6cfd83 |
From 42e29f27ce64fece2839bcce910813e97ca31210 Mon Sep 17 00:00:00 2001
|
|
|
0ba406 |
From: Robbie Harwood <rharwood@redhat.com>
|
|
|
0ba406 |
Date: Wed, 15 Jul 2020 15:42:20 -0400
|
|
|
0ba406 |
Subject: [PATCH] Ignore bad enctypes in krb5_string_to_keysalts()
|
|
|
0ba406 |
|
|
|
0ba406 |
Fixes a problem where the presence of legacy/unrecognized keysalts in
|
|
|
0ba406 |
supported_enctypes would prevent the kadmin programs from starting.
|
|
|
0ba406 |
|
|
|
0ba406 |
[ghudson@mit.edu: ideally we would put a warning in the kadmind log,
|
|
|
0ba406 |
but that is difficult to do when the parsing is done inside a library.
|
|
|
0ba406 |
Even adding a trace log is difficult because the kadm5 str_conv
|
|
|
0ba406 |
functions do not accept contexts.]
|
|
|
0ba406 |
|
|
|
0ba406 |
ticket: 8929 (new)
|
|
|
0ba406 |
(cherry picked from commit be5396ada0e8dabd68bd0aceb733cfca39a609bc)
|
|
|
0ba406 |
(cherry picked from commit 3f873868fb08b77da2d30e164a0ef6c71c17c607)
|
|
|
0ba406 |
---
|
|
|
0ba406 |
src/lib/kadm5/str_conv.c | 7 ++++---
|
|
|
0ba406 |
1 file changed, 4 insertions(+), 3 deletions(-)
|
|
|
0ba406 |
|
|
|
0ba406 |
diff --git a/src/lib/kadm5/str_conv.c b/src/lib/kadm5/str_conv.c
|
|
|
0ba406 |
index 7cf51d316..798295606 100644
|
|
|
0ba406 |
--- a/src/lib/kadm5/str_conv.c
|
|
|
0ba406 |
+++ b/src/lib/kadm5/str_conv.c
|
|
|
0ba406 |
@@ -340,9 +340,10 @@ krb5_string_to_keysalts(const char *string, const char *tupleseps,
|
|
|
0ba406 |
while ((ksp = strtok_r(p, tseps, &tlasts)) != NULL) {
|
|
|
0ba406 |
/* Pass a null pointer to subsequent calls to strtok_r(). */
|
|
|
0ba406 |
p = NULL;
|
|
|
0ba406 |
- ret = string_to_keysalt(ksp, ksaltseps, &etype, &stype);
|
|
|
0ba406 |
- if (ret)
|
|
|
0ba406 |
- goto cleanup;
|
|
|
0ba406 |
+
|
|
|
0ba406 |
+ /* Discard unrecognized keysalts. */
|
|
|
0ba406 |
+ if (string_to_keysalt(ksp, ksaltseps, &etype, &stype) != 0)
|
|
|
0ba406 |
+ continue;
|
|
|
0ba406 |
|
|
|
0ba406 |
/* Ignore duplicate keysalts if caller asks. */
|
|
|
0ba406 |
if (!dups && krb5_keysalt_is_present(ksalts, nksalts, etype, stype))
|