|
 |
d738b9 |
From 4d42f950965f16a9eb77444a99abe76a8b4ac12c Mon Sep 17 00:00:00 2001
|
|
|
d738b9 |
From: Greg Hudson <ghudson@mit.edu>
|
|
|
d738b9 |
Date: Mon, 24 Apr 2017 02:02:36 -0400
|
|
|
d738b9 |
Subject: [PATCH] Fix in_clock_skew() and use it in AS client code
|
|
|
d738b9 |
|
|
|
d738b9 |
Add a context parameter to the in_clock_skew() macro so that it isn't
|
|
|
d738b9 |
implicitly relying on a local variable. Use it in
|
|
|
d738b9 |
get_in_tkt.c:verify_as_reply().
|
|
|
d738b9 |
|
|
|
d738b9 |
(cherry picked from commit 28a07a6461bb443b7fa75cc5cb859ad0db4cbb5a)
|
|
|
d738b9 |
---
|
|
|
d738b9 |
src/lib/krb5/krb/gc_via_tkt.c | 2 +-
|
|
|
d738b9 |
src/lib/krb5/krb/get_in_tkt.c | 4 ++--
|
|
|
d738b9 |
src/lib/krb5/krb/int-proto.h | 3 ++-
|
|
|
d738b9 |
3 files changed, 5 insertions(+), 4 deletions(-)
|
|
|
d738b9 |
|
|
|
d738b9 |
diff --git a/src/lib/krb5/krb/gc_via_tkt.c b/src/lib/krb5/krb/gc_via_tkt.c
|
|
|
d738b9 |
index 4c0a1a461..c85d8b8d8 100644
|
|
|
d738b9 |
--- a/src/lib/krb5/krb/gc_via_tkt.c
|
|
|
d738b9 |
+++ b/src/lib/krb5/krb/gc_via_tkt.c
|
|
|
d738b9 |
@@ -305,7 +305,7 @@ krb5int_process_tgs_reply(krb5_context context,
|
|
|
d738b9 |
goto cleanup;
|
|
|
d738b9 |
|
|
|
d738b9 |
if (!in_cred->times.starttime &&
|
|
|
d738b9 |
- !in_clock_skew(dec_rep->enc_part2->times.starttime,
|
|
|
d738b9 |
+ !in_clock_skew(context, dec_rep->enc_part2->times.starttime,
|
|
|
d738b9 |
timestamp)) {
|
|
|
d738b9 |
retval = KRB5_KDCREP_SKEW;
|
|
|
d738b9 |
goto cleanup;
|
|
|
d738b9 |
diff --git a/src/lib/krb5/krb/get_in_tkt.c b/src/lib/krb5/krb/get_in_tkt.c
|
|
|
d738b9 |
index 54badbbc3..a058f5bd7 100644
|
|
|
d738b9 |
--- a/src/lib/krb5/krb/get_in_tkt.c
|
|
|
d738b9 |
+++ b/src/lib/krb5/krb/get_in_tkt.c
|
|
|
d738b9 |
@@ -287,8 +287,8 @@ verify_as_reply(krb5_context context,
|
|
|
d738b9 |
return retval;
|
|
|
d738b9 |
} else {
|
|
|
d738b9 |
if ((request->from == 0) &&
|
|
|
d738b9 |
- (labs(as_reply->enc_part2->times.starttime - time_now)
|
|
|
d738b9 |
- > context->clockskew))
|
|
|
d738b9 |
+ !in_clock_skew(context, as_reply->enc_part2->times.starttime,
|
|
|
d738b9 |
+ time_now))
|
|
|
d738b9 |
return (KRB5_KDCREP_SKEW);
|
|
|
d738b9 |
}
|
|
|
d738b9 |
return 0;
|
|
|
d738b9 |
diff --git a/src/lib/krb5/krb/int-proto.h b/src/lib/krb5/krb/int-proto.h
|
|
|
d738b9 |
index 6da74858e..44eca359f 100644
|
|
|
d738b9 |
--- a/src/lib/krb5/krb/int-proto.h
|
|
|
d738b9 |
+++ b/src/lib/krb5/krb/int-proto.h
|
|
|
d738b9 |
@@ -83,7 +83,8 @@ krb5int_construct_matching_creds(krb5_context context, krb5_flags options,
|
|
|
d738b9 |
krb5_creds *in_creds, krb5_creds *mcreds,
|
|
|
d738b9 |
krb5_flags *fields);
|
|
|
d738b9 |
|
|
|
d738b9 |
-#define in_clock_skew(date, now) (labs((date)-(now)) < context->clockskew)
|
|
|
d738b9 |
+#define in_clock_skew(context, date, now) \
|
|
|
d738b9 |
+ (labs((date) - (now)) < (context)->clockskew)
|
|
|
d738b9 |
|
|
|
d738b9 |
#define IS_TGS_PRINC(p) ((p)->length == 2 && \
|
|
|
d738b9 |
data_eq_string((p)->data[0], KRB5_TGS_NAME))
|