|
 |
d8f823 |
From 134f8606ebca3094b8e2f3994f1b2797ae867749 Mon Sep 17 00:00:00 2001
|
|
|
d8f823 |
From: Alaa Hleihel <ahleihel@redhat.com>
|
|
|
d8f823 |
Date: Tue, 12 May 2020 10:55:13 -0400
|
|
|
d8f823 |
Subject: [PATCH 197/312] [netdrv] net/mlx5e: Add missing release firmware call
|
|
|
d8f823 |
|
|
|
d8f823 |
Message-id: <20200512105530.4207-108-ahleihel@redhat.com>
|
|
|
d8f823 |
Patchwork-id: 306978
|
|
|
d8f823 |
Patchwork-instance: patchwork
|
|
|
d8f823 |
O-Subject: [RHEL8.3 BZ 1789382 107/124] net/mlx5e: Add missing release firmware call
|
|
|
d8f823 |
Bugzilla: 1789382
|
|
|
d8f823 |
RH-Acked-by: Tony Camuso <tcamuso@redhat.com>
|
|
|
d8f823 |
RH-Acked-by: Kamal Heib <kheib@redhat.com>
|
|
|
d8f823 |
RH-Acked-by: Jarod Wilson <jarod@redhat.com>
|
|
|
d8f823 |
|
|
|
d8f823 |
Bugzilla: http://bugzilla.redhat.com/1789382
|
|
|
d8f823 |
Upstream: v5.7-rc2
|
|
|
d8f823 |
|
|
|
d8f823 |
commit d19987ccf57501894fdd8fadc2e55e4a3dd57239
|
|
|
d8f823 |
Author: Eran Ben Elisha <eranbe@mellanox.com>
|
|
|
d8f823 |
Date: Tue Mar 24 15:04:26 2020 +0200
|
|
|
d8f823 |
|
|
|
d8f823 |
net/mlx5e: Add missing release firmware call
|
|
|
d8f823 |
|
|
|
d8f823 |
Once driver finishes flashing the firmware image, it should release it.
|
|
|
d8f823 |
|
|
|
d8f823 |
Fixes: 9c8bca2637b8 ("mlx5: Move firmware flash implementation to devlink")
|
|
|
d8f823 |
Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
|
|
|
d8f823 |
Reviewed-by: Aya Levin <ayal@mellanox.com>
|
|
|
d8f823 |
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
|
|
|
d8f823 |
|
|
|
d8f823 |
Signed-off-by: Alaa Hleihel <ahleihel@redhat.com>
|
|
|
d8f823 |
Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>
|
|
|
d8f823 |
---
|
|
|
d8f823 |
drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 5 ++++-
|
|
|
d8f823 |
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
d8f823 |
|
|
|
d8f823 |
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
|
|
|
d8f823 |
index 381925c90d94..d63ce3feb65c 100644
|
|
|
d8f823 |
--- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
|
|
|
d8f823 |
+++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
|
|
|
d8f823 |
@@ -23,7 +23,10 @@ static int mlx5_devlink_flash_update(struct devlink *devlink,
|
|
|
d8f823 |
if (err)
|
|
|
d8f823 |
return err;
|
|
|
d8f823 |
|
|
|
d8f823 |
- return mlx5_firmware_flash(dev, fw, extack);
|
|
|
d8f823 |
+ err = mlx5_firmware_flash(dev, fw, extack);
|
|
|
d8f823 |
+ release_firmware(fw);
|
|
|
d8f823 |
+
|
|
|
d8f823 |
+ return err;
|
|
|
d8f823 |
}
|
|
|
d8f823 |
|
|
|
d8f823 |
static u8 mlx5_fw_ver_major(u32 version)
|
|
|
d8f823 |
--
|
|
|
d8f823 |
2.13.6
|
|
|
d8f823 |
|