Blame SOURCES/0118-netdrv-net-mlx5e-Always-print-health-reporter-messag.patch

d8f823
From f20856e12e6ea7721607296c4e006b50332add56 Mon Sep 17 00:00:00 2001
d8f823
From: Alaa Hleihel <ahleihel@redhat.com>
d8f823
Date: Sun, 10 May 2020 15:04:43 -0400
d8f823
Subject: [PATCH 118/312] [netdrv] net/mlx5e: Always print health reporter
d8f823
 message to dmesg
d8f823
d8f823
Message-id: <20200510150452.10307-79-ahleihel@redhat.com>
d8f823
Patchwork-id: 306702
d8f823
Patchwork-instance: patchwork
d8f823
O-Subject: [RHEL8.3 BZ 1789380 v2 78/87] net/mlx5e: Always print health reporter message to dmesg
d8f823
Bugzilla: 1789380
d8f823
RH-Acked-by: Kamal Heib <kheib@redhat.com>
d8f823
RH-Acked-by: Jarod Wilson <jarod@redhat.com>
d8f823
RH-Acked-by: Tony Camuso <tcamuso@redhat.com>
d8f823
RH-Acked-by: Jonathan Toppins <jtoppins@redhat.com>
d8f823
d8f823
Bugzilla: http://bugzilla.redhat.com/1789380
d8f823
Upstream: v5.5-rc6
d8f823
d8f823
commit 99cda45426c9a2c59bb2f7cb886a405440282455
d8f823
Author: Eran Ben Elisha <eranbe@mellanox.com>
d8f823
Date:   Wed Dec 4 14:34:18 2019 +0200
d8f823
d8f823
    net/mlx5e: Always print health reporter message to dmesg
d8f823
d8f823
    In case a reporter exists, error message is logged only to the devlink
d8f823
    tracer. The devlink tracer is a visibility utility only, which user can
d8f823
    choose not to monitor.
d8f823
    After cited patch, 3rd party monitoring tools that tracks these error
d8f823
    message will no longer find them in dmesg, causing a regression.
d8f823
d8f823
    With this patch, error messages are also logged into the dmesg.
d8f823
d8f823
    Fixes: c50de4af1d63 ("net/mlx5e: Generalize tx reporter's functionality")
d8f823
    Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
d8f823
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
d8f823
d8f823
Signed-off-by: Alaa Hleihel <ahleihel@redhat.com>
d8f823
Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>
d8f823
---
d8f823
 drivers/net/ethernet/mellanox/mlx5/core/en/health.c | 7 ++++---
d8f823
 1 file changed, 4 insertions(+), 3 deletions(-)
d8f823
d8f823
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/health.c b/drivers/net/ethernet/mellanox/mlx5/core/en/health.c
d8f823
index 1d6b58860da6..3a975641f902 100644
d8f823
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/health.c
d8f823
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/health.c
d8f823
@@ -197,9 +197,10 @@ int mlx5e_health_report(struct mlx5e_priv *priv,
d8f823
 			struct devlink_health_reporter *reporter, char *err_str,
d8f823
 			struct mlx5e_err_ctx *err_ctx)
d8f823
 {
d8f823
-	if (!reporter) {
d8f823
-		netdev_err(priv->netdev, err_str);
d8f823
+	netdev_err(priv->netdev, err_str);
d8f823
+
d8f823
+	if (!reporter)
d8f823
 		return err_ctx->recover(&err_ctx->ctx);
d8f823
-	}
d8f823
+
d8f823
 	return devlink_health_report(reporter, err_str, err_ctx);
d8f823
 }
d8f823
-- 
d8f823
2.13.6
d8f823