|
 |
f95c89 |
From c0fca90e2368d9632e50ad92844591bb15830aa3 Mon Sep 17 00:00:00 2001
|
|
|
f95c89 |
From: Jonathan Toppins <jtoppins@redhat.com>
|
|
|
f95c89 |
Date: Fri, 6 Dec 2019 20:12:51 -0500
|
|
|
f95c89 |
Subject: [PATCH 94/96] [netdrv] bnxt_en: Improve
|
|
|
f95c89 |
bnxt_ulp_stop()/bnxt_ulp_start() call sequence
|
|
|
f95c89 |
|
|
|
f95c89 |
Message-id: <9db03065554258d9fea296da3c76419aa2bbc777.1575651772.git.jtoppins@redhat.com>
|
|
|
f95c89 |
Patchwork-id: 291385
|
|
|
f95c89 |
O-Subject: [PATCH rhel8 11/13] bnxt_en: Improve bnxt_ulp_stop()/bnxt_ulp_start() call sequence.
|
|
|
f95c89 |
Bugzilla: 1773724
|
|
|
f95c89 |
RH-Acked-by: Steve Best <sbest@redhat.com>
|
|
|
f95c89 |
RH-Acked-by: David Arcari <darcari@redhat.com>
|
|
|
f95c89 |
RH-Acked-by: Jarod Wilson <jarod@redhat.com>
|
|
|
f95c89 |
RH-Acked-by: John Linville <linville@redhat.com>
|
|
|
f95c89 |
|
|
|
f95c89 |
We call bnxt_ulp_stop() to notify the RDMA driver that some error or
|
|
|
f95c89 |
imminent reset is about to happen. After that we always call
|
|
|
f95c89 |
some variants of bnxt_close().
|
|
|
f95c89 |
|
|
|
f95c89 |
In the next patch, we will integrate the recently added error
|
|
|
f95c89 |
recovery with the RDMA driver. In response to ulp_stop, the
|
|
|
f95c89 |
RDMA driver may free MSIX vectors and that will also trigger
|
|
|
f95c89 |
bnxt_close(). To avoid bnxt_close() from being called twice,
|
|
|
f95c89 |
we set a new flag after ulp_stop is called. If the RDMA driver
|
|
|
f95c89 |
frees MSIX vectors while the new flag is set, we will not call
|
|
|
f95c89 |
bnxt_close(), knowing that it will happen in due course.
|
|
|
f95c89 |
|
|
|
f95c89 |
With this change, we must make sure that the bnxt_close() call
|
|
|
f95c89 |
after ulp_stop will reset IRQ. Modify bnxt_reset_task()
|
|
|
f95c89 |
accordingly if we call ulp_stop.
|
|
|
f95c89 |
|
|
|
f95c89 |
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
|
|
|
f95c89 |
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
|
|
|
f95c89 |
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
|
f95c89 |
(cherry picked from commit aa46dffff452f7c6d907c4e6a0062e2c53a87fc0)
|
|
|
f95c89 |
Bugzilla: 1773724
|
|
|
f95c89 |
Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=25154853
|
|
|
f95c89 |
Tested: simple boot test
|
|
|
f95c89 |
Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
|
|
|
f95c89 |
Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
|
|
|
f95c89 |
---
|
|
|
f95c89 |
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++++++++++--------
|
|
|
f95c89 |
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 10 ++++++++--
|
|
|
f95c89 |
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 3 ++-
|
|
|
f95c89 |
3 files changed, 20 insertions(+), 11 deletions(-)
|
|
|
f95c89 |
|
|
|
f95c89 |
Index: src/drivers/net/ethernet/broadcom/bnxt/bnxt.c
|
|
|
f95c89 |
===================================================================
|
|
|
f95c89 |
--- src.orig/drivers/net/ethernet/broadcom/bnxt/bnxt.c 2020-02-06 16:23:22.576450128 +0100
|
|
|
f95c89 |
+++ src/drivers/net/ethernet/broadcom/bnxt/bnxt.c 2020-02-06 16:23:22.982446401 +0100
|
|
|
f95c89 |
@@ -9932,12 +9932,15 @@
|
|
|
f95c89 |
if (netif_running(bp->dev)) {
|
|
|
f95c89 |
int rc;
|
|
|
f95c89 |
|
|
|
f95c89 |
- if (!silent)
|
|
|
f95c89 |
+ if (silent) {
|
|
|
f95c89 |
+ bnxt_close_nic(bp, false, false);
|
|
|
f95c89 |
+ bnxt_open_nic(bp, false, false);
|
|
|
f95c89 |
+ } else {
|
|
|
f95c89 |
bnxt_ulp_stop(bp);
|
|
|
f95c89 |
- bnxt_close_nic(bp, false, false);
|
|
|
f95c89 |
- rc = bnxt_open_nic(bp, false, false);
|
|
|
f95c89 |
- if (!silent && !rc)
|
|
|
f95c89 |
- bnxt_ulp_start(bp);
|
|
|
f95c89 |
+ bnxt_close_nic(bp, true, false);
|
|
|
f95c89 |
+ rc = bnxt_open_nic(bp, true, false);
|
|
|
f95c89 |
+ bnxt_ulp_start(bp, rc);
|
|
|
f95c89 |
+ }
|
|
|
f95c89 |
}
|
|
|
f95c89 |
}
|
|
|
f95c89 |
|
|
|
f95c89 |
@@ -12034,10 +12037,9 @@
|
|
|
f95c89 |
if (!err && netif_running(netdev))
|
|
|
f95c89 |
err = bnxt_open(netdev);
|
|
|
f95c89 |
|
|
|
f95c89 |
- if (!err) {
|
|
|
f95c89 |
+ if (!err)
|
|
|
f95c89 |
result = PCI_ERS_RESULT_RECOVERED;
|
|
|
f95c89 |
- bnxt_ulp_start(bp);
|
|
|
f95c89 |
- }
|
|
|
f95c89 |
+ bnxt_ulp_start(bp, err);
|
|
|
f95c89 |
}
|
|
|
f95c89 |
|
|
|
f95c89 |
if (result != PCI_ERS_RESULT_RECOVERED && netif_running(netdev))
|
|
|
f95c89 |
Index: src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
|
|
|
f95c89 |
===================================================================
|
|
|
f95c89 |
--- src.orig/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c 2020-02-06 16:23:20.163472277 +0100
|
|
|
f95c89 |
+++ src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c 2020-02-06 16:23:22.982446401 +0100
|
|
|
f95c89 |
@@ -182,7 +182,7 @@
|
|
|
f95c89 |
|
|
|
f95c89 |
edev->ulp_tbl[ulp_id].msix_requested = 0;
|
|
|
f95c89 |
edev->flags &= ~BNXT_EN_FLAG_MSIX_REQUESTED;
|
|
|
f95c89 |
- if (netif_running(dev)) {
|
|
|
f95c89 |
+ if (netif_running(dev) && !(edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) {
|
|
|
f95c89 |
bnxt_close_nic(bp, true, false);
|
|
|
f95c89 |
bnxt_open_nic(bp, true, false);
|
|
|
f95c89 |
}
|
|
|
f95c89 |
@@ -266,6 +266,7 @@
|
|
|
f95c89 |
if (!edev)
|
|
|
f95c89 |
return;
|
|
|
f95c89 |
|
|
|
f95c89 |
+ edev->flags |= BNXT_EN_FLAG_ULP_STOPPED;
|
|
|
f95c89 |
for (i = 0; i < BNXT_MAX_ULP; i++) {
|
|
|
f95c89 |
struct bnxt_ulp *ulp = &edev->ulp_tbl[i];
|
|
|
f95c89 |
|
|
|
f95c89 |
@@ -276,7 +277,7 @@
|
|
|
f95c89 |
}
|
|
|
f95c89 |
}
|
|
|
f95c89 |
|
|
|
f95c89 |
-void bnxt_ulp_start(struct bnxt *bp)
|
|
|
f95c89 |
+void bnxt_ulp_start(struct bnxt *bp, int err)
|
|
|
f95c89 |
{
|
|
|
f95c89 |
struct bnxt_en_dev *edev = bp->edev;
|
|
|
f95c89 |
struct bnxt_ulp_ops *ops;
|
|
|
f95c89 |
@@ -285,6 +286,11 @@
|
|
|
f95c89 |
if (!edev)
|
|
|
f95c89 |
return;
|
|
|
f95c89 |
|
|
|
f95c89 |
+ edev->flags &= ~BNXT_EN_FLAG_ULP_STOPPED;
|
|
|
f95c89 |
+
|
|
|
f95c89 |
+ if (err)
|
|
|
f95c89 |
+ return;
|
|
|
f95c89 |
+
|
|
|
f95c89 |
for (i = 0; i < BNXT_MAX_ULP; i++) {
|
|
|
f95c89 |
struct bnxt_ulp *ulp = &edev->ulp_tbl[i];
|
|
|
f95c89 |
|
|
|
f95c89 |
Index: src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h
|
|
|
f95c89 |
===================================================================
|
|
|
f95c89 |
--- src.orig/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h 2020-02-06 16:22:53.036721279 +0100
|
|
|
f95c89 |
+++ src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h 2020-02-06 16:23:22.982446401 +0100
|
|
|
f95c89 |
@@ -64,6 +64,7 @@
|
|
|
f95c89 |
#define BNXT_EN_FLAG_ROCE_CAP (BNXT_EN_FLAG_ROCEV1_CAP | \
|
|
|
f95c89 |
BNXT_EN_FLAG_ROCEV2_CAP)
|
|
|
f95c89 |
#define BNXT_EN_FLAG_MSIX_REQUESTED 0x4
|
|
|
f95c89 |
+ #define BNXT_EN_FLAG_ULP_STOPPED 0x8
|
|
|
f95c89 |
const struct bnxt_en_ops *en_ops;
|
|
|
f95c89 |
struct bnxt_ulp ulp_tbl[BNXT_MAX_ULP];
|
|
|
f95c89 |
};
|
|
|
f95c89 |
@@ -92,7 +93,7 @@
|
|
|
f95c89 |
int bnxt_get_ulp_msix_base(struct bnxt *bp);
|
|
|
f95c89 |
int bnxt_get_ulp_stat_ctxs(struct bnxt *bp);
|
|
|
f95c89 |
void bnxt_ulp_stop(struct bnxt *bp);
|
|
|
f95c89 |
-void bnxt_ulp_start(struct bnxt *bp);
|
|
|
f95c89 |
+void bnxt_ulp_start(struct bnxt *bp, int err);
|
|
|
f95c89 |
void bnxt_ulp_sriov_cfg(struct bnxt *bp, int num_vfs);
|
|
|
f95c89 |
void bnxt_ulp_shutdown(struct bnxt *bp);
|
|
|
f95c89 |
void bnxt_ulp_irq_stop(struct bnxt *bp);
|