From 4dc98c1995482262e70e83ef029135247fafe0f2 Mon Sep 17 00:00:00 2001

From: Anton Vasilyev <vasilyev@ispras.ru>

Date: Fri, 27 Jul 2018 16:51:57 +0300

Subject: [Backport 4dc98c199548] scsi: 3ware: fix return 0 on the error path

 of probe

tw_probe() returns 0 in case of fail of tw_initialize_device_extension(),

pci_resource_start() or tw_reset_sequence() and releases resources.

twl_probe() returns 0 in case of fail of twl_initialize_device_extension(),

pci_iomap() and twl_reset_sequence().  twa_probe() returns 0 in case of

fail of tw_initialize_device_extension(), ioremap() and

twa_reset_sequence().

The patch adds retval initialization for these cases.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>

Acked-by: Adam Radford <aradford@gmail.com>

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

---

 src/3w-sas.c | 3 +++

 1 file changed, 3 insertions(+)

diff --git a/src/3w-sas.c b/src/3w-sas.c

index cf9f2a09b47d9e327457248e986adacf8e530949..40c1e6e64f58a8422e5738a3c6a12799142a6ff0 100644

--- a/src/3w-sas.c

+++ b/src/3w-sas.c

@@ -1594,6 +1594,7 @@ static int twl_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id)

 	if (twl_initialize_device_extension(tw_dev)) {

 		TW_PRINTK(tw_dev->host, TW_DRIVER, 0x1a, "Failed to initialize device extension");

+		retval = -ENOMEM;

 		goto out_free_device_extension;

 	}

@@ -1608,6 +1609,7 @@ static int twl_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id)

 	tw_dev->base_addr = pci_iomap(pdev, 1, 0);

 	if (!tw_dev->base_addr) {

 		TW_PRINTK(tw_dev->host, TW_DRIVER, 0x1c, "Failed to ioremap");

+		retval = -ENOMEM;

 		goto out_release_mem_region;

 	}

@@ -1617,6 +1619,7 @@ static int twl_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id)

 	/* Initialize the card */

 	if (twl_reset_sequence(tw_dev, 0)) {

 		TW_PRINTK(tw_dev->host, TW_DRIVER, 0x1d, "Controller reset failed during probe");

+		retval = -ENOMEM;

 		goto out_iounmap;

 	}

-- 

2.31.1