c931d1 kdump-lib.sh: Check the output of blkid with sed instead of eval

Authored and Committed by liutgnu 2 years ago
1 file changed. 2 lines added. 1 lines removed.
    kdump-lib.sh: Check the output of blkid with sed instead of eval
    
    upstream: fedora
    resolves: bz2096132
    conflict: none
    
    commit 2bbc7512a2f2cf953ea047f54bd590d4d285b658
    Author: Tao Liu <ltao@redhat.com>
    Date:   Wed Feb 16 14:26:38 2022 +0800
    
        kdump-lib.sh: Check the output of blkid with sed instead of eval
    
        Previously the output of blkid is not checked. If the output
        is empty, the eval will report the following error message:
    
            /lib/kdump/kdump-lib.sh: eval: line 925: syntax error near unexpected token `;'
            /lib/kdump/kdump-lib.sh: eval: line 925: `; echo $TYPE'
    
        For example, we can observe such a failing when blkid is invoked
        against a lvm thinpool block device:
    
            $ blkid -u filesystem,crypto -o export -- "/dev/block/253\:2"
            $ echo $?
            2
            $ udevadm info /dev/block/253\:2|grep S\:
            S: mapper/vg00-thinpoll_tmeta
    
        In this patch, we will use sed instead of eval, to output the
        fstype of block device if any.
    
        Signed-off-by: Tao Liu <ltao@redhat.com>
        Reviewed-by: Philipp Rudo <prudo@redhat.com>
    
    Signed-off-by: Tao Liu <ltao@redhat.com>
    
        
file modified
+2 -1