From c8faddc4f8a9b9f6e4c9c433495c431362011dad Mon Sep 17 00:00:00 2001 From: Tao Liu Date: Nov 03 2021 08:14:08 +0000 Subject: dracut-module-setup.sh: use "*" to expend array as string upstream: fedora resolves: bz2003832 conflict: none commit da3ad9cbdaa332ed9384799e4b3198b9e55c5cd3 Author: Kairui Song Date: Wed Aug 4 15:47:43 2021 +0800 dracut-module-setup.sh: use "*" to expend array as string As suggested by: https://github.com/koalaman/shellcheck/wiki/SC2199 The array is not quoted here but implicitly concatenate still happens, could be harmless but shellcheck complains about it so fix it. Signed-off-by: Kairui Song Acked-by: Philipp Rudo Signed-off-by: Tao Liu --- diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index 169dede..6af96fb 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -94,7 +94,7 @@ kdump_setup_dns() { _tmp=$(get_nmcli_value_by_field "$_nm_show_cmd" "IP4.DNS") array=(${_tmp//|/ }) - if [[ ${array[@]} ]]; then + if [[ ${array[*]} ]]; then for _dns in "${array[@]}" do echo "nameserver=$_dns" >> "$_dnsfile"