From 80a37c95eec84608818762290e94475d3b5eba8d Mon Sep 17 00:00:00 2001
From: Coiby Xu <coxu@redhat.com>
Date: Jan 26 2022 06:41:01 +0000
Subject: fix broken kdump_get_arch_recommend_size


Resolves: bz2045971
Upstream: Fedora
Conflict: None

commit 2df55984f66bc2a67c881eab0e33139d2ddc0461
Author: Coiby Xu <coxu@redhat.com>
Date:   Wed Jan 26 08:48:18 2022 +0800

    fix broken kdump_get_arch_recommend_size

    shellcheck finds the following problem,
    $ shellcheck kdump-lib.sh
    In kdump-lib.sh line 876:
            get_recommend_size "$sys_mem" "$ck_cmdline"
                                           ^---------^ SC2154: ck_cmdline is referenced but not assigned (did you mean '_ck_cmdline'?).

    s/ck_cmdline/_ck_cmdline to fix kdump_get_arch_recommend_size.

    Note s/sys_mem/_sys_mem as well to make the changes consistent.

    Fixes: 105c016 ("factor out kdump_get_arch_recommend_crashkernel")
    Signed-off-by: Coiby Xu <coxu@redhat.com>
    Acked-by: Tao Liu <ltao@redhat.com>

Signed-off-by: Coiby Xu <coxu@redhat.com>

---

diff --git a/kdump-lib.sh b/kdump-lib.sh
index c15e19a..325f445 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -868,16 +868,16 @@ kdump_get_arch_recommend_crashkernel()
 # $1: kernel version, if not set, will defaults to $(uname -r)
 kdump_get_arch_recommend_size()
 {
-	local _ck_cmdline
+	local _ck_cmdline _sys_mem
 
 	if ! [[ -r "/proc/iomem" ]]; then
 		echo "Error, can not access /proc/iomem."
 		return 1
 	fi
-	sys_mem=$(get_system_size)
+	_sys_mem=$(get_system_size)
 	_ck_cmdline=$(kdump_get_arch_recommend_crashkernel)
 	_ck_cmdline=${_ck_cmdline//-:/-102400T:}
-	get_recommend_size "$sys_mem" "$ck_cmdline"
+	get_recommend_size "$_sys_mem" "$_ck_cmdline"
 }
 
 # Print all underlying crypt devices of a block device