From 2f5889df5e8e728c540165860773109cbcd40c8d Mon Sep 17 00:00:00 2001 From: Philipp Rudo Date: Mar 13 2023 12:41:05 +0000 Subject: sysconfig: add zfcp.allow_lun_scan to KDUMP_COMMANDLINE_REMOVE on s390 Resolves: bz2177674 Upstream: Fedora Conflict: Move to kdump.sysconfig.s390 due to missing 677da8a ("sysconfig: use a simple generator script to maintain") Author: Philipp Rudo Date: Tue Mar 7 14:45:35 2023 +0100 sysconfig: add zfcp.allow_lun_scan to KDUMP_COMMANDLINE_REMOVE on s390 Probing unnecessary I/O devices wastes memory and in extreme cases can cause the crashkernel to run OOM. That's why the s390-tools maintain their own module, 95zdev-kdump [1], that disables auto LUN scanning and only configures zfcp devices that can be used as dump target. So remove zfcp.allow_lun_scan from the kernel command line to prevent that we accidentally overwrite the default set by the module. [1] https://github.com/ibm-s390-linux/s390-tools/blob/master/zdev/dracut/95zdev-kdump/module-setup.sh Signed-off-by: Philipp Rudo Reviewed-by: Coiby Xu Signed-off-by: Philipp Rudo --- diff --git a/kdump.sysconfig.s390x b/kdump.sysconfig.s390x index 2971ae7..b823093 100644 --- a/kdump.sysconfig.s390x +++ b/kdump.sysconfig.s390x @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE="" # This variable lets us remove arguments from the current kdump commandline # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline # NOTE: some arguments such as crashkernel will always be removed -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len swiotlb vmcp_cma cma hugetlb_cma prot_virt ignition.firstboot" +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len swiotlb vmcp_cma cma hugetlb_cma prot_virt ignition.firstboot zfcp.allow_lun_scan" # This variable lets us append arguments to the current kdump commandline # after processed by KDUMP_COMMANDLINE_REMOVE