|
 |
b6983f |
From 6c5646bec26fe86214a34a877b84da83f9d9cfb4 Mon Sep 17 00:00:00 2001
|
|
|
b6983f |
From: YAMAMOTO Masaya <pandax381@gmail.com>
|
|
|
b6983f |
Date: Tue, 4 Jul 2017 15:08:36 +0900
|
|
|
b6983f |
Subject: [PATCH 2/8] Migrate failed checkers at reload (provisional
|
|
|
b6983f |
implementation)
|
|
|
b6983f |
|
|
|
b6983f |
---
|
|
|
b6983f |
keepalived/check/ipwrapper.c | 36 +++++++++++++++++++++++++-----------
|
|
|
b6983f |
1 file changed, 25 insertions(+), 11 deletions(-)
|
|
|
b6983f |
|
|
|
b6983f |
diff --git a/keepalived/check/ipwrapper.c b/keepalived/check/ipwrapper.c
|
|
|
b6983f |
index ecf12713..6acf18ba 100644
|
|
|
b6983f |
--- a/keepalived/check/ipwrapper.c
|
|
|
b6983f |
+++ b/keepalived/check/ipwrapper.c
|
|
|
b6983f |
@@ -623,9 +623,28 @@ rs_exist(real_server_t * old_rs, list l)
|
|
|
b6983f |
return NULL;
|
|
|
b6983f |
}
|
|
|
b6983f |
|
|
|
b6983f |
+static void
|
|
|
b6983f |
+migrate_failed_checkers(real_server_t *old_rs, real_server_t *new_rs)
|
|
|
b6983f |
+{
|
|
|
b6983f |
+ element e;
|
|
|
b6983f |
+ checker_t *checker;
|
|
|
b6983f |
+ checker_id_t *id;
|
|
|
b6983f |
+
|
|
|
b6983f |
+ /* Notes: It's a provisional implementation */
|
|
|
b6983f |
+ (void)old_rs;
|
|
|
b6983f |
+ for (e = LIST_HEAD(checkers_queue); e; ELEMENT_NEXT(e)) {
|
|
|
b6983f |
+ checker = ELEMENT_DATA(e);
|
|
|
b6983f |
+ if (checker->rs == new_rs) {
|
|
|
b6983f |
+ id = (checker_id_t *) MALLOC(sizeof(checker_id_t));
|
|
|
b6983f |
+ *id = checker->id;
|
|
|
b6983f |
+ list_add(new_rs->failed_checkers, id);
|
|
|
b6983f |
+ }
|
|
|
b6983f |
+ }
|
|
|
b6983f |
+}
|
|
|
b6983f |
+
|
|
|
b6983f |
/* Clear the diff rs of the old vs */
|
|
|
b6983f |
static void
|
|
|
b6983f |
-clear_diff_rs(virtual_server_t * old_vs, list new_rs_list)
|
|
|
b6983f |
+clear_diff_rs(virtual_server_t *old_vs, virtual_server_t *new_vs)
|
|
|
b6983f |
{
|
|
|
b6983f |
element e;
|
|
|
b6983f |
list l = old_vs->rs;
|
|
|
b6983f |
@@ -639,7 +658,7 @@ clear_diff_rs(virtual_server_t * old_vs, list new_rs_list)
|
|
|
b6983f |
list rs_to_remove = alloc_list (NULL, NULL);
|
|
|
b6983f |
for (e = LIST_HEAD(l); e; ELEMENT_NEXT(e)) {
|
|
|
b6983f |
rs = ELEMENT_DATA(e);
|
|
|
b6983f |
- new_rs = rs_exist(rs, new_rs_list);
|
|
|
b6983f |
+ new_rs = rs_exist(rs, new_vs->rs);
|
|
|
b6983f |
if (!new_rs) {
|
|
|
b6983f |
/* Reset inhibit flag to delete inhibit entries */
|
|
|
b6983f |
log_message(LOG_INFO, "service %s no longer exist"
|
|
|
b6983f |
@@ -662,20 +681,15 @@ clear_diff_rs(virtual_server_t * old_vs, list new_rs_list)
|
|
|
b6983f |
free_list_elements(new_rs->failed_checkers);
|
|
|
b6983f |
} else {
|
|
|
b6983f |
/*
|
|
|
b6983f |
- * if not alive, we must copy the failed checker list
|
|
|
b6983f |
+ * if not alive, we must migrate the failed checker list
|
|
|
b6983f |
* If we do not, the new RS is in a state where it’s reported
|
|
|
b6983f |
* as down with no check failed. As a result, the server will never
|
|
|
b6983f |
* be put up back when it’s alive again in check_tcp.c#83 because
|
|
|
b6983f |
* of the check that put a rs up only if it was not previously up
|
|
|
b6983f |
* based on the failed_checkers list
|
|
|
b6983f |
*/
|
|
|
b6983f |
- element hc_e;
|
|
|
b6983f |
- list hc_l = rs->failed_checkers;
|
|
|
b6983f |
- list new_hc_l = new_rs->failed_checkers;
|
|
|
b6983f |
- for (hc_e = LIST_HEAD(hc_l); hc_e; ELEMENT_NEXT(hc_e)) {
|
|
|
b6983f |
- list_add(new_hc_l, ELEMENT_DATA(hc_e));
|
|
|
b6983f |
- ELEMENT_DATA(hc_e) = NULL;
|
|
|
b6983f |
- }
|
|
|
b6983f |
+ if (!new_vs->alpha)
|
|
|
b6983f |
+ migrate_failed_checkers(rs, new_rs);
|
|
|
b6983f |
}
|
|
|
b6983f |
}
|
|
|
b6983f |
}
|
|
|
b6983f |
@@ -748,7 +762,7 @@ clear_diff_services(void)
|
|
|
b6983f |
/* omega = false must not prevent the notifiers from being called,
|
|
|
b6983f |
because the VS still exists in new configuration */
|
|
|
b6983f |
vs->omega = true;
|
|
|
b6983f |
- clear_diff_rs(vs, new_vs->rs);
|
|
|
b6983f |
+ clear_diff_rs(vs, new_vs);
|
|
|
b6983f |
clear_diff_s_srv(vs, new_vs->s_svr);
|
|
|
b6983f |
}
|
|
|
b6983f |
}
|
|
|
b6983f |
--
|
|
|
b6983f |
2.20.1
|
|
|
b6983f |
|