|
 |
0951d4 |
From a8e371e54b009159e9e3a0d198bd5eb3ed68ac22 Mon Sep 17 00:00:00 2001
|
|
|
0951d4 |
From: Christina Fu <cfu@redhat.com>
|
|
|
0951d4 |
Date: Tue, 15 May 2018 14:58:07 -0700
|
|
|
0951d4 |
Subject: [PATCH] Ticket 3 JSS has wrong encoding for ecdsa with sha*
|
|
|
0951d4 |
AlgorithmIdentifier This ticket addresses the issue to meet RFC 5758 where
|
|
|
0951d4 |
param field must be omitted in the ECDSA Signature algorithm'
|
|
|
0951d4 |
AlgorithmIdentifier for ecdsa-withSHA224, ecdsa-with-SHA256,
|
|
|
0951d4 |
ecdsa-with-SHA384, or ecdsa-with-SHA512.
|
|
|
0951d4 |
|
|
|
0951d4 |
fixes https://pagure.io/jss/issue/3
|
|
|
0951d4 |
---
|
|
|
0951d4 |
.../jss/pkix/primitive/AlgorithmIdentifier.java | 29 +++++++++++++++++++---
|
|
|
0951d4 |
1 file changed, 25 insertions(+), 4 deletions(-)
|
|
|
0951d4 |
|
|
|
0951d4 |
diff --git a/org/mozilla/jss/pkix/primitive/AlgorithmIdentifier.java b/org/mozilla/jss/pkix/primitive/AlgorithmIdentifier.java
|
|
|
0951d4 |
index 76e4718..0662f76 100644
|
|
|
0951d4 |
--- a/org/mozilla/jss/pkix/primitive/AlgorithmIdentifier.java
|
|
|
0951d4 |
+++ b/org/mozilla/jss/pkix/primitive/AlgorithmIdentifier.java
|
|
|
0951d4 |
@@ -4,10 +4,12 @@
|
|
|
0951d4 |
package org.mozilla.jss.pkix.primitive;
|
|
|
0951d4 |
|
|
|
0951d4 |
import org.mozilla.jss.asn1.*;
|
|
|
0951d4 |
+import org.mozilla.jss.crypto.SignatureAlgorithm;
|
|
|
0951d4 |
import org.mozilla.jss.util.Assert;
|
|
|
0951d4 |
import java.io.InputStream;
|
|
|
0951d4 |
import java.io.OutputStream;
|
|
|
0951d4 |
import java.io.IOException;
|
|
|
0951d4 |
+import java.security.NoSuchAlgorithmException;
|
|
|
0951d4 |
|
|
|
0951d4 |
public class AlgorithmIdentifier implements ASN1Value {
|
|
|
0951d4 |
|
|
|
0951d4 |
@@ -100,10 +102,29 @@ public static class Template implements ASN1Template {
|
|
|
0951d4 |
// the template should have enforced this
|
|
|
0951d4 |
Assert._assert( seq.size() == 2 );
|
|
|
0951d4 |
|
|
|
0951d4 |
- return new AlgorithmIdentifier(
|
|
|
0951d4 |
- (OBJECT_IDENTIFIER)seq.elementAt(0), // OID
|
|
|
0951d4 |
- seq.elementAt(1) // parameters
|
|
|
0951d4 |
- );
|
|
|
0951d4 |
+ OBJECT_IDENTIFIER algOID = (OBJECT_IDENTIFIER)seq.elementAt(0);
|
|
|
0951d4 |
+ boolean allowParams = true;
|
|
|
0951d4 |
+ try {
|
|
|
0951d4 |
+ if (algOID.equals(SignatureAlgorithm.ECSignatureWithSHA256Digest.toOID()) ||
|
|
|
0951d4 |
+ algOID.equals(SignatureAlgorithm.ECSignatureWithSHA384Digest.toOID()) ||
|
|
|
0951d4 |
+ algOID.equals(SignatureAlgorithm.ECSignatureWithSHA512Digest.toOID())) {
|
|
|
0951d4 |
+ allowParams = false;
|
|
|
0951d4 |
+ }
|
|
|
0951d4 |
+ } catch (NoSuchAlgorithmException e) {
|
|
|
0951d4 |
+ // System.out.println("JSS: AlgorithmIdentifier:decode: " + e.toString());
|
|
|
0951d4 |
+ // unlikely to happen; swallow it. treat it as allowParams;
|
|
|
0951d4 |
+ }
|
|
|
0951d4 |
+
|
|
|
0951d4 |
+ if (!allowParams) {
|
|
|
0951d4 |
+ return new AlgorithmIdentifier(
|
|
|
0951d4 |
+ algOID // OID
|
|
|
0951d4 |
+ );
|
|
|
0951d4 |
+ } else {
|
|
|
0951d4 |
+ return new AlgorithmIdentifier(
|
|
|
0951d4 |
+ (OBJECT_IDENTIFIER)seq.elementAt(0), // OID
|
|
|
0951d4 |
+ seq.elementAt(1) // parameters
|
|
|
0951d4 |
+ );
|
|
|
0951d4 |
+ }
|
|
|
0951d4 |
}
|
|
|
0951d4 |
} // end of Template
|
|
|
0951d4 |
|
|
|
0951d4 |
--
|
|
|
0951d4 |
2.14.3
|
|
|
0951d4 |
|