Blame SOURCES/jss-eliminate-java-compiler-warnings.patch

b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/CryptoManager.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/CryptoManager.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/CryptoManager.java	2011-08-10 16:21:30.837765000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/CryptoManager.java	2011-08-12 13:13:34.449664000 -0700
b93447
@@ -1125,7 +1125,7 @@ public final class CryptoManager impleme
b93447
      * Imports a single certificate into the permanent certificate
b93447
      * database.
b93447
      *
b93447
-     * @param derCert the certificate you want to add
b93447
+     * @param cert the certificate you want to add
b93447
      * @param nickname the nickname you want to refer to the certificate as
b93447
      *        (must not be null)
b93447
      */
b93447
@@ -1391,11 +1391,11 @@ public final class CryptoManager impleme
b93447
     public static final String
b93447
     JAR_JDK_VERSION     = "JDK_VERSION = N/A";
b93447
     public static final String
b93447
-    JAR_NSS_VERSION     = "NSS_VERSION = NSS_3_11_9_RTM";
b93447
+    JAR_NSS_VERSION     = "NSS_VERSION = N/A";
b93447
     public static final String
b93447
     JAR_DBM_VERSION     = "DBM_VERSION = N/A";
b93447
     public static final String
b93447
-    JAR_NSPR_VERSION    = "NSPR_VERSION = NSPR_4_7_RTM";
b93447
+    JAR_NSPR_VERSION    = "NSPR_VERSION = N/A";
b93447
 
b93447
     /**
b93447
      * Loads the JSS dynamic library if necessary.
b93447
@@ -1433,8 +1433,8 @@ public final class CryptoManager impleme
b93447
      * this thread's token to <tt>null</tt> will also cause the
b93447
      * InternalKeyStorageToken to be used.
b93447
      *
b93447
-     * @param The token to use for crypto operations. Specifying <tt>null</tt>
b93447
-     * will cause the InternalKeyStorageToken to be used.
b93447
+     * @param token The token to use for crypto operations. Specifying
b93447
+     * <tt>null</tt> will cause the InternalKeyStorageToken to be used.
b93447
      */
b93447
     public void setThreadToken(CryptoToken token) {
b93447
         if( token != null ) {
b93447
@@ -1579,7 +1579,7 @@ public final class CryptoManager impleme
b93447
      * Verify a certificate in memory. Check if
b93447
      * valid and that we trust the issuer. Verify time
b93447
      * against Now.
b93447
-     * @param certificate in memory
b93447
+     * @param certPackage certificate in memory
b93447
      * @param checkSig verify the signature of the certificate
b93447
      * @param certUsage see exposed certUsage defines to verify Certificate
b93447
      * @return true for success; false otherwise
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/JSSProvider.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/JSSProvider.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/JSSProvider.java	2011-08-10 17:29:33.476661000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/JSSProvider.java	2011-08-12 11:00:26.456852000 -0700
b93447
@@ -51,7 +51,7 @@ public final class JSSProvider extends j
b93447
 
b93447
     private static int JSS_MAJOR_VERSION  = 4;
b93447
     private static int JSS_MINOR_VERSION  = 2;
b93447
-    private static int JSS_PATCH_VERSION  = 5;
b93447
+    private static int JSS_PATCH_VERSION  = 6;
b93447
     private static double JSS_VERSION     = JSS_MAJOR_VERSION +
b93447
                                            (JSS_MINOR_VERSION * 100 +
b93447
                                             JSS_PATCH_VERSION)/10000.0;
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/Cipher.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/Cipher.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/Cipher.java	2004-04-25 08:02:21.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/Cipher.java	2011-08-12 13:10:50.781827000 -0700
b93447
@@ -144,8 +144,8 @@ public abstract class Cipher {
b93447
      *  B is the block size, the padding string consists of
b93447
      *  B - (M mod B) octets, each having the value
b93447
      *  B - (M mod B).
b93447
-     * @param The block size of the encryption algorithm.  Must be greater
b93447
-     *  than zero.
b93447
+     * @param blockSize The block size of the encryption algorithm.
b93447
+     *  Must be greater than zero.
b93447
      * @see #unPad
b93447
      */
b93447
     public static byte[]
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/CryptoToken.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/CryptoToken.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/CryptoToken.java	2007-11-09 16:37:56.000000000 -0800
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/CryptoToken.java	2011-08-12 11:07:20.326438000 -0700
b93447
@@ -194,7 +194,7 @@ public interface CryptoToken {
b93447
      * Login to the token. If a token is logged in, it will not trigger
b93447
      * password callbacks.
b93447
      *
b93447
-     * @param password The password for this token.
b93447
+     * @param pwcb The password callback for this token.
b93447
      * @exception IncorrectPasswordException If the supplied password is
b93447
      *  incorrect.
b93447
      * @see #setLoginMode
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/JSSMessageDigest.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/JSSMessageDigest.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/JSSMessageDigest.java	2004-04-25 08:02:21.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/JSSMessageDigest.java	2011-08-12 11:08:37.747360000 -0700
b93447
@@ -88,7 +88,7 @@ public abstract class JSSMessageDigest {
b93447
      * Completes digestion.
b93447
      * 
b93447
      * @return The, ahem, output of the digest operation.
b93447
-     * @param If an error occurs while digesting.
b93447
+     * @exception DigestException If an error occurs while digesting.
b93447
      */
b93447
     public byte[] digest() throws DigestException {
b93447
         byte[] output = new byte[getOutputSize()];
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/PBEKeyGenParams.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/PBEKeyGenParams.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/PBEKeyGenParams.java	2004-04-25 08:02:21.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/crypto/PBEKeyGenParams.java	2011-08-12 11:09:41.345296000 -0700
b93447
@@ -60,7 +60,7 @@ public class PBEKeyGenParams implements 
b93447
      *      Must not be null. It is the responsibility of the caller to
b93447
      *      use the right salt length for the algorithm. Most algorithms
b93447
      *      use 8 bytes of salt.
b93447
-     * @param The iteration count for the PBE algorithm.
b93447
+     * @param iterations The iteration count for the PBE algorithm.
b93447
      */
b93447
     public PBEKeyGenParams(Password pass, byte[] salt, int iterations) {
b93447
         if(pass==null || salt==null) {
b93447
@@ -80,7 +80,7 @@ public class PBEKeyGenParams implements 
b93447
      *      Must not be null. It is the responsibility of the caller to
b93447
      *      use the right salt length for the algorithm. Most algorithms
b93447
      *      use 8 bytes of salt.
b93447
-     * @param The iteration count for the PBE algorithm.
b93447
+     * @param iterations The iteration count for the PBE algorithm.
b93447
      */
b93447
     public PBEKeyGenParams(char[] pass, byte[] salt, int iterations) {
b93447
         if(pass==null || salt==null) {
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11Token.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11Token.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11Token.java	2007-11-09 16:37:57.000000000 -0800
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11Token.java	2011-08-12 11:13:51.807047000 -0700
b93447
@@ -228,8 +228,8 @@ public final class PK11Token implements 
b93447
      * Initialize PIN.  This sets the user's new PIN, using the current
b93447
      * security officer PIN for authentication.
b93447
      *
b93447
-     * @param ssopw The security officer's current password.
b93447
-     * @param userpw The user's new password.
b93447
+     * @param ssopwcb The security officer's current password callback.
b93447
+     * @param userpwcb The user's new password callback.
b93447
      * @exception IncorrectPinException If the security officer PIN is
b93447
      *  incorrect.
b93447
      * @exception TokenException If the PIN was already initialized,
b93447
@@ -322,8 +322,8 @@ public final class PK11Token implements 
b93447
      * Change password.  This changes the user's PIN after it has already
b93447
      * been initialized.
b93447
      *
b93447
-     * @param oldPIN The user's old PIN.
b93447
-     * @param newPIN The new PIN.
b93447
+     * @param oldPINcb The user's old PIN callback.
b93447
+     * @param newPINcb The new PIN callback.
b93447
      * @exception IncorrectPasswordException If the old PIN is incorrect.
b93447
      * @exception TokenException If some other error occurs on the token.
b93447
      *
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java	2005-09-22 10:58:35.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java	2011-08-12 11:14:44.011995000 -0700
b93447
@@ -288,7 +288,7 @@ public final class SafeBag implements AS
b93447
      *      as the nickname of the associated cert.
b93447
      * @param localKeyID The localKeyID for the key; should be the same as
b93447
      *      the localKeyID of the associated cert.
b93447
-     * @param The password used to encrypt the private key.
b93447
+     * @param password The password used to encrypt the private key.
b93447
      */
b93447
     public static SafeBag
b93447
     createEncryptedPrivateKeyBag(PrivateKeyInfo privk, String friendlyName,
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs7/SignerInfo.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs7/SignerInfo.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs7/SignerInfo.java	2004-04-25 08:02:23.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkcs7/SignerInfo.java	2011-08-12 11:12:13.957145000 -0700
b93447
@@ -430,7 +430,6 @@ public class SignerInfo implements ASN1V
b93447
      *  SignerInfo.
b93447
      * @param contentType The type of the content that is signed by this
b93447
      *  SignerInfo.
b93447
-     * @param pubkey The public key to use to verify the signature.
b93447
      * @exception NoSuchObjectException If no certificate matching the
b93447
      *      the issuer name and serial number can be found.
b93447
      */
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmc/CMCStatusInfo.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmc/CMCStatusInfo.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmc/CMCStatusInfo.java	2004-11-18 14:56:11.000000000 -0800
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmc/CMCStatusInfo.java	2011-08-12 11:20:39.240639000 -0700
b93447
@@ -108,7 +108,7 @@ public class CMCStatusInfo implements AS
b93447
      * @param status A CMCStatus constant.
b93447
      * @param bodyList The sequence of bodyPartID.
b93447
      * @param statusString A String.
b93447
-     * @param OtherInfo The OtherInfo choice.
b93447
+     * @param otherInfo The OtherInfo choice.
b93447
      */
b93447
     public CMCStatusInfo(int status, SEQUENCE bodyList, String
b93447
 						 statusString, OtherInfo otherInfo) {
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmmf/PKIStatusInfo.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmmf/PKIStatusInfo.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmmf/PKIStatusInfo.java	2006-05-23 20:18:17.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/cmmf/PKIStatusInfo.java	2011-08-12 11:21:27.389591000 -0700
b93447
@@ -88,7 +88,6 @@ public class PKIStatusInfo implements AS
b93447
     /**
b93447
      * Create a PKIStatusInfo with no failure info.
b93447
      * @param status A PKIStatus constant.
b93447
-     * @param failInfo The bitwise AND of the PKIFailureInfo constants.
b93447
      */
b93447
     public PKIStatusInfo(int status) {
b93447
         this.status = new INTEGER(status);
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/primitive/DirectoryString.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/primitive/DirectoryString.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/primitive/DirectoryString.java	2004-04-25 08:02:26.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/pkix/primitive/DirectoryString.java	2011-08-12 11:20:11.194667000 -0700
b93447
@@ -115,10 +115,6 @@ public class DirectoryString implements 
b93447
 
b93447
     /**
b93447
      * Converts an ASN.1 DirectoryString to a Java string.
b93447
-     *
b93447
-     * @param dirstr An ANY containing a BER-encoded DirectoryString.
b93447
-     * @exception InvalidBERException If the encoding does not contain a
b93447
-     *      valid DirectoryString.
b93447
      */
b93447
     public String toString() {
b93447
         return asn1String.toString();
b93447
@@ -176,6 +172,8 @@ public class DirectoryString implements 
b93447
         /**
b93447
          * @param implicitTag This paramter is ignored, because
b93447
          *      DirectoryStrings (being CHOICEs) cannot have implicit tags.
b93447
+         * @exception InvalidBERException If the encoding does not contain a
b93447
+         *      valid DirectoryString.
b93447
          */
b93447
         public ASN1Value decode(Tag implicitTag, InputStream istream)
b93447
             throws IOException, InvalidBERException
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/provider/javax/crypto/JSSSecretKeyFactorySpi.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/provider/javax/crypto/JSSSecretKeyFactorySpi.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/provider/javax/crypto/JSSSecretKeyFactorySpi.java	2003-04-28 14:48:33.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/provider/javax/crypto/JSSSecretKeyFactorySpi.java	2011-08-12 10:58:39.589958000 -0700
b93447
@@ -91,14 +91,18 @@ class JSSSecretKeyFactorySpi extends Sec
b93447
         // versions is to use the reflection API.
b93447
         Class specClass = spec.getClass();
b93447
         try {
b93447
-            Method getSaltMethod = specClass.getMethod("getSalt", null);
b93447
+            Method getSaltMethod = specClass.getMethod("getSalt",
b93447
+                                       (java.lang.Class) null);
b93447
             Method getIterationMethod =
b93447
-                specClass.getMethod("getIterationCount", null);
b93447
+                specClass.getMethod("getIterationCount",
b93447
+                                    (java.lang.Class) null);
b93447
 
b93447
-            byte[] salt = (byte[]) getSaltMethod.invoke(spec, null);
b93447
+            byte[] salt = (byte[]) getSaltMethod.invoke(spec,
b93447
+                                       (java.lang.Class) null);
b93447
             
b93447
             Integer itCountObj =
b93447
-                (Integer) getIterationMethod.invoke(spec,null);
b93447
+                (Integer) getIterationMethod.invoke(spec,
b93447
+                                                    (java.lang.Class) null);
b93447
             int iterationCount = itCountObj.intValue();
b93447
 
b93447
             Password pass = new Password(spec.getPassword());
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/ssl/SSLSocket.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/ssl/SSLSocket.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/ssl/SSLSocket.java	2011-08-10 16:21:30.412765000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/ssl/SSLSocket.java	2011-08-12 11:47:38.385021000 -0700
b93447
@@ -182,11 +182,11 @@ public class SSLSocket extends java.net.
b93447
     }
b93447
 
b93447
     /**
b93447
-     * Creates an SSL client socket and connects to the specified host and
b93447
+     * Creates an SSL client socket and connects to the specified address and
b93447
      *  port. Binds to the given local address and port. Installs the given
b93447
      *  callbacks for certificate approval and client certificate selection.
b93447
      *
b93447
-     * @param host The hostname to connect to.
b93447
+     * @param address The IP address to connect to.
b93447
      * @param port The port to connect to.
b93447
      * @param localAddr The local address to bind to. It can be null, in which
b93447
      *      case an unspecified local address will be chosen.
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/HMACTest.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/HMACTest.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/HMACTest.java	2006-02-23 08:47:17.000000000 -0800
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/HMACTest.java	2011-08-12 13:11:11.790805000 -0700
b93447
@@ -96,7 +96,7 @@ public class HMACTest {
b93447
 
b93447
     /**
b93447
      * Main test method.
b93447
-     * @params args[]
b93447
+     * @param argv
b93447
      */
b93447
     public static void main(String []argv) {
b93447
 
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JCASymKeyGen.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JCASymKeyGen.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JCASymKeyGen.java	2011-08-10 16:21:30.337766000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JCASymKeyGen.java	2011-08-12 11:53:56.192644000 -0700
b93447
@@ -116,9 +116,9 @@ public class JCASymKeyGen {
b93447
     }
b93447
     /**
b93447
      * 
b93447
-     * @param key
b93447
-     * @param kg
b93447
-     * @return
b93447
+     * @param keyType
b93447
+     * @param provider
b93447
+     * @return javax.crypto.SecretKey key
b93447
      */
b93447
     public javax.crypto.SecretKey genSecretKey(String keyType, String provider){
b93447
         javax.crypto.SecretKey key = null;
b93447
@@ -155,7 +155,7 @@ public class JCASymKeyGen {
b93447
      * 
b93447
      * @param keyType 
b93447
      * @param provider 
b93447
-     * @return 
b93447
+     * @return javax.crypto.SecretKey key
b93447
      */
b93447
     public javax.crypto.SecretKey genPBESecretKey(String keyType,
b93447
             String provider){
b93447
@@ -197,8 +197,10 @@ public class JCASymKeyGen {
b93447
     /**
b93447
      *
b93447
      * @param sKey
b93447
-     * @param AlgType
b93447
-     * @param provider
b93447
+     * @param algFamily
b93447
+     * @param algType
b93447
+     * @param providerForEncrypt
b93447
+     * @param providerForDecrypt
b93447
      */
b93447
     public void testCipher(javax.crypto.SecretKey sKey, String algFamily,
b93447
             String algType, String providerForEncrypt, String providerForDecrypt)
b93447
@@ -304,8 +306,10 @@ public class JCASymKeyGen {
b93447
     /**
b93447
      *
b93447
      * @param sKey
b93447
-     * @param AlgType
b93447
-     * @param provider
b93447
+     * @param algFamily
b93447
+     * @param algType
b93447
+     * @param providerForEncrypt
b93447
+     * @param providerForDecrypt
b93447
      */
b93447
     public void testMultiPartCipher(javax.crypto.SecretKey sKey, String algFamily,
b93447
             String algType, String providerForEncrypt, String providerForDecrypt)
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLClient.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLClient.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLClient.java	2007-11-15 13:30:19.000000000 -0800
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLClient.java	2011-08-12 12:56:15.480701000 -0700
b93447
@@ -78,7 +78,7 @@ public class JSSE_SSLClient {
b93447
     
b93447
     /**
b93447
      * Set the protocol type and revision
b93447
-     * @param String sslRevision
b93447
+     * @param fSslRevision
b93447
      */
b93447
     public void setSslRevision(String fSslRevision) {
b93447
         
b93447
@@ -91,7 +91,7 @@ public class JSSE_SSLClient {
b93447
     
b93447
     /**
b93447
      * Set the host name to connect to.
b93447
-     * @param String hostname
b93447
+     * @param fHost
b93447
      */
b93447
     public void setHost(String fHost) {
b93447
         this.host = fHost;
b93447
@@ -99,7 +99,7 @@ public class JSSE_SSLClient {
b93447
     
b93447
     /**
b93447
      * Set the port number to connect to.
b93447
-     * @param int portnumber
b93447
+     * @param fPort
b93447
      */
b93447
     public void setPort(int fPort) {
b93447
         this.port = fPort;
b93447
@@ -107,7 +107,7 @@ public class JSSE_SSLClient {
b93447
     
b93447
     /**
b93447
      * Set the cipher suite name to use.
b93447
-     * @param String cipherSuiteName
b93447
+     * @param fCipherSuite
b93447
      */
b93447
     public void setCipherSuite(String fCipherSuite) {
b93447
         this.cipherName = fCipherSuite;
b93447
@@ -115,7 +115,7 @@ public class JSSE_SSLClient {
b93447
     
b93447
     /**
b93447
      * Set the location of rsa.pfx
b93447
-     * @param String fKeystoreLoc
b93447
+     * @param fKeystoreLoc
b93447
      */
b93447
     public void setKeystoreLoc(String fKeystoreLoc) {
b93447
         keystoreLoc = fKeystoreLoc + "/" + keystoreLoc;
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLServer.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLServer.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLServer.java	2007-11-15 13:30:19.000000000 -0800
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLServer.java	2011-08-12 12:57:18.987637000 -0700
b93447
@@ -75,7 +75,7 @@ public class JSSE_SSLServer {
b93447
     
b93447
        /**
b93447
      * Set the provider to use.
b93447
-     * @param String p
b93447
+     * @param p
b93447
      */
b93447
     public void setProvider(String p) {
b93447
         provider = p;
b93447
@@ -90,7 +90,7 @@ public class JSSE_SSLServer {
b93447
     }
b93447
     /**
b93447
      * Set the location of keystore file.
b93447
-     * @param String fconfigDir
b93447
+     * @param fconfigDir
b93447
      */
b93447
     public void setKeystore(String fconfigDir) {
b93447
         configDir = fconfigDir;
b93447
@@ -117,7 +117,7 @@ public class JSSE_SSLServer {
b93447
     
b93447
     /**
b93447
      * Start SSLServer and accept connections.
b93447
-     * @param args[]
b93447
+     * @param args
b93447
      */
b93447
     public void startSSLServer(String[] args) throws Exception {
b93447
         String configDir = "";
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_FileUploadClient.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_FileUploadClient.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_FileUploadClient.java	2005-08-11 11:28:59.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_FileUploadClient.java	2011-08-12 12:50:45.946239000 -0700
b93447
@@ -79,7 +79,7 @@ public class JSS_FileUploadClient {
b93447
     /**
b93447
      * Initialize the desired cipher to be set
b93447
      * on the socket.
b93447
-     * @param int Cipher
b93447
+     * @param aCipher
b93447
      */
b93447
     public void setCipher(int aCipher) {
b93447
         fCipher = aCipher;
b93447
@@ -87,7 +87,7 @@ public class JSS_FileUploadClient {
b93447
     
b93447
     /**
b93447
      * Initialize the hostname to run the server
b93447
-     * @param String ServerName
b93447
+     * @param aHostName
b93447
      */
b93447
     public void setHostName(String aHostName) {
b93447
         serverHost = aHostName;
b93447
@@ -95,7 +95,7 @@ public class JSS_FileUploadClient {
b93447
     
b93447
     /**
b93447
      * Initialize the port to run the server
b93447
-     * @param int port
b93447
+     * @param aPort
b93447
      */
b93447
     public void setPort(int aPort) {
b93447
         port = aPort;
b93447
@@ -103,7 +103,7 @@ public class JSS_FileUploadClient {
b93447
     
b93447
     /**
b93447
      * Initialize the passwords file name
b93447
-     * @param String passwords
b93447
+     * @param aPasswordFile
b93447
      */
b93447
     public void setPasswordFile(String aPasswordFile) {
b93447
         fPasswordFile = aPasswordFile;
b93447
@@ -111,7 +111,7 @@ public class JSS_FileUploadClient {
b93447
     
b93447
     /**
b93447
      * Initialize the cert db path name
b93447
-     * @param String CertDbPath
b93447
+     * @param aCertDbPath
b93447
      */
b93447
     public void setCertDbPath(String aCertDbPath) {
b93447
         fCertDbPath = aCertDbPath;
b93447
@@ -120,7 +120,7 @@ public class JSS_FileUploadClient {
b93447
     /**
b93447
      * Initialize the name of the file to
b93447
      * be used for testing along with full path.
b93447
-     * @param String UploadFile
b93447
+     * @param aUploadFile
b93447
      */
b93447
     public void setUploadFile(String aUploadFile) {
b93447
         fUploadFile = aUploadFile;
b93447
@@ -128,7 +128,7 @@ public class JSS_FileUploadClient {
b93447
     
b93447
     /**
b93447
      * Enable/disable Test Cert Callback.
b93447
-     * @param boolean
b93447
+     * @param aTestCertCallback
b93447
      */
b93447
     public void setTestCertCallback(boolean aTestCertCallback) {
b93447
         TestCertCallBack = aTestCertCallback;
b93447
@@ -136,7 +136,7 @@ public class JSS_FileUploadClient {
b93447
     
b93447
     /**
b93447
      * Set client certificate
b93447
-     * @param String Certificate Nick Name
b93447
+     * @param aClientCertNick Certificate Nick Name
b93447
      */
b93447
     public void setClientCertNick(String aClientCertNick) {
b93447
         clientCertNick = aClientCertNick;
b93447
@@ -170,7 +170,7 @@ public class JSS_FileUploadClient {
b93447
     
b93447
     /**
b93447
      * Set EOF for closinng server socket
b93447
-     * @param null for closing server socket
b93447
+     * @param fEof null for closing server socket
b93447
      */
b93447
     public void setEOF(String fEof) {
b93447
         this.EOF = fEof;
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SSLClient.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SSLClient.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SSLClient.java	2007-08-20 17:07:58.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SSLClient.java	2011-08-12 12:54:46.978789000 -0700
b93447
@@ -99,7 +99,7 @@ public class JSS_SSLClient {
b93447
     /**
b93447
      * Initialize the desired cipher to be set
b93447
      * on the socket.
b93447
-     * @param int Cipher
b93447
+     * @param aCipher
b93447
      */
b93447
     public void setCipher(int aCipher) {
b93447
         fCipher = aCipher;
b93447
@@ -107,7 +107,7 @@ public class JSS_SSLClient {
b93447
     
b93447
     /**
b93447
      * Initialize the hostname to run the server
b93447
-     * @param String ServerName
b93447
+     * @param aHostName
b93447
      */
b93447
     public void setHostName(String aHostName) {
b93447
         serverHost = aHostName;
b93447
@@ -115,7 +115,7 @@ public class JSS_SSLClient {
b93447
     
b93447
     /**
b93447
      * Initialize the port to run the server
b93447
-     * @param int port
b93447
+     * @param aPort
b93447
      */
b93447
     public void setPort(int aPort) {
b93447
         port = aPort;
b93447
@@ -123,7 +123,7 @@ public class JSS_SSLClient {
b93447
     
b93447
     /**
b93447
      * Initialize the passwords file name
b93447
-     * @param String passwords
b93447
+     * @param aPasswordFile
b93447
      */
b93447
     public void setPasswordFile(String aPasswordFile) {
b93447
         fPasswordFile = aPasswordFile;
b93447
@@ -131,7 +131,7 @@ public class JSS_SSLClient {
b93447
     
b93447
     /**
b93447
      * Initialize the cert db path name
b93447
-     * @param String CertDbPath
b93447
+     * @param aCertDbPath
b93447
      */
b93447
     public static void setCertDbPath(String aCertDbPath) {
b93447
         fCertDbPath = aCertDbPath;
b93447
@@ -147,7 +147,7 @@ public class JSS_SSLClient {
b93447
     
b93447
     /**
b93447
      * Enable/disable Test Cert Callback.
b93447
-     * @param boolean
b93447
+     * @param bypass
b93447
      */
b93447
     public void setBypass(boolean bypass) {
b93447
         testBypass = bypass;
b93447
@@ -155,7 +155,7 @@ public class JSS_SSLClient {
b93447
 
b93447
     /**
b93447
      * Enable/disable Test Cert Callback.
b93447
-     * @param boolean
b93447
+     * @param aTestCertCallback
b93447
      */
b93447
     public void setTestCertCallback(boolean aTestCertCallback) {
b93447
         TestCertCallBack = aTestCertCallback;
b93447
@@ -163,7 +163,7 @@ public class JSS_SSLClient {
b93447
     
b93447
     /**
b93447
      * Set client certificate
b93447
-     * @param String Certificate Nick Name
b93447
+     * @param aClientCertNick Certificate Nick Name
b93447
      */
b93447
     public void setClientCertNick(String aClientCertNick) {
b93447
         clientCertNick = aClientCertNick;
b93447
@@ -197,7 +197,7 @@ public class JSS_SSLClient {
b93447
     
b93447
     /**
b93447
      * Set EOF for closinng server socket
b93447
-     * @param null for closing server socket
b93447
+     * @param fEof null for closing server socket
b93447
      */
b93447
     public void setEOF(String fEof) {
b93447
         this.EOF = fEof;
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SelfServClient.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SelfServClient.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SelfServClient.java	2007-11-15 13:30:19.000000000 -0800
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/JSS_SelfServClient.java	2011-08-12 12:52:43.644913000 -0700
b93447
@@ -326,7 +326,7 @@ public class JSS_SelfServClient implemen
b93447
     /**
b93447
      * Initialize the desired ciphersuite to be set
b93447
      * on the socket.
b93447
-     * @param int Cipher
b93447
+     * @param aCipher
b93447
      */
b93447
     public void setCipher(int aCipher) {
b93447
         
b93447
@@ -378,7 +378,7 @@ public class JSS_SelfServClient implemen
b93447
     
b93447
     /**
b93447
      * Initialize the hostname to run the server
b93447
-     * @param String ServerName
b93447
+     * @param aHostName
b93447
      */
b93447
     public void setHostName(String aHostName) {
b93447
         serverHost = aHostName;
b93447
@@ -386,7 +386,7 @@ public class JSS_SelfServClient implemen
b93447
     
b93447
     /**
b93447
      * Initialize the port to run the server
b93447
-     * @param int port
b93447
+     * @param aPort
b93447
      */
b93447
     public void setPort(int aPort) {
b93447
         port = aPort;
b93447
@@ -394,7 +394,7 @@ public class JSS_SelfServClient implemen
b93447
     
b93447
     /**
b93447
      * Initialize the passwords file name
b93447
-     * @param String passwords
b93447
+     * @param aPasswordFile
b93447
      */
b93447
     public void setPasswordFile(String aPasswordFile) {
b93447
         fPasswordFile = aPasswordFile;
b93447
@@ -402,7 +402,7 @@ public class JSS_SelfServClient implemen
b93447
     
b93447
     /**
b93447
      * Initialize the cert db path name
b93447
-     * @param String CertDbPath
b93447
+     * @param aCertDbPath
b93447
      */
b93447
     public void setCertDbPath(String aCertDbPath) {
b93447
         fCertDbPath = aCertDbPath;
b93447
@@ -410,7 +410,7 @@ public class JSS_SelfServClient implemen
b93447
     
b93447
     /**
b93447
      * Enable/disable Test Cert Callback.
b93447
-     * @param boolean
b93447
+     * @param aTestCertCallback
b93447
      */
b93447
     public void setTestCertCallback(boolean aTestCertCallback) {
b93447
         TestCertCallBack = aTestCertCallback;
b93447
@@ -418,7 +418,7 @@ public class JSS_SelfServClient implemen
b93447
     
b93447
     /**
b93447
      * Set client certificate
b93447
-     * @param String Certificate Nick Name
b93447
+     * @param aClientCertNick Certificate Nick Name
b93447
      */
b93447
     public void setClientCertNick(String aClientCertNick) {
b93447
         clientCertNick = aClientCertNick;
b93447
diff -rupN alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/SSLClientAuth.java java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/SSLClientAuth.java
b93447
--- alt-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/SSLClientAuth.java	2007-08-23 16:21:13.000000000 -0700
b93447
+++ java-jss-4.2.6/mozilla/security/jss/org/mozilla/jss/tests/SSLClientAuth.java	2011-08-12 12:58:27.925569000 -0700
b93447
@@ -78,7 +78,7 @@ public class SSLClientAuth implements Ru
b93447
      * @param rand
b93447
      * @param extensions
b93447
      * @throws java.lang.Exception
b93447
-     * @return
b93447
+     * @return Certificate
b93447
      */
b93447
     public static Certificate makeCert(String issuerName, String subjectName,
b93447
             int serialNumber, PrivateKey privKey, PublicKey pubKey, int rand,