From 812d5e3903c5507c9d015cf0078b3a63d391b022 Mon Sep 17 00:00:00 2001

From: Eric Haszlakiewicz <erh+git@nimenees.com>

Date: Tue, 21 Apr 2020 03:19:17 +0000

Subject: [PATCH 01/18] Issue #471: always create directories with mode 0755,

 regardless of umask.

---

 CMakeLists.txt | 11 +++++++++++

 1 file changed, 11 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt

index c51f477c5f..ea536947df 100644

--- a/CMakeLists.txt

+++ b/CMakeLists.txt

@@ -392,6 +392,17 @@ target_include_directories(${PROJECT_NAME}

         $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}>

 )

+# Always create new install dirs with 0755 permissions, regardless of umask

+set(CMAKE_INSTALL_DEFAULT_DIRECTORY_PERMISSIONS

+	OWNER_READ

+	OWNER_WRITE

+	OWNER_EXECUTE

+	GROUP_READ

+	GROUP_EXECUTE

+	WORLD_READ

+	WORLD_EXECUTE

+   )

+

 install(TARGETS ${PROJECT_NAME}

     EXPORT ${PROJECT_NAME}-targets

     RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}

From 3a3ab6c7d8991892a44267919204f852dbd512ed Mon Sep 17 00:00:00 2001

From: Eric Haszlakiewicz <erh+git@nimenees.com>

Date: Sun, 3 May 2020 03:50:16 +0000

Subject: [PATCH 02/18] Fix cmake-configure to accept "--prefix=<foo>" in

 addition to "--prefix <foo>" (see also Issue #591)

---

 cmake-configure | 3 +++

 1 file changed, 3 insertions(+)

diff --git a/cmake-configure b/cmake-configure

index 7a06b660c1..2fcc39e3ca 100755

--- a/cmake-configure

+++ b/cmake-configure

@@ -52,6 +52,9 @@ while [ $# -gt 0 ] ; do

 		FLAGS+=(-DCMAKE_INSTALL_PREFIX="$2")

 		shift

 		;;

+	--prefix=*)

+		FLAGS+=(-DCMAKE_INSTALL_PREFIX="${1##--prefix=}")

+		;;

 	--enable-threading)

 		FLAGS+=(-DENABLE_THREADING=ON)

 		;;

From 0ca0361a24cd9f76b9bcb92eba2a752ff5269cea Mon Sep 17 00:00:00 2001

From: Tudor Brindus <me@tbrindus.ca>

Date: Fri, 1 May 2020 22:24:20 -0400

Subject: [PATCH 03/18] Fix segmentation fault in CPUID check

---

 random_seed.c | 15 ++-------------

 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/random_seed.c b/random_seed.c

index fc19e26d13..c459f0f92f 100644

--- a/random_seed.c

+++ b/random_seed.c

@@ -26,19 +26,8 @@

 static void do_cpuid(int regs[], int h)

 {

 	/* clang-format off */

-    __asm__ __volatile__(

-#if defined __x86_64__

-                         "pushq %%rbx;\n"

-#else

-                         "pushl %%ebx;\n"

-#endif

-                         "cpuid;\n"

-#if defined __x86_64__

-                         "popq %%rbx;\n"

-#else

-                         "popl %%ebx;\n"

-#endif

-                         : "=a"(regs[0]), [ebx] "=r"(regs[1]), "=c"(regs[2]), "=d"(regs[3])

+    __asm__ __volatile__("cpuid"

+                         : "=a"(regs[0]), "=b"(regs[1]), "=c"(regs[2]), "=d"(regs[3])

                          : "a"(h));

 	/* clang-format on */

 }

From 23005a7d9d7e9a1c433689b5df29a53bf629b470 Mon Sep 17 00:00:00 2001

From: Tudor Brindus <me@tbrindus.ca>

Date: Fri, 1 May 2020 21:09:22 -0400

Subject: [PATCH 04/18] Detect broken RDRAND during initialization

Some CPUs advertise RDRAND in CPUID, but return 0xFFFFFFFF

unconditionally. To avoid locking up later, test RDRAND during

initialization, and if it returns 0xFFFFFFFF, mark it as nonexistent.

Fixes #588.

---

 random_seed.c | 37 +++++++++++++++++++++++++++++++++----

 1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/random_seed.c b/random_seed.c

index c459f0f92f..4ddcb07d16 100644

--- a/random_seed.c

+++ b/random_seed.c

@@ -43,12 +43,41 @@ static void do_cpuid(int regs[], int h)

 #if HAS_X86_CPUID

+static int get_rdrand_seed(void);

+

+// Valid values are -1 (haven't tested), 0 (no), and 1 (yes).

+static int _has_rdrand = -1;

+

 static int has_rdrand(void)

 {

-	// CPUID.01H:ECX.RDRAND[bit 30] == 1

-	int regs[4];

-	do_cpuid(regs, 1);

-	return (regs[2] & (1 << 30)) != 0;

+	if (_has_rdrand == -1)

+	{

+		// CPUID.01H:ECX.RDRAND[bit 30] == 1

+		int regs[4];

+		do_cpuid(regs, 1);

+		if (!(regs[2] & (1 << 30)))

+		{

+			_has_rdrand = 0;

+		} else

+		{

+			// Some CPUs advertise RDRAND in CPUID, but return 0xFFFFFFFF

+			// unconditionally. To avoid locking up later, test RDRAND here. If over

+			// 10 trials RDRAND has returned the same value, declare it broken.

+			_has_rdrand = 0;

+			int prev = get_rdrand_seed();

+			for (int i = 0; i < 10; i++) {

+				int temp = get_rdrand_seed();

+				if (temp != prev) {

+					_has_rdrand = 1;

+					break;

+				}

+

+				prev = temp;

+			}

+		}

+	}

+

+	return _has_rdrand;

 }

 #endif

From 8d28e677e6a0919dcea40ea9a5b5d484df1d7d41 Mon Sep 17 00:00:00 2001

From: Eric Haszlakiewicz <erh+git@nimenees.com>

Date: Mon, 4 May 2020 01:29:02 +0000

Subject: [PATCH 05/18] Issue #589: drop the rdrand test loops to just 3, tweak

 comments and add some links to bug reports, and decrease the nesting level of

 the has_rdrand() function.

---

 random_seed.c | 64 +++++++++++++++++++++++++++++++--------------------

 1 file changed, 39 insertions(+), 25 deletions(-)

diff --git a/random_seed.c b/random_seed.c

index 4ddcb07d16..b5f8a0795e 100644

--- a/random_seed.c

+++ b/random_seed.c

@@ -45,36 +45,46 @@ static void do_cpuid(int regs[], int h)

 static int get_rdrand_seed(void);

-// Valid values are -1 (haven't tested), 0 (no), and 1 (yes).

+/* Valid values are -1 (haven't tested), 0 (no), and 1 (yes). */

 static int _has_rdrand = -1;

 static int has_rdrand(void)

 {

-	if (_has_rdrand == -1)

+	if (_has_rdrand != -1)

 	{

-		// CPUID.01H:ECX.RDRAND[bit 30] == 1

-		int regs[4];

-		do_cpuid(regs, 1);

-		if (!(regs[2] & (1 << 30)))

-		{

-			_has_rdrand = 0;

-		} else

+		return _has_rdrand;

+	}

+

+	/* CPUID.01H:ECX.RDRAND[bit 30] == 1 */

+	int regs[4];

+	do_cpuid(regs, 1);

+	if (!(regs[2] & (1 << 30)))

+	{

+		_has_rdrand = 0;

+		return 0;

+	}

+

+	/*

+	 * Some CPUs advertise RDRAND in CPUID, but return 0xFFFFFFFF

+	 * unconditionally. To avoid locking up later, test RDRAND here. If over

+	 * 3 trials RDRAND has returned the same value, declare it broken.

+	 * Example CPUs are AMD Ryzen 3000 series

+	 * and much older AMD APUs, such as the E1-1500

+	 * https://github.com/systemd/systemd/issues/11810

+	 * https://linuxreviews.org/RDRAND_stops_returning_random_values_on_older_AMD_CPUs_after_suspend

+	 */

+	_has_rdrand = 0;

+	int prev = get_rdrand_seed();

+	for (int i = 0; i < 3; i++)

+	{

+		int temp = get_rdrand_seed();

+		if (temp != prev)

 		{

-			// Some CPUs advertise RDRAND in CPUID, but return 0xFFFFFFFF

-			// unconditionally. To avoid locking up later, test RDRAND here. If over

-			// 10 trials RDRAND has returned the same value, declare it broken.

-			_has_rdrand = 0;

-			int prev = get_rdrand_seed();

-			for (int i = 0; i < 10; i++) {

-				int temp = get_rdrand_seed();

-				if (temp != prev) {

-					_has_rdrand = 1;

-					break;

-				}

-

-				prev = temp;

-			}

+			_has_rdrand = 1;

+			break;

 		}

+

+		prev = temp;

 	}

 	return _has_rdrand;

@@ -92,7 +102,7 @@ static int get_rdrand_seed(void)

 {

 	DEBUG_SEED("get_rdrand_seed");

 	int _eax;

-	// rdrand eax

+	/* rdrand eax */

 	/* clang-format off */

 	__asm__ __volatile__("1: .byte 0x0F\n"

 	                     "   .byte 0xC7\n"

@@ -132,7 +142,7 @@ static int get_rdrand_seed(void)

 	DEBUG_SEED("get_rdrand_seed");

 	int _eax;

 retry:

-	// rdrand eax

+	/* rdrand eax */

 	__asm _emit 0x0F __asm _emit 0xC7 __asm _emit 0xF0

 	__asm jnc retry

 	__asm mov _eax, eax

@@ -206,6 +216,10 @@ static int get_dev_random_seed(void)

 /* clang-format off */

 #include <windows.h>

+

+/* Caution: these blank lines must remain so clang-format doesn't reorder

+   includes to put windows.h after wincrypt.h */

+

 #include <wincrypt.h>

 /* clang-format on */

 #ifndef __GNUC__

From a9695f34c3f4bbd4475597cce1e5d48284286634 Mon Sep 17 00:00:00 2001

From: Tobias Stoeckmann <tobias@stoeckmann.org>

Date: Mon, 4 May 2020 19:41:16 +0200

Subject: [PATCH 06/18] Protect array_list_del_idx against size_t overflow.

If the assignment of stop overflows due to idx and count being

larger than SIZE_T_MAX in sum, out of boundary access could happen.

It takes invalid usage of this function for this to happen, but

I decided to add this check so array_list_del_idx is as safe against

bad usage as the other arraylist functions.

---

 arraylist.c | 3 +++

 1 file changed, 3 insertions(+)

diff --git a/arraylist.c b/arraylist.c

index 12ad8af6d3..e5524aca75 100644

--- a/arraylist.c

+++ b/arraylist.c

@@ -136,6 +136,9 @@ int array_list_del_idx(struct array_list *arr, size_t idx, size_t count)

 {

 	size_t i, stop;

+	/* Avoid overflow in calculation with large indices. */

+	if (idx > SIZE_T_MAX - count)

+		return -1;

 	stop = idx + count;

 	if (idx >= arr->length || stop > arr->length)

 		return -1;

From e66f7f7223fc6a2d3b808216ae28c7de65a54fe7 Mon Sep 17 00:00:00 2001

From: Tobias Stoeckmann <tobias@stoeckmann.org>

Date: Mon, 4 May 2020 19:46:45 +0200

Subject: [PATCH 07/18] Prevent division by zero in linkhash.

If a linkhash with a size of zero is created, then modulo operations

are prone to division by zero operations.

Purely protective measure against bad usage.

---

 linkhash.c | 3 +++

 1 file changed, 3 insertions(+)

diff --git a/linkhash.c b/linkhash.c

index 7ea58c0abf..f05cc38030 100644

--- a/linkhash.c

+++ b/linkhash.c

@@ -12,6 +12,7 @@

 #include "config.h"

+#include <assert.h>

 #include <limits.h>

 #include <stdarg.h>

 #include <stddef.h>

@@ -499,6 +500,8 @@ struct lh_table *lh_table_new(int size, lh_entry_free_fn *free_fn, lh_hash_fn *h

 	int i;

 	struct lh_table *t;

+	/* Allocate space for elements to avoid divisions by zero. */

+	assert(size > 0);

 	t = (struct lh_table *)calloc(1, sizeof(struct lh_table));

 	if (!t)

 		return NULL;

From c4eae053d4d5c6f300984677b4435f0c00f706a9 Mon Sep 17 00:00:00 2001

From: Tobias Stoeckmann <tobias@stoeckmann.org>

Date: Mon, 4 May 2020 19:47:25 +0200

Subject: [PATCH 08/18] Fix integer overflows.

The data structures linkhash and printbuf are limited to 2 GB in size

due to a signed integer being used to track their current size.

If too much data is added, then size variable can overflow, which is

an undefined behaviour in C programming language.

Assuming that a signed int overflow just leads to a negative value,

like it happens on many sytems (Linux i686/amd64 with gcc), then

printbuf is vulnerable to an out of boundary write on 64 bit systems.

---

 linkhash.c |  7 +++++--

 printbuf.c | 19 ++++++++++++++++---

 2 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/linkhash.c b/linkhash.c

index f05cc38030..51e90b13a2 100644

--- a/linkhash.c

+++ b/linkhash.c

@@ -580,9 +580,12 @@ int lh_table_insert_w_hash(struct lh_table *t, const void *k, const void *v, con

 {

 	unsigned long n;

-	if (t->count >= t->size * LH_LOAD_FACTOR)

-		if (lh_table_resize(t, t->size * 2) != 0)

+	if (t->count >= t->size * LH_LOAD_FACTOR) {

+		/* Avoid signed integer overflow with large tables. */

+		int new_size = INT_MAX / 2 < t->size ? t->size * 2 : INT_MAX;

+		if (t->size == INT_MAX || lh_table_resize(t, new_size) != 0)

 			return -1;

+	}

 	n = h % t->size;

diff --git a/printbuf.c b/printbuf.c

index 976c12dde5..00822fac4f 100644

--- a/printbuf.c

+++ b/printbuf.c

@@ -15,6 +15,7 @@

 #include "config.h"

+#include <limits.h>

 #include <stdio.h>

 #include <stdlib.h>

 #include <string.h>

@@ -65,10 +66,16 @@ static int printbuf_extend(struct printbuf *p, int min_size)

 	if (p->size >= min_size)

 		return 0;

-

-	new_size = p->size * 2;

-	if (new_size < min_size + 8)

+	/* Prevent signed integer overflows with large buffers. */

+	if (min_size > INT_MAX - 8)

+		return -1;

+	if (p->size > INT_MAX / 2)

 		new_size = min_size + 8;

+	else {

+		new_size = p->size * 2;

+		if (new_size < min_size + 8)

+			new_size = min_size + 8;

+	}

 #ifdef PRINTBUF_DEBUG

 	MC_DEBUG("printbuf_memappend: realloc "

 	         "bpos=%d min_size=%d old_size=%d new_size=%d\n",

@@ -83,6 +90,9 @@ static int printbuf_extend(struct printbuf *p, int min_size)

 int printbuf_memappend(struct printbuf *p, const char *buf, int size)

 {

+	/* Prevent signed integer overflows with large buffers. */

+	if (size > INT_MAX - p->bpos - 1)

+		return -1;

 	if (p->size <= p->bpos + size + 1)

 	{

 		if (printbuf_extend(p, p->bpos + size + 1) < 0)

@@ -100,6 +110,9 @@ int printbuf_memset(struct printbuf *pb, int offset, int charvalue, int len)

 	if (offset == -1)

 		offset = pb->bpos;

+	/* Prevent signed integer overflows with large buffers. */

+	if (len > INT_MAX - offset)

+		return -1;

 	size_needed = offset + len;

 	if (pb->size < size_needed)

 	{

From 392770c8e5c0783185bdfe0d919737e705190904 Mon Sep 17 00:00:00 2001

From: dota17 <chenguopingdota@163.com>

Date: Wed, 6 May 2020 10:48:53 +0800

Subject: [PATCH 09/18] support to build both static and shared libraries

---

 CMakeLists.txt | 20 ++++++++++++++++++++

 README.md      | 10 +++++++++-

 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt

index ea536947df..7d7bd7fcc4 100644

--- a/CMakeLists.txt

+++ b/CMakeLists.txt

@@ -392,6 +392,26 @@ target_include_directories(${PROJECT_NAME}

         $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}>

 )

+# Allow to build static and shared libraries at the same time

+if (BUILD_STATIC_LIBS)

+    set(ORIGINAL_STATIC_LIB_NAME ${PROJECT_NAME}-static)

+    add_library(${ORIGINAL_STATIC_LIB_NAME} STATIC

+        ${JSON_C_SOURCES}

+        ${JSON_C_HEADERS}

+    )

+

+    # rename the static library

+    set_target_properties(${ORIGINAL_STATIC_LIB_NAME} PROPERTIES

+        OUTPUT_NAME ${PROJECT_NAME}

+    )

+

+    target_include_directories(${PROJECT_NAME}

+        PUBLIC

+            $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>

+            $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}>

+    )

+endif ()

+

 # Always create new install dirs with 0755 permissions, regardless of umask

 set(CMAKE_INSTALL_DEFAULT_DIRECTORY_PERMISSIONS

 	OWNER_READ

diff --git a/README.md b/README.md

index 39ea0d6814..909fd116bf 100644

--- a/README.md

+++ b/README.md

@@ -98,6 +98,7 @@ Variable             | Type   | Description

 CMAKE_INSTALL_PREFIX | String | The install location.

 CMAKE_BUILD_TYPE     | String | Defaults to "debug"

 BUILD_SHARED_LIBS    | Bool   | The default build generates a dynamic (dll/so) library.  Set this to OFF to create a static library instead.

+BUILD_STATIC_LIBS    | Bool   | This build generates a static (lib/a) library.

 ENABLE_RDRAND        | Bool   | Enable RDRAND Hardware RNG Hash Seed

 ENABLE_THREADING     | Bool   | Enable partial threading support

 DISABLE_WERROR       | Bool   | Disable use of -Werror

@@ -106,7 +107,14 @@ DISABLE_BSYMBOLIC    | Bool   | Disable use of -Bsymbolic-functions

 Pass these options as `-D` on CMake's command-line.

 ```sh

-cmake -DBUILD_SHARED_LIBS=OFF ...

+# build a static library

+cmake -DBUILD_SHARED_LIBS=OFF ..

+```

+

+Allow to build both static and shared libraries.

+

+```sh

+cmake -DBUILD_STATIC_LIBS=ON ..

 ```

 ### Building with partial threading support

From af7a3e05af5e7410c1d8e00ec10b728db737843a Mon Sep 17 00:00:00 2001

From: dota17 <chenguopingdota@163.com>

Date: Thu, 7 May 2020 14:50:43 +0800

Subject: [PATCH 10/18] update

---

 CMakeLists.txt |  7 +------

 README.md      | 12 +++---------

 2 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt

index 7d7bd7fcc4..f82103879a 100644

--- a/CMakeLists.txt

+++ b/CMakeLists.txt

@@ -65,6 +65,7 @@ include(GNUInstallDirs)

 include(CMakePackageConfigHelpers)

 option(BUILD_SHARED_LIBS  "Default to building shared libraries" ON)

+option(BUILD_STATIC_LIBS  "Default to building static libraries" ON)

 # Generate a release merge and test it to verify the correctness of republishing the package.

 ADD_CUSTOM_TARGET(distcheck

@@ -404,12 +405,6 @@ if (BUILD_STATIC_LIBS)

     set_target_properties(${ORIGINAL_STATIC_LIB_NAME} PROPERTIES

         OUTPUT_NAME ${PROJECT_NAME}

     )

-

-    target_include_directories(${PROJECT_NAME}

-        PUBLIC

-            $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>

-            $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}>

-    )

 endif ()

 # Always create new install dirs with 0755 permissions, regardless of umask

diff --git a/README.md b/README.md

index 909fd116bf..f5a7ee39b4 100644

--- a/README.md

+++ b/README.md

@@ -97,8 +97,8 @@ Variable             | Type   | Description

 ---------------------|--------|--------------

 CMAKE_INSTALL_PREFIX | String | The install location.

 CMAKE_BUILD_TYPE     | String | Defaults to "debug"

-BUILD_SHARED_LIBS    | Bool   | The default build generates a dynamic (dll/so) library.  Set this to OFF to create a static library instead.

-BUILD_STATIC_LIBS    | Bool   | This build generates a static (lib/a) library.

+BUILD_SHARED_LIBS    | Bool   | The default build generates a dynamic (dll/so) library.  Set this to OFF to create a static library only.

+BUILD_STATIC_LIBS    | Bool   | The default build generates a static (lib/a) library.  Set this to OFF to create a shared library only.

 ENABLE_RDRAND        | Bool   | Enable RDRAND Hardware RNG Hash Seed

 ENABLE_THREADING     | Bool   | Enable partial threading support

 DISABLE_WERROR       | Bool   | Disable use of -Werror

@@ -107,16 +107,10 @@ DISABLE_BSYMBOLIC    | Bool   | Disable use of -Bsymbolic-functions

 Pass these options as `-D` on CMake's command-line.

 ```sh

-# build a static library

+# build a static library only

 cmake -DBUILD_SHARED_LIBS=OFF ..

 ```

-Allow to build both static and shared libraries.

-

-```sh

-cmake -DBUILD_STATIC_LIBS=ON ..

-```

-

 ### Building with partial threading support

 Although json-c does not support fully multi-threaded access to

From 077eceead18152fae8c6bd8e2288d53d5eba7cf6 Mon Sep 17 00:00:00 2001

From: hofnarr <hofnarr@hofnarr.fi>

Date: Fri, 8 May 2020 02:16:52 +0300

Subject: [PATCH 11/18] cmake: add list for build targets

---

 CMakeLists.txt | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt

index f82103879a..00613a8d67 100644

--- a/CMakeLists.txt

+++ b/CMakeLists.txt

@@ -384,7 +384,7 @@ add_library(${PROJECT_NAME}

 set_target_properties(${PROJECT_NAME} PROPERTIES

     VERSION 5.0.0

     SOVERSION 5)

-

+list(APPEND CMAKE_TARGETS ${PROJECT_NAME})

 # If json-c is used as subroject it set to target correct interface -I flags and allow

 # to build external target without extra include_directories(...)

 target_include_directories(${PROJECT_NAME}

@@ -405,6 +405,7 @@ if (BUILD_STATIC_LIBS)

     set_target_properties(${ORIGINAL_STATIC_LIB_NAME} PROPERTIES

         OUTPUT_NAME ${PROJECT_NAME}

     )

+    list(APPEND CMAKE_TARGETS ${STATIC_LIB})

 endif ()

 # Always create new install dirs with 0755 permissions, regardless of umask

@@ -418,7 +419,7 @@ set(CMAKE_INSTALL_DEFAULT_DIRECTORY_PERMISSIONS

 	WORLD_EXECUTE

    )

-install(TARGETS ${PROJECT_NAME}

+install(TARGETS ${CMAKE_TARGETS}

     EXPORT ${PROJECT_NAME}-targets

     RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}

     LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}

From 20895f941ee4e1ffe8248c30c01322970479d7cd Mon Sep 17 00:00:00 2001

From: hofnarr <hofnarr@hofnarr.fi>

Date: Fri, 8 May 2020 02:19:38 +0300

Subject: [PATCH 12/18] cmake: change variable name

---

 CMakeLists.txt | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt

index 00613a8d67..7302d4edf0 100644

--- a/CMakeLists.txt

+++ b/CMakeLists.txt

@@ -395,14 +395,14 @@ target_include_directories(${PROJECT_NAME}

 # Allow to build static and shared libraries at the same time

 if (BUILD_STATIC_LIBS)

-    set(ORIGINAL_STATIC_LIB_NAME ${PROJECT_NAME}-static)

-    add_library(${ORIGINAL_STATIC_LIB_NAME} STATIC

+    set(STATIC_LIB ${PROJECT_NAME}-static)

+    add_library(${STATIC_LIB} STATIC

         ${JSON_C_SOURCES}

         ${JSON_C_HEADERS}

     )

     # rename the static library

-    set_target_properties(${ORIGINAL_STATIC_LIB_NAME} PROPERTIES

+    set_target_properties(${STATIC_LIB} PROPERTIES

         OUTPUT_NAME ${PROJECT_NAME}

     )

     list(APPEND CMAKE_TARGETS ${STATIC_LIB})

From 2db5633de4980a33c911e9a52984ac62f2a5edf7 Mon Sep 17 00:00:00 2001

From: hofnarr <hofnarr@hofnarr.fi>

Date: Fri, 8 May 2020 02:27:06 +0300

Subject: [PATCH 13/18] cmake-configure: fix enable-static option

---

 cmake-configure | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmake-configure b/cmake-configure

index 2fcc39e3ca..c8e44aeed4 100755

--- a/cmake-configure

+++ b/cmake-configure

@@ -65,7 +65,7 @@ while [ $# -gt 0 ] ; do

 		FLAGS+=(-DBUILD_SHARED_LIBS=ON)

 		;;

 	--enable-static)

-		FLAGS+=(-DBUILD_SHARED_LIBS=OFF)

+		FLAGS+=(-DBUILD_STATIC_LIBS=ON)

 		;;

 	--disable-Bsymbolic)

 		FLAGS+=(-DDISABLE_BSYMBOLIC=ON)

From 7a4807fe0cdb1d9e20273c79762cbf54833aaae4 Mon Sep 17 00:00:00 2001

From: Eric Haszlakiewicz <erh+git@nimenees.com>

Date: Sun, 10 May 2020 03:32:19 +0000

Subject: [PATCH 14/18] Issue #599: Fix the backwards check in

 lh_table_insert_w_hash() that was preventing adding more than 11 objects. Add

 a test to check for this too.

---

 linkhash.c           |  2 +-

 tests/test4.c        | 29 +++++++++++++++++++++++++++++

 tests/test4.expected |  1 +

 3 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/linkhash.c b/linkhash.c

index 51e90b13a2..f930efd387 100644

--- a/linkhash.c

+++ b/linkhash.c

@@ -582,7 +582,7 @@ int lh_table_insert_w_hash(struct lh_table *t, const void *k, const void *v, con

 	if (t->count >= t->size * LH_LOAD_FACTOR) {

 		/* Avoid signed integer overflow with large tables. */

-		int new_size = INT_MAX / 2 < t->size ? t->size * 2 : INT_MAX;

+		int new_size = (t->size > INT_MAX / 2) ? INT_MAX : (t->size * 2);

 		if (t->size == INT_MAX || lh_table_resize(t, new_size) != 0)

 			return -1;

 	}

diff --git a/tests/test4.c b/tests/test4.c

index bd964ec789..fd2f3be8ec 100644

--- a/tests/test4.c

+++ b/tests/test4.c

@@ -3,8 +3,10 @@

  */

 #include "config.h"

+#include <assert.h>

 #include <stdio.h>

 #include <string.h>

+#include <stdlib.h>

 #include "json_inttypes.h"

 #include "json_object.h"

@@ -24,6 +26,30 @@ void print_hex(const char *s)

 	putchar('\n');

 }

+static void test_lot_of_adds(void);

+static void test_lot_of_adds()

+{

+	int ii;

+	char key[50];

+	json_object *jobj = json_object_new_object();

+	assert(jobj != NULL);

+	for (ii = 0; ii < 500; ii++)

+	{

+		snprintf(key, sizeof(key), "k%d", ii);