Blame SOURCES/15-revert-resourcelocator.patch

8e0cd2
diff --git a/application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsoleFormPage.java b/application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsoleFormPage.java
8e0cd2
index a6a2a7c..a252f9e 100644
8e0cd2
--- a/application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsoleFormPage.java
8e0cd2
+++ b/application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsoleFormPage.java
8e0cd2
@@ -43,7 +43,6 @@ import org.eclipse.jface.action.IToolBarManager;
8e0cd2
 import org.eclipse.jface.dialogs.IMessageProvider;
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
 import org.eclipse.jface.resource.JFaceResources;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
 import org.eclipse.swt.graphics.Image;
8e0cd2
 import org.eclipse.swt.widgets.Composite;
8e0cd2
 import org.eclipse.swt.widgets.Display;
8e0cd2
@@ -54,6 +53,7 @@ import org.eclipse.ui.forms.IManagedForm;
8e0cd2
 import org.eclipse.ui.forms.IMessageManager;
8e0cd2
 import org.eclipse.ui.forms.editor.FormPage;
8e0cd2
 import org.eclipse.ui.forms.widgets.Form;
8e0cd2
+import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
 import org.openjdk.jmc.console.ui.ConsolePlugin;
8e0cd2
 import org.openjdk.jmc.console.ui.editor.IConsolePageContainer;
8e0cd2
 import org.openjdk.jmc.console.ui.editor.IConsolePageStateHandler;
8e0cd2
@@ -175,7 +175,7 @@ public class ConsoleFormPage extends FormPage implements IConsolePageContainer {
8e0cd2
 		String iconName = config.getAttribute(ATTRIBUTE_ICON);
8e0cd2
 		if (iconName != null) {
8e0cd2
 			String pluginId = config.getDeclaringExtension().getContributor().getName();
8e0cd2
-			ImageDescriptor iconDesc = ResourceLocator.imageDescriptorFromBundle(pluginId, iconName).orElse(null);
8e0cd2
+			ImageDescriptor iconDesc = AbstractUIPlugin.imageDescriptorFromPlugin(pluginId, iconName);
8e0cd2
 			if (iconDesc != null) {
8e0cd2
 				icon = (Image) JFaceResources.getResources().get(iconDesc);
8e0cd2
 			} else {
8e0cd2
diff --git a/application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java b/application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java
8e0cd2
index d0be24a..e3f1000 100644
8e0cd2
--- a/application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java
8e0cd2
+++ b/application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPage.java
8e0cd2
@@ -38,7 +38,6 @@ import java.util.List;
8e0cd2
 import java.util.stream.Stream;
8e0cd2
 
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
 import org.eclipse.swt.SWT;
8e0cd2
 import org.eclipse.swt.custom.SashForm;
8e0cd2
 import org.eclipse.swt.graphics.Image;
8e0cd2
@@ -46,6 +45,7 @@ import org.eclipse.swt.widgets.Composite;
8e0cd2
 import org.eclipse.ui.forms.widgets.Form;
8e0cd2
 import org.eclipse.ui.forms.widgets.FormToolkit;
8e0cd2
 import org.eclipse.ui.forms.widgets.Section;
8e0cd2
+import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
 import org.openjdk.jmc.common.IState;
8e0cd2
 import org.openjdk.jmc.common.IWritableState;
8e0cd2
 import org.openjdk.jmc.common.item.Aggregators;
8e0cd2
@@ -98,8 +98,8 @@ public class JfxPage extends AbstractDataPage {
8e0cd2
 
8e0cd2
 		@Override
8e0cd2
 		public ImageDescriptor getImageDescriptor(IState state) {
8e0cd2
-			return ResourceLocator.imageDescriptorFromBundle("org.openjdk.jmc.flightrecorder.ext.jfx", //$NON-NLS-1$
8e0cd2
-					"icons/pulse.png").orElse(null); //$NON-NLS-1$
8e0cd2
+			return AbstractUIPlugin.imageDescriptorFromPlugin("org.openjdk.jmc.flightrecorder.ext.jfx", //$NON-NLS-1$
8e0cd2
+					"icons/pulse.png"); //$NON-NLS-1$
8e0cd2
 		}
8e0cd2
 
8e0cd2
 		@Override
8e0cd2
diff --git a/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java b/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
8e0cd2
index a8b76b0..bb57f10 100644
8e0cd2
--- a/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
8e0cd2
+++ b/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
8e0cd2
@@ -69,7 +69,6 @@ import org.eclipse.jface.action.IMenuManager;
8e0cd2
 import org.eclipse.jface.action.IToolBarManager;
8e0cd2
 import org.eclipse.jface.action.Separator;
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
 import org.eclipse.jface.viewers.ISelection;
8e0cd2
 import org.eclipse.jface.viewers.IStructuredSelection;
8e0cd2
 import org.eclipse.swt.SWT;
8e0cd2
@@ -93,6 +92,7 @@ import org.eclipse.ui.IWorkbenchPart;
8e0cd2
 import org.eclipse.ui.PartInitException;
8e0cd2
 import org.eclipse.ui.PlatformUI;
8e0cd2
 import org.eclipse.ui.part.ViewPart;
8e0cd2
+import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
 import org.openjdk.jmc.common.item.IItemCollection;
8e0cd2
 import org.openjdk.jmc.common.item.ItemCollectionToolkit;
8e0cd2
 import org.openjdk.jmc.common.util.StringToolkit;
8e0cd2
@@ -490,7 +490,7 @@ public class FlameGraphView extends ViewPart implements ISelectionListener {
8e0cd2
 	}
8e0cd2
 
8e0cd2
 	private static ImageDescriptor flameviewImageDescriptor(String iconName) {
8e0cd2
-		return ResourceLocator.imageDescriptorFromBundle(PLUGIN_ID, DIR_ICONS + iconName).orElse(null); //$NON-NLS-1$
8e0cd2
+		return AbstractUIPlugin.imageDescriptorFromPlugin(PLUGIN_ID, DIR_ICONS + iconName); //$NON-NLS-1$
8e0cd2
 	}
8e0cd2
 
8e0cd2
 	private static String getIconBase64(String iconName) {
8e0cd2
diff --git a/application/org.openjdk.jmc.flightrecorder.metadata/src/main/java/org/openjdk/jmc/flightrecorder/metadata/MetadataPage.java b/application/org.openjdk.jmc.flightrecorder.metadata/src/main/java/org/openjdk/jmc/flightrecorder/metadata/MetadataPage.java
8e0cd2
index 748cebc..019ce5e 100644
8e0cd2
--- a/application/org.openjdk.jmc.flightrecorder.metadata/src/main/java/org/openjdk/jmc/flightrecorder/metadata/MetadataPage.java
8e0cd2
+++ b/application/org.openjdk.jmc.flightrecorder.metadata/src/main/java/org/openjdk/jmc/flightrecorder/metadata/MetadataPage.java
8e0cd2
@@ -39,7 +39,6 @@ import java.util.stream.Stream;
8e0cd2
 import org.eclipse.jface.layout.GridDataFactory;
8e0cd2
 import org.eclipse.jface.layout.GridLayoutFactory;
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
 import org.eclipse.jface.viewers.ColumnViewerToolTipSupport;
8e0cd2
 import org.eclipse.jface.viewers.ISelection;
8e0cd2
 import org.eclipse.jface.viewers.TreePath;
8e0cd2
@@ -51,6 +50,7 @@ import org.eclipse.swt.widgets.Composite;
8e0cd2
 import org.eclipse.swt.widgets.Text;
8e0cd2
 import org.eclipse.ui.forms.widgets.Form;
8e0cd2
 import org.eclipse.ui.forms.widgets.FormToolkit;
8e0cd2
+import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
 import org.openjdk.jmc.common.IState;
8e0cd2
 import org.openjdk.jmc.common.IWritableState;
8e0cd2
 import org.openjdk.jmc.common.item.IItemIterable;
8e0cd2
@@ -231,7 +231,7 @@ public class MetadataPage extends AbstractDataPage {
8e0cd2
 
8e0cd2
 		@Override
8e0cd2
 		public ImageDescriptor getImageDescriptor(IState state) {
8e0cd2
-			return ResourceLocator.imageDescriptorFromBundle(PLUGIN_ID, ICON).orElse(null);
8e0cd2
+			return AbstractUIPlugin.imageDescriptorFromPlugin(PLUGIN_ID, ICON);
8e0cd2
 		}
8e0cd2
 
8e0cd2
 		@Override
8e0cd2
diff --git a/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/ApplicationPlugin.java b/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/ApplicationPlugin.java
8e0cd2
index bcdf8b9..fff9296 100644
8e0cd2
--- a/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/ApplicationPlugin.java
8e0cd2
+++ b/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/ApplicationPlugin.java
8e0cd2
@@ -39,7 +39,6 @@ import java.util.logging.Logger;
8e0cd2
 
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
 import org.eclipse.jface.resource.ImageRegistry;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
 import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
 import org.openjdk.jmc.common.io.IOToolkit;
8e0cd2
 import org.openjdk.jmc.rcp.application.p2.AddRepositoriesJob;
8e0cd2
@@ -144,6 +143,6 @@ public class ApplicationPlugin extends AbstractUIPlugin {
8e0cd2
 	 * @return the image descriptor
8e0cd2
 	 */
8e0cd2
 	public static ImageDescriptor getImageDescriptor(String path) {
8e0cd2
-		return ResourceLocator.imageDescriptorFromBundle(PLUGIN_ID, path).orElse(null);
8e0cd2
+		return AbstractUIPlugin.imageDescriptorFromPlugin(PLUGIN_ID, path);
8e0cd2
 	}
8e0cd2
 }
8e0cd2
diff --git a/application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/internal/RemoveAction.java b/application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/internal/RemoveAction.java
8e0cd2
index 6380709..4a66939 100644
8e0cd2
--- a/application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/internal/RemoveAction.java
8e0cd2
+++ b/application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/internal/RemoveAction.java
8e0cd2
@@ -34,16 +34,16 @@ package org.openjdk.jmc.rjmx.ui.internal;
8e0cd2
 
8e0cd2
 import org.eclipse.jface.action.Action;
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
 import org.eclipse.ui.forms.SectionPart;
8e0cd2
+import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
 import org.openjdk.jmc.ui.misc.MCSectionPart;
8e0cd2
 
8e0cd2
 /**
8e0cd2
  * Action for removing a {@link SectionPart} in a {@link SectionPartManager}
8e0cd2
  */
8e0cd2
 public class RemoveAction extends Action {
8e0cd2
-	private final static ImageDescriptor ICON = ResourceLocator.imageDescriptorFromBundle("org.eclipse.ui", //$NON-NLS-1$
8e0cd2
-			"icons/full/elcl16/close_view.gif").orElse(null); //$NON-NLS-1$
8e0cd2
+	private final static ImageDescriptor ICON = AbstractUIPlugin.imageDescriptorFromPlugin("org.eclipse.ui", //$NON-NLS-1$
8e0cd2
+			"icons/full/elcl16/close_view.gif"); //$NON-NLS-1$
8e0cd2
 	final private SectionPartManager m_sectionPartmanager;
8e0cd2
 	final private MCSectionPart m_part;
8e0cd2
 
8e0cd2
diff --git a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/CoreImages.java b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/CoreImages.java
8e0cd2
index 5cd717b..d6a19a9 100644
8e0cd2
--- a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/CoreImages.java
8e0cd2
+++ b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/CoreImages.java
8e0cd2
@@ -35,7 +35,7 @@ package org.openjdk.jmc.ui;
8e0cd2
 import java.util.MissingResourceException;
8e0cd2
 
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
+import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
 
8e0cd2
 /**
8e0cd2
  * Storage for common ImageDescriptors.
8e0cd2
@@ -177,7 +177,7 @@ public class CoreImages {
8e0cd2
 	}
8e0cd2
 
8e0cd2
 	private static ImageDescriptor createDescriptor(String relPath) {
8e0cd2
-		ImageDescriptor desc = ResourceLocator.imageDescriptorFromBundle(UIPlugin.PLUGIN_ID, relPath).orElse(null);
8e0cd2
+		ImageDescriptor desc = AbstractUIPlugin.imageDescriptorFromPlugin(UIPlugin.PLUGIN_ID, relPath);
8e0cd2
 		if (desc == null) {
8e0cd2
 			// FIXME: Throwing an exception has the development time advantage of being very intrusive. For release time, logging might be better.
8e0cd2
 			throw new MissingResourceException("Missing image '" + relPath + '\'', ImageDescriptor.class.getName(), //$NON-NLS-1$
8e0cd2
diff --git a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ImageDescriptorAdapterFactory.java b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ImageDescriptorAdapterFactory.java
8e0cd2
index de112b0..e04e796 100644
8e0cd2
--- a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ImageDescriptorAdapterFactory.java
8e0cd2
+++ b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ImageDescriptorAdapterFactory.java
8e0cd2
@@ -34,7 +34,8 @@ package org.openjdk.jmc.ui.misc;
8e0cd2
 
8e0cd2
 import org.eclipse.core.runtime.IAdapterFactory;
8e0cd2
 import org.eclipse.jface.resource.ImageDescriptor;
8e0cd2
-import org.eclipse.jface.resource.ResourceLocator;
8e0cd2
+import org.eclipse.ui.plugin.AbstractUIPlugin;
8e0cd2
+
8e0cd2
 import org.openjdk.jmc.ui.common.resource.IImageResource;
8e0cd2
 import org.openjdk.jmc.ui.common.resource.Resource;
8e0cd2
 import org.openjdk.jmc.ui.common.util.AdapterUtil;
8e0cd2
@@ -49,8 +50,7 @@ public class ImageDescriptorAdapterFactory implements IAdapterFactory {
8e0cd2
 			if (imageResource != null) {
8e0cd2
 				Resource r = imageResource.getImageResource();
8e0cd2
 				if (r != null) {
8e0cd2
-					return adapterType.cast(ResourceLocator
8e0cd2
-							.imageDescriptorFromBundle(r.getPluginId(), r.getResourcePath()).orElse(null));
8e0cd2
+					return adapterType.cast(AbstractUIPlugin.imageDescriptorFromPlugin(r.getPluginId(), r.getResourcePath()));
8e0cd2
 				}
8e0cd2
 			}
8e0cd2
 			IGraphical g = AdapterUtil.getAdapter(adaptableObject, IGraphical.class);