Blame SOURCES/open-iscsi-2.0.875-16-Ensure-all-fields-in-iscsiuio-IPC-response-are-set.patch
|
|
47585c |
From be58eed849f5457bb49b79e94aa6a26971ba6deb Mon Sep 17 00:00:00 2001
|
|
|
47585c |
From: Lee Duncan <lduncan@suse.com>
|
|
|
47585c |
Date: Fri, 15 Dec 2017 11:11:17 -0800
|
|
|
47585c |
Subject: [PATCH] Ensure all fields in iscsiuio IPC response are set
|
|
|
47585c |
|
|
|
47585c |
Make sure all fields in the response strcuture are set,
|
|
|
47585c |
or info from the stack can be leaked to our caller.
|
|
|
47585c |
Found by Qualsys.
|
|
|
47585c |
---
|
|
|
47585c |
iscsiuio/src/unix/iscsid_ipc.c | 2 ++
|
|
|
47585c |
1 file changed, 2 insertions(+)
|
|
|
47585c |
|
|
|
47585c |
diff --git a/iscsiuio/src/unix/iscsid_ipc.c b/iscsiuio/src/unix/iscsid_ipc.c
|
|
|
47585c |
index b5d7051b0558..c3b10e03774a 100644
|
|
|
47585c |
--- a/iscsiuio/src/unix/iscsid_ipc.c
|
|
|
47585c |
+++ b/iscsiuio/src/unix/iscsid_ipc.c
|
|
|
47585c |
@@ -955,6 +955,8 @@ int process_iscsid_broadcast(int s2)
|
|
|
47585c |
LOG_DEBUG(PFX "recv iscsid request: cmd: %d, payload_len: %d",
|
|
|
47585c |
cmd, payload_len);
|
|
|
47585c |
|
|
|
47585c |
+ memset(&rsp, 0, sizeof(rsp));
|
|
|
47585c |
+
|
|
|
47585c |
switch (cmd) {
|
|
|
47585c |
case ISCSID_UIP_IPC_GET_IFACE:
|
|
|
47585c |
size = fread(&data->u.iface_rec, payload_len, 1, fd);
|
|
|
47585c |
--
|
|
|
47585c |
2.17.2
|
|
|
47585c |
|