Blame SOURCES/open-iscsi-2.0.875-15-iscsiuio-should-ignore-bogus-iscsid-broadcast-packets.patch
|
 |
e88930 |
From b9c33683bdc0aed28ffe31c3f3d50bf5cdf519ea Mon Sep 17 00:00:00 2001
|
|
|
e88930 |
From: Lee Duncan <lduncan@suse.com>
|
|
|
e88930 |
Date: Fri, 15 Dec 2017 10:37:56 -0800
|
|
|
e88930 |
Subject: [PATCH] iscsiuio should ignore bogus iscsid broadcast packets
|
|
|
e88930 |
|
|
|
e88930 |
When iscsiuio is receiving broadcast packets from iscsid,
|
|
|
e88930 |
if the 'payload_len', carried in the packet, is too
|
|
|
e88930 |
large then ignore the packet and print a message.
|
|
|
e88930 |
Found by Qualsys.
|
|
|
e88930 |
---
|
|
|
e88930 |
iscsiuio/src/unix/iscsid_ipc.c | 6 ++++++
|
|
|
e88930 |
1 file changed, 6 insertions(+)
|
|
|
e88930 |
|
|
|
e88930 |
diff --git a/iscsiuio/src/unix/iscsid_ipc.c b/iscsiuio/src/unix/iscsid_ipc.c
|
|
|
e88930 |
index 64762654c523..b5d7051b0558 100644
|
|
|
e88930 |
--- a/iscsiuio/src/unix/iscsid_ipc.c
|
|
|
e88930 |
+++ b/iscsiuio/src/unix/iscsid_ipc.c
|
|
|
e88930 |
@@ -945,6 +945,12 @@ int process_iscsid_broadcast(int s2)
|
|
|
e88930 |
|
|
|
e88930 |
cmd = data->header.command;
|
|
|
e88930 |
payload_len = data->header.payload_len;
|
|
|
e88930 |
+ if (payload_len > sizeof(data->u)) {
|
|
|
e88930 |
+ LOG_ERR(PFX "Data payload length too large (%d). Corrupt payload?",
|
|
|
e88930 |
+ payload_len);
|
|
|
e88930 |
+ rc = -EINVAL;
|
|
|
e88930 |
+ goto error;
|
|
|
e88930 |
+ }
|
|
|
e88930 |
|
|
|
e88930 |
LOG_DEBUG(PFX "recv iscsid request: cmd: %d, payload_len: %d",
|
|
|
e88930 |
cmd, payload_len);
|
|
|
e88930 |
--
|
|
|
e88930 |
2.17.2
|
|
|
e88930 |
|