1a76fd
From fd538429be486d057b092e3b9c148add2c5ea9c2 Mon Sep 17 00:00:00 2001
1a76fd
From: rpm-build <rpm-build>
1a76fd
Date: Tue, 4 Jun 2019 13:23:32 -0700
1a76fd
Subject: [PATCH 1/1] unit file tweaks
1a76fd
1a76fd
---
1a76fd
 etc/systemd/iscsi-mark-root-nodes  | 34 ++++++++++++++++++++++++++++++
1a76fd
 etc/systemd/iscsi-onboot.service   | 15 +++++++++++++
1a76fd
 etc/systemd/iscsi-shutdown.service | 15 +++++++++++++
1a76fd
 etc/systemd/iscsi.service          | 16 +++++++-------
1a76fd
 etc/systemd/iscsid.service         |  3 +--
1a76fd
 etc/systemd/iscsiuio.service       |  4 +---
1a76fd
 6 files changed, 74 insertions(+), 13 deletions(-)
1a76fd
 create mode 100755 etc/systemd/iscsi-mark-root-nodes
1a76fd
 create mode 100644 etc/systemd/iscsi-onboot.service
1a76fd
 create mode 100644 etc/systemd/iscsi-shutdown.service
1a76fd
1a76fd
diff --git a/etc/systemd/iscsi-mark-root-nodes b/etc/systemd/iscsi-mark-root-nodes
1a76fd
new file mode 100755
1a76fd
index 0000000..9d48805
1a76fd
--- /dev/null
1a76fd
+++ b/etc/systemd/iscsi-mark-root-nodes
1a76fd
@@ -0,0 +1,34 @@
1a76fd
+#!/bin/bash
1a76fd
+
1a76fd
+ISCSIADM=/usr/sbin/iscsiadm
1a76fd
+start_iscsid=0
1a76fd
+start_iscsiuio=0
1a76fd
+
1a76fd
+while read t num p target flash; do
1a76fd
+  # strip tag number from portal, keep "ip:port"
1a76fd
+  portal=${p%,*}
1a76fd
+  transport=${t%:}
1a76fd
+
1a76fd
+  # use session number to find the iface name in use
1a76fd
+  num=${num#[}; num=${num%]}
1a76fd
+  iface=$(iscsiadm -m session -r $num | grep iface.iscsi_ifacename | cut -d= -f2)
1a76fd
+
1a76fd
+  $ISCSIADM -m node -p $portal -T $target -I $iface -o update -n node.startup -v onboot
1a76fd
+
1a76fd
+  start_iscsid=1
1a76fd
+
1a76fd
+  if [ "$transport" = bnx2i ] || [ "$transport" = qedi ]; then
1a76fd
+    start_iscsiuio=1
1a76fd
+  fi
1a76fd
+done < <( $ISCSIADM -m session )
1a76fd
+
1a76fd
+# force iscsid and iscsiuio to start if needed for
1a76fd
+# recovering sessions created in the initrd
1a76fd
+
1a76fd
+if [ "$start_iscsid" -eq 1 ]; then
1a76fd
+  systemctl --no-block start iscsid.service
1a76fd
+fi
1a76fd
+if [ "$start_iscsiuio" -eq 1 ]; then
1a76fd
+  systemctl --no-block start iscsiuio.service
1a76fd
+fi
1a76fd
+
1a76fd
diff --git a/etc/systemd/iscsi-onboot.service b/etc/systemd/iscsi-onboot.service
1a76fd
new file mode 100644
1a76fd
index 0000000..42ced68
1a76fd
--- /dev/null
1a76fd
+++ b/etc/systemd/iscsi-onboot.service
1a76fd
@@ -0,0 +1,15 @@
1a76fd
+[Unit]
1a76fd
+Description=Special handling of early boot iSCSI sessions
1a76fd
+Documentation=man:iscsiadm(8) man:iscsid(8)
1a76fd
+DefaultDependencies=no
1a76fd
+RefuseManualStart=true
1a76fd
+Before=iscsi.service
1a76fd
+After=systemd-remount-fs.service
1a76fd
+ConditionDirectoryNotEmpty=/sys/class/iscsi_session
1a76fd
+
1a76fd
+[Service]
1a76fd
+Type=oneshot
1a76fd
+ExecStart=-/usr/libexec/iscsi-mark-root-nodes
1a76fd
+
1a76fd
+[Install]
1a76fd
+WantedBy=sysinit.target
1a76fd
diff --git a/etc/systemd/iscsi-shutdown.service b/etc/systemd/iscsi-shutdown.service
1a76fd
new file mode 100644
1a76fd
index 0000000..caee933
1a76fd
--- /dev/null
1a76fd
+++ b/etc/systemd/iscsi-shutdown.service
1a76fd
@@ -0,0 +1,15 @@
1a76fd
+[Unit]
1a76fd
+Description=Logout off all iSCSI sessions on shutdown
1a76fd
+Documentation=man:iscsid(8) man:iscsiadm(8)
1a76fd
+DefaultDependencies=no
1a76fd
+Conflicts=shutdown.target
1a76fd
+After=systemd-remount-fs.service network.target iscsid.service iscsiuio.service
1a76fd
+Before=remote-fs-pre.target
1a76fd
+Wants=remote-fs-pre.target
1a76fd
+RefuseManualStop=yes
1a76fd
+
1a76fd
+[Service]
1a76fd
+Type=oneshot
1a76fd
+RemainAfterExit=true
1a76fd
+ExecStart=-/usr/bin/true
1a76fd
+ExecStop=-/usr/sbin/iscsiadm -m node --logoutall=all
1a76fd
diff --git a/etc/systemd/iscsi.service b/etc/systemd/iscsi.service
1a76fd
index 5e394b9..175cb2c 100644
1a76fd
--- a/etc/systemd/iscsi.service
1a76fd
+++ b/etc/systemd/iscsi.service
1a76fd
@@ -1,18 +1,18 @@
1a76fd
 [Unit]
1a76fd
 Description=Login and scanning of iSCSI devices
1a76fd
 Documentation=man:iscsiadm(8) man:iscsid(8)
1a76fd
-Before=remote-fs.target
1a76fd
-After=network-online.target iscsid.service
1a76fd
-Requires=iscsid.socket iscsi-init.service
1a76fd
-Wants=network-online.target
1a76fd
+DefaultDependencies=no
1a76fd
+Before=remote-fs-pre.target
1a76fd
+After=network.target network-online.target iscsid.service iscsiuio.service systemd-remount-fs.service
1a76fd
+Wants=remote-fs-pre.target iscsi-shutdown.service
1a76fd
+ConditionDirectoryNotEmpty=/var/lib/iscsi/nodes
1a76fd
 
1a76fd
 [Service]
1a76fd
 Type=oneshot
1a76fd
-ExecStart=/sbin/iscsiadm -m node --loginall=automatic -W
1a76fd
-ExecStop=/sbin/iscsiadm -m node --logoutall=automatic
1a76fd
-ExecStop=/sbin/iscsiadm -m node --logoutall=manual
1a76fd
-SuccessExitStatus=21 15
1a76fd
 RemainAfterExit=true
1a76fd
+ExecStart=-/usr/sbin/iscsiadm -m node --loginall=automatic
1a76fd
+ExecReload=-/usr/sbin/iscsiadm -m node --loginall=automatic
1a76fd
+SuccessExitStatus=21
1a76fd
 
1a76fd
 [Install]
1a76fd
 WantedBy=remote-fs.target
1a76fd
diff --git a/etc/systemd/iscsid.service b/etc/systemd/iscsid.service
1a76fd
index 3fd7dd3..324c593 100644
1a76fd
--- a/etc/systemd/iscsid.service
1a76fd
+++ b/etc/systemd/iscsid.service
1a76fd
@@ -4,13 +4,12 @@ Documentation=man:iscsid(8) man:iscsiuio(8) man:iscsiadm(8)
1a76fd
 DefaultDependencies=no
1a76fd
 After=network-online.target iscsiuio.service iscsi-init.service
1a76fd
 Before=remote-fs-pre.target
1a76fd
-Wants=remote-fs-pre.target
1a76fd
 Requires=iscsi-init.service
1a76fd
 
1a76fd
 [Service]
1a76fd
 Type=notify
1a76fd
 NotifyAccess=main
1a76fd
-ExecStart=/sbin/iscsid -f
1a76fd
+ExecStart=/usr/sbin/iscsid -f
1a76fd
 KillMode=mixed
1a76fd
 Restart=on-failure
1a76fd
 
1a76fd
diff --git a/etc/systemd/iscsiuio.service b/etc/systemd/iscsiuio.service
1a76fd
index 923e019..fc0be93 100644
1a76fd
--- a/etc/systemd/iscsiuio.service
1a76fd
+++ b/etc/systemd/iscsiuio.service
1a76fd
@@ -2,17 +2,15 @@
1a76fd
 Description=iSCSI UserSpace I/O driver
1a76fd
 Documentation=man:iscsiuio(8)
1a76fd
 DefaultDependencies=no
1a76fd
-Conflicts=shutdown.target
1a76fd
 Requires=iscsid.service
1a76fd
 BindTo=iscsid.service
1a76fd
 After=network.target
1a76fd
 Before=remote-fs-pre.target iscsid.service
1a76fd
-Wants=remote-fs-pre.target
1a76fd
 
1a76fd
 [Service]
1a76fd
 Type=notify
1a76fd
 NotifyAccess=main
1a76fd
-ExecStart=/sbin/iscsiuio -f
1a76fd
+ExecStart=/usr/sbin/iscsiuio -f
1a76fd
 KillMode=mixed
1a76fd
 Restart=on-failure
1a76fd
 
1a76fd
-- 
1a76fd
2.26.3
1a76fd