|
 |
36cfb7 |
From 1fe740ceabb0b965224678a69a02255e20d5a47a Mon Sep 17 00:00:00 2001
|
|
|
36cfb7 |
From: Andrea Claudi <aclaudi@redhat.com>
|
|
|
36cfb7 |
Date: Mon, 29 Apr 2019 20:07:22 +0200
|
|
|
36cfb7 |
Subject: [PATCH] devlink: No need for this self-assignment
|
|
|
36cfb7 |
|
|
|
36cfb7 |
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1465646
|
|
|
36cfb7 |
Upstream Status: iproute2.git commit 8579a398c5ab0
|
|
|
36cfb7 |
|
|
|
36cfb7 |
commit 8579a398c5ab0d26bce0ed9b4b6b6e5d62fcc89d
|
|
|
36cfb7 |
Author: Phil Sutter <phil@nwl.cc>
|
|
|
36cfb7 |
Date: Thu Aug 17 19:09:25 2017 +0200
|
|
|
36cfb7 |
|
|
|
36cfb7 |
devlink: No need for this self-assignment
|
|
|
36cfb7 |
|
|
|
36cfb7 |
dl_argv_handle_both() will either assign to handle_bit or error out in
|
|
|
36cfb7 |
which case the variable is not used by the caller.
|
|
|
36cfb7 |
|
|
|
36cfb7 |
Signed-off-by: Phil Sutter <phil@nwl.cc>
|
|
|
36cfb7 |
Acked-by: Jiri Pirko <jiri@mellanox.com>
|
|
|
36cfb7 |
---
|
|
|
36cfb7 |
devlink/devlink.c | 2 +-
|
|
|
36cfb7 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
36cfb7 |
|
|
|
36cfb7 |
diff --git a/devlink/devlink.c b/devlink/devlink.c
|
|
|
36cfb7 |
index 2000db81aabb0..ae295b5632e8c 100644
|
|
|
36cfb7 |
--- a/devlink/devlink.c
|
|
|
36cfb7 |
+++ b/devlink/devlink.c
|
|
|
36cfb7 |
@@ -845,7 +845,7 @@ static int dl_argv_parse(struct dl *dl, uint32_t o_required,
|
|
|
36cfb7 |
int err;
|
|
|
36cfb7 |
|
|
|
36cfb7 |
if (o_required & DL_OPT_HANDLE && o_required & DL_OPT_HANDLEP) {
|
|
|
36cfb7 |
- uint32_t handle_bit = handle_bit;
|
|
|
36cfb7 |
+ uint32_t handle_bit;
|
|
|
36cfb7 |
|
|
|
36cfb7 |
err = dl_argv_handle_both(dl, &opts->bus_name, &opts->dev_name,
|
|
|
36cfb7 |
&opts->port_index, &handle_bit);
|
|
|
36cfb7 |
--
|
|
|
e138d9 |
2.21.0
|
|
|
36cfb7 |
|