|
 |
007797 |
From 9d72def87ecc384d0a46525c766e755068fefe54 Mon Sep 17 00:00:00 2001
|
|
|
007797 |
From: =?UTF-8?q?V=C3=A1clav=20Dole=C5=BEal?= <vdolezal@redhat.com>
|
|
|
007797 |
Date: Thu, 28 May 2020 13:32:31 +0200
|
|
|
007797 |
Subject: [PATCH] lanplus: don't retry pre-session Get cipher suites
|
|
|
007797 |
MIME-Version: 1.0
|
|
|
007797 |
Content-Type: text/plain; charset=UTF-8
|
|
|
007797 |
Content-Transfer-Encoding: 8bit
|
|
|
007797 |
|
|
|
007797 |
Some BMCs are ignoring it, causing needless delay.
|
|
|
007797 |
|
|
|
007797 |
Signed-off-by: Václav Doležal <vdolezal@redhat.com>
|
|
|
007797 |
---
|
|
|
007797 |
src/plugins/lanplus/lanplus.c | 8 ++++++--
|
|
|
007797 |
1 file changed, 6 insertions(+), 2 deletions(-)
|
|
|
007797 |
|
|
|
007797 |
diff --git a/src/plugins/lanplus/lanplus.c b/src/plugins/lanplus/lanplus.c
|
|
|
007797 |
index 3087348..c442c0e 100644
|
|
|
007797 |
--- a/src/plugins/lanplus/lanplus.c
|
|
|
007797 |
+++ b/src/plugins/lanplus/lanplus.c
|
|
|
007797 |
@@ -3459,9 +3459,13 @@ ipmi_find_best_cipher_suite(struct ipmi_intf *intf)
|
|
|
007797 |
};
|
|
|
007797 |
const size_t nr_preferred = ARRAY_SIZE(cipher_order_preferred);
|
|
|
007797 |
size_t ipref, i;
|
|
|
007797 |
+ int rc;
|
|
|
007797 |
+ int retry_old = intf->ssn_params.retry;
|
|
|
007797 |
|
|
|
007797 |
- if (ipmi_get_channel_cipher_suites(intf, "ipmi", IPMI_LAN_CHANNEL_E,
|
|
|
007797 |
- suites, &nr_suites) < 0)
|
|
|
007797 |
+ ipmi_intf_session_set_retry(intf, 1);
|
|
|
007797 |
+ rc = ipmi_get_channel_cipher_suites(intf, "ipmi", IPMI_LAN_CHANNEL_E, suites, &nr_suites);
|
|
|
007797 |
+ ipmi_intf_session_set_retry(intf, retry_old);
|
|
|
007797 |
+ if (rc < 0)
|
|
|
007797 |
{
|
|
|
007797 |
/* default legacy behavior - cipher suite 3 if none is requested */
|
|
|
007797 |
return IPMI_LANPLUS_CIPHER_SUITE_3;
|
|
|
007797 |
--
|
|
|
007797 |
2.25.4
|
|
|
007797 |
|