e3ffab
From e6f71d031a114cd8fbd752e1ce8e2a02007a009b Mon Sep 17 00:00:00 2001
e3ffab
From: Jan Cholasta <jcholast@redhat.com>
e3ffab
Date: Mon, 10 Nov 2014 18:12:02 +0000
e3ffab
Subject: [PATCH] Fix unchecked return value in ipa-join
e3ffab
e3ffab
https://fedorahosted.org/freeipa/ticket/4713
e3ffab
e3ffab
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
e3ffab
---
e3ffab
 ipa-client/ipa-join.c | 5 ++++-
e3ffab
 1 file changed, 4 insertions(+), 1 deletion(-)
e3ffab
e3ffab
diff --git a/ipa-client/ipa-join.c b/ipa-client/ipa-join.c
e3ffab
index 46f64572dcaeb3be61dadf87a07520ad21fb4f47..ac8251fef3b0a03de0920e8732b44bac208f55a6 100644
e3ffab
--- a/ipa-client/ipa-join.c
e3ffab
+++ b/ipa-client/ipa-join.c
e3ffab
@@ -208,8 +208,11 @@ connect_ldap(const char *hostname, const char *binddn, const char *bindpw) {
e3ffab
     struct berval bindpw_bv;
e3ffab
 
e3ffab
     if (debug) {
e3ffab
-        ldapdebug=2;
e3ffab
+        ldapdebug = 2;
e3ffab
         ret = ldap_set_option(NULL, LDAP_OPT_DEBUG_LEVEL, &ldapdebug);
e3ffab
+        if (ret != LDAP_OPT_SUCCESS) {
e3ffab
+            goto fail;
e3ffab
+        }
e3ffab
     }
e3ffab
 
e3ffab
     if (ldap_set_option(NULL, LDAP_OPT_X_TLS_CACERTFILE, CAFILE) != LDAP_OPT_SUCCESS)
e3ffab
-- 
e3ffab
2.1.0
e3ffab