f65af0
From 06654aba40bd79eff8bd44ac629bb5bb9b8f9c26 Mon Sep 17 00:00:00 2001
979ee0
From: =?UTF-8?q?Tibor=20Dudl=C3=A1k?= <tdudlak@redhat.com>
979ee0
Date: Thu, 26 Jul 2018 11:46:55 +0200
979ee0
Subject: [PATCH] Do not set ca_host when --setup-ca is used
979ee0
979ee0
Setting ca_host caused replication failures on DL0
979ee0
because it was trying to connect to wrong CA host.
979ee0
Trying to avoid corner-case in ipaserver/plugins/dogtag.py
979ee0
when api.env.host nor api.env.ca_host had not CA configured
979ee0
and there was ca_host set to api.env.ca_host variable.
979ee0
979ee0
See: https://pagure.io/freeipa/issue/7566
979ee0
Resolves: https://pagure.io/freeipa/issue/7629
979ee0
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
979ee0
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
979ee0
Reviewed-By: Christian Heimes <cheimes@redhat.com>
979ee0
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
979ee0
---
979ee0
 ipaserver/install/cainstance.py            | 24 ++++++++++++++++++++++
979ee0
 ipaserver/install/server/replicainstall.py |  7 +++++--
979ee0
 2 files changed, 29 insertions(+), 2 deletions(-)
979ee0
979ee0
diff --git a/ipaserver/install/cainstance.py b/ipaserver/install/cainstance.py
f65af0
index 6dbf69b3e5833f220a4d7d640b66a8fcf824f445..ffcebd719a16ebc5a991b35507b96411ad31eb10 100644
979ee0
--- a/ipaserver/install/cainstance.py
979ee0
+++ b/ipaserver/install/cainstance.py
f65af0
@@ -451,6 +451,11 @@ class CAInstance(DogtagInstance):
979ee0
                 self.step("updating IPA configuration", update_ipa_conf)
979ee0
                 self.step("enabling CA instance", self.__enable_instance)
979ee0
                 if not promote:
979ee0
+                    if self.clone:
979ee0
+                        # DL0 workaround; see docstring of __expose_ca_in_ldap
979ee0
+                        self.step("exposing CA instance on LDAP",
979ee0
+                                  self.__expose_ca_in_ldap)
979ee0
+
979ee0
                     self.step("migrating certificate profiles to LDAP",
979ee0
                               migrate_profiles_to_ldap)
979ee0
                     self.step("importing IPA certificate profiles",
f65af0
@@ -1268,6 +1273,25 @@ class CAInstance(DogtagInstance):
979ee0
             config = []
979ee0
         self.ldap_configure('CA', self.fqdn, None, basedn, config)
979ee0
 
979ee0
+    def __expose_ca_in_ldap(self):
979ee0
+        """
979ee0
+        In a case when replica is created on DL0 we need to make
979ee0
+        sure that query for CA service record of this replica in
979ee0
+        ldap will succeed in time of installation.
979ee0
+        This method is needed for sucessfull replica installation
979ee0
+        on DL0 and should be removed alongside with code for DL0.
979ee0
+
979ee0
+        To suppress deprecation warning message this method is
979ee0
+        not invoking ldap_enable() but _ldap_enable() method.
979ee0
+        """
979ee0
+
979ee0
+        basedn = ipautil.realm_to_suffix(self.realm)
979ee0
+        if not self.clone:
979ee0
+            config = ['caRenewalMaster']
979ee0
+        else:
979ee0
+            config = []
979ee0
+        self._ldap_enable(u'enabledService', "CA", self.fqdn, basedn, config)
979ee0
+
979ee0
     def setup_lightweight_ca_key_retrieval(self):
979ee0
         if sysupgrade.get_upgrade_state('dogtag', 'setup_lwca_key_retrieval'):
979ee0
             return
979ee0
diff --git a/ipaserver/install/server/replicainstall.py b/ipaserver/install/server/replicainstall.py
f65af0
index e78a2b992fbd44b8ee3ccd8183ebd6e13dfd1749..42c723b57699340d7dfa67f581ab7d4d4fdcf551 100644
979ee0
--- a/ipaserver/install/server/replicainstall.py
979ee0
+++ b/ipaserver/install/server/replicainstall.py
f65af0
@@ -241,9 +241,12 @@ def create_ipa_conf(fstore, config, ca_enabled, master=None):
979ee0
         gopts.extend([
979ee0
             ipaconf.setOption('enable_ra', 'True'),
979ee0
             ipaconf.setOption('ra_plugin', 'dogtag'),
979ee0
-            ipaconf.setOption('dogtag_version', '10'),
979ee0
-            ipaconf.setOption('ca_host', config.ca_host_name)
979ee0
+            ipaconf.setOption('dogtag_version', '10')
979ee0
         ])
979ee0
+
979ee0
+        if not config.setup_ca:
979ee0
+            gopts.append(ipaconf.setOption('ca_host', config.ca_host_name))
979ee0
+
979ee0
     else:
979ee0
         gopts.extend([
979ee0
             ipaconf.setOption('enable_ra', 'False'),
979ee0
-- 
979ee0
2.17.1
979ee0