8cffd2
From 7423bf0192310509ff963d2b67c85409a501d4e3 Mon Sep 17 00:00:00 2001
8cffd2
From: Alexander Bokovoy <abokovoy@redhat.com>
8cffd2
Date: Wed, 24 Feb 2021 20:55:41 +0200
8cffd2
Subject: [PATCH] ipa-kdb: mark test functions as static
8cffd2
8cffd2
No need to define missing prototypes to single use test functions.
8cffd2
8cffd2
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
8cffd2
Reviewed-By: Robbie Harwood <rharwood@redhat.com>
8cffd2
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
8cffd2
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
8cffd2
---
8cffd2
 daemons/ipa-kdb/tests/ipa_kdb_tests.c | 11 ++++-------
8cffd2
 1 file changed, 4 insertions(+), 7 deletions(-)
8cffd2
8cffd2
diff --git a/daemons/ipa-kdb/tests/ipa_kdb_tests.c b/daemons/ipa-kdb/tests/ipa_kdb_tests.c
8cffd2
index 7f1ae7f66e233d779433eff4e5f32fe7fafc3f02..1f94afe486fd09c497ee8b8aa16880d1840603d0 100644
8cffd2
--- a/daemons/ipa-kdb/tests/ipa_kdb_tests.c
8cffd2
+++ b/daemons/ipa-kdb/tests/ipa_kdb_tests.c
8cffd2
@@ -164,7 +164,7 @@ extern krb5_error_code filter_logon_info(krb5_context context,
8cffd2
                                   krb5_data realm,
8cffd2
                                   struct PAC_LOGON_INFO_CTR *info);
8cffd2
 
8cffd2
-void test_filter_logon_info(void **state)
8cffd2
+static void test_filter_logon_info(void **state)
8cffd2
 {
8cffd2
     krb5_error_code kerr;
8cffd2
     krb5_data realm = {KV5M_DATA, REALM_LEN, REALM};
8cffd2
@@ -299,10 +299,7 @@ void test_filter_logon_info(void **state)
8cffd2
 
8cffd2
 }
8cffd2
 
8cffd2
-extern void get_authz_data_types(krb5_context context, krb5_db_entry *entry,
8cffd2
-                                 bool *with_pac, bool *with_pad);
8cffd2
-
8cffd2
-void test_get_authz_data_types(void **state)
8cffd2
+static void test_get_authz_data_types(void **state)
8cffd2
 {
8cffd2
     bool with_pac;
8cffd2
     bool with_pad;
8cffd2
@@ -420,7 +417,7 @@ void test_get_authz_data_types(void **state)
8cffd2
     krb5_free_principal(test_ctx->krb5_ctx, non_nfs_princ);
8cffd2
 }
8cffd2
 
8cffd2
-void test_string_to_sid(void **state)
8cffd2
+static void test_string_to_sid(void **state)
8cffd2
 {
8cffd2
     int ret;
8cffd2
     struct dom_sid sid;
8cffd2
@@ -452,7 +449,7 @@ void test_string_to_sid(void **state)
8cffd2
     assert_memory_equal(&exp_sid, &sid, sizeof(struct dom_sid));
8cffd2
 }
8cffd2
 
8cffd2
-void test_dom_sid_string(void **state)
8cffd2
+static void test_dom_sid_string(void **state)
8cffd2
 {
8cffd2
     struct test_ctx *test_ctx;
8cffd2
     char *str_sid;
8cffd2
-- 
8cffd2
2.26.3
8cffd2