bbecb6
From 6ca119686aadfa72c0474f72758b63cd671952d4 Mon Sep 17 00:00:00 2001
bbecb6
From: Rob Crittenden <rcritten@redhat.com>
bbecb6
Date: Mon, 30 Jan 2023 12:00:03 -0500
bbecb6
Subject: [PATCH] tests: Add new ipa-ca error messages to
bbecb6
 IPADNSSystemRecordsCheck
bbecb6
bbecb6
freeipa-healthcheck changed some messages related to ipa-ca
bbecb6
DNS record validation in IPADNSSystemRecordsCheck. Include support
bbecb6
for it and retain backwards compatibility.
bbecb6
bbecb6
Fixes: https://pagure.io/freeipa/issue/9291
bbecb6
bbecb6
Signed-off-by: Rob Crittenden <rcritten@redhat.com>
bbecb6
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
bbecb6
---
bbecb6
 .../test_integration/test_ipahealthcheck.py   | 21 +++++++++++++------
bbecb6
 1 file changed, 15 insertions(+), 6 deletions(-)
bbecb6
bbecb6
diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py
bbecb6
index 94b0db0b7869e722955e232e1dddb26a2dc3d41e..47f64f2cb36904ef61211423de7cf33d21a199c3 100644
bbecb6
--- a/ipatests/test_integration/test_ipahealthcheck.py
bbecb6
+++ b/ipatests/test_integration/test_ipahealthcheck.py
bbecb6
@@ -1614,12 +1614,21 @@ class TestIpaHealthCheckWithoutDNS(IntegrationTest):
bbecb6
         Test checks the result of IPADNSSystemRecordsCheck
bbecb6
         when ipa-server is configured without DNS.
bbecb6
         """
bbecb6
-        expected_msgs = {
bbecb6
-            "Expected SRV record missing",
bbecb6
-            "Got {count} ipa-ca A records, expected {expected}",
bbecb6
-            "Got {count} ipa-ca AAAA records, expected {expected}",
bbecb6
-            "Expected URI record missing",
bbecb6
-        }
bbecb6
+        version = tasks.get_healthcheck_version(self.master)
bbecb6
+        if (parse_version(version) < parse_version('0.12')):
bbecb6
+            expected_msgs = {
bbecb6
+                "Expected SRV record missing",
bbecb6
+                "Got {count} ipa-ca A records, expected {expected}",
bbecb6
+                "Got {count} ipa-ca AAAA records, expected {expected}",
bbecb6
+                "Expected URI record missing",
bbecb6
+            }
bbecb6
+        else:
bbecb6
+            expected_msgs = {
bbecb6
+                "Expected SRV record missing",
bbecb6
+                "Unexpected ipa-ca address {ipaddr}",
bbecb6
+                "expected ipa-ca to contain {ipaddr} for {server}",
bbecb6
+                "Expected URI record missing",
bbecb6
+            }
bbecb6
 
bbecb6
         tasks.install_packages(self.master, HEALTHCHECK_PKG)
bbecb6
         returncode, data = run_healthcheck(
bbecb6
-- 
bbecb6
2.39.1
bbecb6