0fcb1e
From 42be04fe4ff317efe599dcbc2637f94ecc6fa220 Mon Sep 17 00:00:00 2001
0fcb1e
From: Alexander Bokovoy <abokovoy@redhat.com>
0fcb1e
Date: Mon, 21 Nov 2022 16:12:46 +0200
0fcb1e
Subject: [PATCH] updates: fix memberManager ACI to allow managers from a
0fcb1e
 specified group
0fcb1e
0fcb1e
The original implementation of the member manager added support for both
0fcb1e
user and group managers but left out upgrade scenario. This means when
0fcb1e
upgrading existing installation a manager whose rights defined by the
0fcb1e
group membership would not be able to add group members until the ACI is
0fcb1e
fixed.
0fcb1e
0fcb1e
Remove old ACI and add a full one during upgrade step.
0fcb1e
0fcb1e
Fixes: https://pagure.io/freeipa/issue/9286
0fcb1e
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
0fcb1e
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
0fcb1e
---
0fcb1e
 install/updates/20-aci.update | 6 ++++--
0fcb1e
 1 file changed, 4 insertions(+), 2 deletions(-)
0fcb1e
0fcb1e
diff --git a/install/updates/20-aci.update b/install/updates/20-aci.update
0fcb1e
index a168bb9573a9fbb9ff15f0b19bb8ec75b48d82a9..4a7ba137c4711aa3f8b064fdd482ffee76c59949 100644
0fcb1e
--- a/install/updates/20-aci.update
0fcb1e
+++ b/install/updates/20-aci.update
0fcb1e
@@ -141,11 +141,13 @@ add:aci:(targetattr = "usercertificate")(version 3.0;acl "selfservice:Users can
0fcb1e
 
0fcb1e
 # Allow member managers to modify members of user groups
0fcb1e
 dn: cn=groups,cn=accounts,$SUFFIX
0fcb1e
-add:aci: (targetattr = "member")(targetfilter = "(objectclass=ipaUserGroup)")(version 3.0; acl "Allow member managers to modify members of user groups"; allow (write) userattr = "memberManager#USERDN";)
0fcb1e
+remove:aci: (targetattr = "member")(targetfilter = "(objectclass=ipaUserGroup)")(version 3.0; acl "Allow member managers to modify members of user groups"; allow (write) userattr = "memberManager#USERDN";)
0fcb1e
+add:aci: (targetattr = "member")(targetfilter = "(objectclass=ipaUserGroup)")(version 3.0; acl "Allow member managers to modify members of user groups"; allow (write) userattr = "memberManager#USERDN" or userattr = "memberManager#GROUPDN";)
0fcb1e
 
0fcb1e
 # Allow member managers to modify members of host groups
0fcb1e
 dn: cn=hostgroups,cn=accounts,$SUFFIX
0fcb1e
-add:aci: (targetattr = "member")(targetfilter = "(objectclass=ipaHostGroup)")(version 3.0; acl "Allow member managers to modify members of host groups"; allow (write) userattr = "memberManager#USERDN";)
0fcb1e
+remove:aci: (targetattr = "member")(targetfilter = "(objectclass=ipaHostGroup)")(version 3.0; acl "Allow member managers to modify members of host groups"; allow (write) userattr = "memberManager#USERDN";)
0fcb1e
+add:aci: (targetattr = "member")(targetfilter = "(objectclass=ipaHostGroup)")(version 3.0; acl "Allow member managers to modify members of host groups"; allow (write) userattr = "memberManager#USERDN" or userattr = "memberManager#GROUPDN";)
0fcb1e
 
0fcb1e
 # Hosts can add and delete their own services
0fcb1e
 dn: cn=services,cn=accounts,$SUFFIX
0fcb1e
-- 
0fcb1e
2.38.1
0fcb1e