0943f8
Index: modules/aaa/mod_authz_owner.c
0943f8
===================================================================
0943f8
--- a/modules/aaa/mod_authz_owner.c	(revision 1420183)
0943f8
+++ b/modules/aaa/mod_authz_owner.c	(revision 1420184)
0943f8
@@ -28,9 +28,8 @@
0943f8
 #include "http_request.h"
0943f8
 
0943f8
 #include "mod_auth.h"
0943f8
+#include "mod_authz_owner.h"
0943f8
 
0943f8
-APR_DECLARE_OPTIONAL_FN(char*, authz_owner_get_file_group, (request_rec *r));
0943f8
-
0943f8
 static const command_rec authz_owner_cmds[] =
0943f8
 {
0943f8
     {NULL}
0943f8
Index: modules/aaa/mod_authz_owner.h
0943f8
===================================================================
0943f8
--- a/modules/aaa/mod_authz_owner.h	(revision 0)
0943f8
+++ b/modules/aaa/mod_authz_owner.h	(revision 1420184)
0943f8
@@ -0,0 +1,27 @@
0943f8
+/* Licensed to the Apache Software Foundation (ASF) under one or more
0943f8
+ * contributor license agreements.  See the NOTICE file distributed with
0943f8
+ * this work for additional information regarding copyright ownership.
0943f8
+ * The ASF licenses this file to You under the Apache License, Version 2.0
0943f8
+ * (the "License"); you may not use this file except in compliance with
0943f8
+ * the License.  You may obtain a copy of the License at
0943f8
+ *
0943f8
+ *     http://www.apache.org/licenses/LICENSE-2.0
0943f8
+ *
0943f8
+ * Unless required by applicable law or agreed to in writing, software
0943f8
+ * distributed under the License is distributed on an "AS IS" BASIS,
0943f8
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
0943f8
+ * See the License for the specific language governing permissions and
0943f8
+ * limitations under the License.
0943f8
+ */
0943f8
+
0943f8
+#ifndef MOD_AUTHZ_OWNER_H
0943f8
+#define MOD_AUTHZ_OWNER_H
0943f8
+
0943f8
+#include "http_request.h"
0943f8
+
0943f8
+/* mod_authz_owner exports an optional function which retrieves the
0943f8
+ * group name of the file identified by r->filename, if available, or
0943f8
+ * else returns NULL. */
0943f8
+APR_DECLARE_OPTIONAL_FN(char*, authz_owner_get_file_group, (request_rec *r));
0943f8
+
0943f8
+#endif /* MOD_AUTHZ_OWNER_H */
0943f8
Index: modules/aaa/mod_authz_groupfile.c
0943f8
===================================================================
0943f8
--- a/modules/aaa/mod_authz_groupfile.c	(revision 1420183)
0943f8
+++ b/modules/aaa/mod_authz_groupfile.c	(revision 1420184)
0943f8
@@ -55,13 +55,12 @@
0943f8
 #include "util_varbuf.h"
0943f8
 
0943f8
 #include "mod_auth.h"
0943f8
+#include "mod_authz_owner.h"
0943f8
 
0943f8
 typedef struct {
0943f8
     char *groupfile;
0943f8
 } authz_groupfile_config_rec;
0943f8
 
0943f8
-APR_DECLARE_OPTIONAL_FN(char*, authz_owner_get_file_group, (request_rec *r));
0943f8
-
0943f8
 static void *create_authz_groupfile_dir_config(apr_pool_t *p, char *d)
0943f8
 {
0943f8
     authz_groupfile_config_rec *conf = apr_palloc(p, sizeof(*conf));
0943f8
@@ -200,7 +199,7 @@
0943f8
     return AUTHZ_DENIED;
0943f8
 }
0943f8
 
0943f8
-APR_OPTIONAL_FN_TYPE(authz_owner_get_file_group) *authz_owner_get_file_group;
0943f8
+static APR_OPTIONAL_FN_TYPE(authz_owner_get_file_group) *authz_owner_get_file_group;
0943f8
 
0943f8
 static authz_status filegroup_check_authorization(request_rec *r,
0943f8
                                                   const char *require_args,
0943f8
@@ -279,10 +278,14 @@
0943f8
     NULL,
0943f8
 };
0943f8
 
0943f8
-static void register_hooks(apr_pool_t *p)
0943f8
+
0943f8
+static void authz_groupfile_getfns(void)
0943f8
 {
0943f8
     authz_owner_get_file_group = APR_RETRIEVE_OPTIONAL_FN(authz_owner_get_file_group);
0943f8
+}
0943f8
 
0943f8
+static void register_hooks(apr_pool_t *p)
0943f8
+{
0943f8
     ap_register_auth_provider(p, AUTHZ_PROVIDER_GROUP, "group",
0943f8
                               AUTHZ_PROVIDER_VERSION,
0943f8
                               &authz_group_provider,
0943f8
@@ -291,6 +294,7 @@
0943f8
                               AUTHZ_PROVIDER_VERSION,
0943f8
                               &authz_filegroup_provider,
0943f8
                               AP_AUTH_INTERNAL_PER_CONF);
0943f8
+    ap_hook_optional_fn_retrieve(authz_groupfile_getfns, NULL, NULL, APR_HOOK_MIDDLE);
0943f8
 }
0943f8
 
0943f8
 AP_DECLARE_MODULE(authz_groupfile) =
0943f8
Index: modules/aaa/mod_authz_dbm.c
0943f8
===================================================================
0943f8
--- a/modules/aaa/mod_authz_dbm.c	(revision 1420183)
0943f8
+++ b/modules/aaa/mod_authz_dbm.c	(revision 1420184)
0943f8
@@ -29,6 +29,7 @@
0943f8
 #include "http_request.h"   /* for ap_hook_(check_user_id | auth_checker)*/
0943f8
 
0943f8
 #include "mod_auth.h"
0943f8
+#include "mod_authz_owner.h"
0943f8
 
0943f8
 typedef struct {
0943f8
     const char *grpfile;
0943f8
@@ -35,9 +36,7 @@
0943f8
     const char *dbmtype;
0943f8
 } authz_dbm_config_rec;
0943f8
 
0943f8
-APR_DECLARE_OPTIONAL_FN(char*, authz_owner_get_file_group, (request_rec *r));
0943f8
 
0943f8
-
0943f8
 /* This should go into APR; perhaps with some nice
0943f8
  * caching/locking/flocking of the open dbm file.
0943f8
  */
0943f8
@@ -199,7 +198,7 @@
0943f8
     return AUTHZ_DENIED;
0943f8
 }
0943f8
 
0943f8
-APR_OPTIONAL_FN_TYPE(authz_owner_get_file_group) *authz_owner_get_file_group;
0943f8
+static APR_OPTIONAL_FN_TYPE(authz_owner_get_file_group) *authz_owner_get_file_group;
0943f8
 
0943f8
 static authz_status dbmfilegroup_check_authorization(request_rec *r,
0943f8
                                                      const char *require_args,
0943f8
@@ -279,11 +278,13 @@
0943f8
     NULL,
0943f8
 };
0943f8
 
0943f8
+static void authz_dbm_getfns(void)
0943f8
+{
0943f8
+    authz_owner_get_file_group = APR_RETRIEVE_OPTIONAL_FN(authz_owner_get_file_group);
0943f8
+}
0943f8
 
0943f8
 static void register_hooks(apr_pool_t *p)
0943f8
 {
0943f8
-    authz_owner_get_file_group = APR_RETRIEVE_OPTIONAL_FN(authz_owner_get_file_group);
0943f8
-
0943f8
     ap_register_auth_provider(p, AUTHZ_PROVIDER_GROUP, "dbm-group",
0943f8
                               AUTHZ_PROVIDER_VERSION,
0943f8
                               &authz_dbmgroup_provider,
0943f8
@@ -292,6 +293,7 @@
0943f8
                               AUTHZ_PROVIDER_VERSION,
0943f8
                               &authz_dbmfilegroup_provider,
0943f8
                               AP_AUTH_INTERNAL_PER_CONF);
0943f8
+    ap_hook_optional_fn_retrieve(authz_dbm_getfns, NULL, NULL, APR_HOOK_MIDDLE);
0943f8
 }
0943f8
 
0943f8
 AP_DECLARE_MODULE(authz_dbm) =