8335b1
--- a/modules/generators/mod_cgid.c	2014/07/14 20:16:45	1610511
8335b1
+++ b/modules/generators/mod_cgid.c	2014/07/14 20:18:26	1610512
8335b1
@@ -97,6 +97,10 @@
8335b1
 static pid_t parent_pid;
8335b1
 static ap_unix_identity_t empty_ugid = { (uid_t)-1, (gid_t)-1, -1 };
8335b1
 
8335b1
+typedef struct { 
8335b1
+    apr_interval_time_t timeout;
8335b1
+} cgid_dirconf;
8335b1
+
8335b1
 /* The APR other-child API doesn't tell us how the daemon exited
8335b1
  * (SIGSEGV vs. exit(1)).  The other-child maintenance function
8335b1
  * needs to decide whether to restart the daemon after a failure
8335b1
@@ -968,7 +972,14 @@
8335b1
     return overrides->logname ? overrides : base;
8335b1
 }
8335b1
 
8335b1
+static void *create_cgid_dirconf(apr_pool_t *p, char *dummy)
8335b1
+{
8335b1
+    cgid_dirconf *c = (cgid_dirconf *) apr_pcalloc(p, sizeof(cgid_dirconf));
8335b1
+    return c;
8335b1
+}
8335b1
+
8335b1
 static const char *set_scriptlog(cmd_parms *cmd, void *dummy, const char *arg)
8335b1
+
8335b1
 {
8335b1
     server_rec *s = cmd->server;
8335b1
     cgid_server_conf *conf = ap_get_module_config(s->module_config,
8335b1
@@ -1021,7 +1032,16 @@
8335b1
 
8335b1
     return NULL;
8335b1
 }
8335b1
+static const char *set_script_timeout(cmd_parms *cmd, void *dummy, const char *arg)
8335b1
+{
8335b1
+    cgid_dirconf *dc = dummy;
8335b1
 
8335b1
+    if (ap_timeout_parameter_parse(arg, &dc->timeout, "s") != APR_SUCCESS) { 
8335b1
+        return "CGIDScriptTimeout has wrong format";
8335b1
+    }
8335b1
+ 
8335b1
+    return NULL;
8335b1
+}
8335b1
 static const command_rec cgid_cmds[] =
8335b1
 {
8335b1
     AP_INIT_TAKE1("ScriptLog", set_scriptlog, NULL, RSRC_CONF,
8335b1
@@ -1033,6 +1053,10 @@
8335b1
     AP_INIT_TAKE1("ScriptSock", set_script_socket, NULL, RSRC_CONF,
8335b1
                   "the name of the socket to use for communication with "
8335b1
                   "the cgi daemon."),
8335b1
+    AP_INIT_TAKE1("CGIDScriptTimeout", set_script_timeout, NULL, RSRC_CONF | ACCESS_CONF,
8335b1
+                  "The amount of time to wait between successful reads from "
8335b1
+                  "the CGI script, in seconds."),
8335b1
+                  
8335b1
     {NULL}
8335b1
 };
8335b1
 
8335b1
@@ -1356,12 +1380,16 @@
8335b1
     apr_file_t *tempsock;
8335b1
     struct cleanup_script_info *info;
8335b1
     apr_status_t rv;
8335b1
+    cgid_dirconf *dc;
8335b1
 
8335b1
     if (strcmp(r->handler, CGI_MAGIC_TYPE) && strcmp(r->handler, "cgi-script")) {
8335b1
         return DECLINED;
8335b1
     }
8335b1
 
8335b1
     conf = ap_get_module_config(r->server->module_config, &cgid_module);
8335b1
+    dc = ap_get_module_config(r->per_dir_config, &cgid_module);
8335b1
+
8335b1
+    
8335b1
     is_included = !strcmp(r->protocol, "INCLUDED");
8335b1
 
8335b1
     if ((argv0 = strrchr(r->filename, '/')) != NULL) {
8335b1
@@ -1441,6 +1469,12 @@
8335b1
      */
8335b1
 
8335b1
     apr_os_pipe_put_ex(&tempsock, &sd, 1, r->pool);
8335b1
+    if (dc->timeout > 0) { 
8335b1
+        apr_file_pipe_timeout_set(tempsock, dc->timeout);
8335b1
+    }
8335b1
+    else { 
8335b1
+        apr_file_pipe_timeout_set(tempsock, r->server->timeout);
8335b1
+    }
8335b1
     apr_pool_cleanup_kill(r->pool, (void *)((long)sd), close_unix_socket);
8335b1
 
8335b1
     /* Transfer any put/post args, CERN style...
8335b1
@@ -1517,6 +1551,10 @@
8335b1
             if (rv != APR_SUCCESS) {
8335b1
                 /* silly script stopped reading, soak up remaining message */
8335b1
                 child_stopped_reading = 1;
8335b1
+                ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, APLOGNO(02651)
8335b1
+                              "Error writing request body to script %s", 
8335b1
+                              r->filename);
8335b1
+
8335b1
             }
8335b1
         }
8335b1
         apr_brigade_cleanup(bb);
8335b1
@@ -1610,7 +1648,13 @@
8335b1
             return HTTP_MOVED_TEMPORARILY;
8335b1
         }
8335b1
 
8335b1
-        ap_pass_brigade(r->output_filters, bb);
8335b1
+        rv = ap_pass_brigade(r->output_filters, bb);
8335b1
+        if (rv != APR_SUCCESS) { 
8335b1
+            /* APLOG_ERR because the core output filter message is at error,
8335b1
+             * but doesn't know it's passing CGI output 
8335b1
+             */
8335b1
+            ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, APLOGNO(02550) "Failed to flush CGI output to client");
8335b1
+        }
8335b1
     }
8335b1
 
8335b1
     if (nph) {
8335b1
@@ -1741,6 +1785,8 @@
8335b1
     request_rec *r = f->r;
8335b1
     cgid_server_conf *conf = ap_get_module_config(r->server->module_config,
8335b1
                                                   &cgid_module);
8335b1
+    cgid_dirconf *dc = ap_get_module_config(r->per_dir_config, &cgid_module);
8335b1
+
8335b1
     struct cleanup_script_info *info;
8335b1
 
8335b1
     add_ssi_vars(r);
8335b1
@@ -1770,6 +1816,13 @@
8335b1
      * get rid of the cleanup we registered when we created the socket.
8335b1
      */
8335b1
     apr_os_pipe_put_ex(&tempsock, &sd, 1, r->pool);
8335b1
+    if (dc->timeout > 0) {
8335b1
+        apr_file_pipe_timeout_set(tempsock, dc->timeout);
8335b1
+    }
8335b1
+    else {
8335b1
+        apr_file_pipe_timeout_set(tempsock, r->server->timeout);
8335b1
+    }
8335b1
+
8335b1
     apr_pool_cleanup_kill(r->pool, (void *)((long)sd), close_unix_socket);
8335b1
 
8335b1
     APR_BRIGADE_INSERT_TAIL(bb, apr_bucket_pipe_create(tempsock,
8335b1
@@ -1875,7 +1928,7 @@
8335b1
 
8335b1
 AP_DECLARE_MODULE(cgid) = {
8335b1
     STANDARD20_MODULE_STUFF,
8335b1
-    NULL, /* dir config creater */
8335b1
+    create_cgid_dirconf, /* dir config creater */
8335b1
     NULL, /* dir merger --- default is to override */
8335b1
     create_cgid_config, /* server config */
8335b1
     merge_cgid_config, /* merge server config */