|
|
8b0621 |
diff --git a/docs/manual/mod/mod_session.html.en b/docs/manual/mod/mod_session.html.en
|
|
|
8b0621 |
index 6834f8e..9f8301f 100644
|
|
|
8b0621 |
--- a/docs/manual/mod/mod_session.html.en
|
|
|
8b0621 |
+++ b/docs/manual/mod/mod_session.html.en
|
|
|
8b0621 |
@@ -82,6 +82,7 @@
|
|
|
8b0621 |
SessionHeader
|
|
|
8b0621 |
SessionInclude
|
|
|
8b0621 |
SessionMaxAge
|
|
|
8b0621 |
+ SessionExpiryUpdateInterval
|
|
|
8b0621 |
|
|
|
8b0621 |
Bugfix checklistSee also
|
|
|
8b0621 |
|
|
|
8b0621 |
@@ -482,6 +483,37 @@ AuthName realm
|
|
|
8b0621 |
|
|
|
8b0621 |
Setting the maxage to zero disables session expiry.
|
|
|
8b0621 |
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+Description:Define the number of seconds a session's expiry may change without the session being updated
|
|
|
8b0621 |
+Syntax:SessionExpiryUpdateInterval interval
|
|
|
8b0621 |
+Default:SessionExpiryUpdateInterval 0 (always update)
|
|
|
8b0621 |
+Context:server config, virtual host, directory, .htaccess
|
|
|
8b0621 |
+Module:mod_session
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+ The SessionExpiryUpdateInterval directive allows
|
|
|
8b0621 |
+ sessions to avoid the cost associated with writing the session each request
|
|
|
8b0621 |
+ when only the expiry time has changed. This can be used to make a website
|
|
|
8b0621 |
+ more efficient or reduce load on a database when using
|
|
|
8b0621 |
+ <module>mod_session_dbd</module>. The session is always written if the data
|
|
|
8b0621 |
+ stored in the session has changed or the expiry has changed by more than the
|
|
|
8b0621 |
+ configured interval.
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+ Setting the interval to zero disables this directive, and the session
|
|
|
8b0621 |
+ expiry is refreshed for each request.
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+ This directive only has an effect when combined with SessionMaxAge to enable session
|
|
|
8b0621 |
+ expiry. Sessions without an expiry are only written when the data stored in
|
|
|
8b0621 |
+ the session has changed.
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+ Warning
|
|
|
8b0621 |
+ Because the session expiry may not be refreshed with each request, it's
|
|
|
8b0621 |
+ possible for sessions to expire up to interval seconds early.
|
|
|
8b0621 |
+ Using a small interval usually provides sufficient savings while having a
|
|
|
8b0621 |
+ minimal effect on expiry resolution.
|
|
|
8b0621 |
+
|
|
|
8b0621 |
|
|
|
8b0621 |
|
|
|
8b0621 |
|
|
|
8b0621 |
diff --git a/modules/session/mod_session.c b/modules/session/mod_session.c
|
|
|
8b0621 |
index d517020..10e6396 100644
|
|
|
8b0621 |
--- a/modules/session/mod_session.c
|
|
|
8b0621 |
+++ b/modules/session/mod_session.c
|
|
|
8b0621 |
@@ -177,6 +177,7 @@ static apr_status_t ap_session_save(request_rec * r, session_rec * z)
|
|
|
8b0621 |
{
|
|
|
8b0621 |
if (z) {
|
|
|
8b0621 |
apr_time_t now = apr_time_now();
|
|
|
8b0621 |
+ apr_time_t initialExpiry = z->expiry;
|
|
|
8b0621 |
int rv = 0;
|
|
|
8b0621 |
|
|
|
8b0621 |
session_dir_conf *dconf = ap_get_module_config(r->per_dir_config,
|
|
|
8b0621 |
@@ -207,6 +208,17 @@ static apr_status_t ap_session_save(request_rec * r, session_rec * z)
|
|
|
8b0621 |
z->expiry = now + z->maxage * APR_USEC_PER_SEC;
|
|
|
8b0621 |
}
|
|
|
8b0621 |
|
|
|
8b0621 |
+ /* don't save if the only change is the expiry by a small amount */
|
|
|
8b0621 |
+ if (!z->dirty && dconf->expiry_update_time
|
|
|
8b0621 |
+ && (z->expiry - initialExpiry < dconf->expiry_update_time)) {
|
|
|
8b0621 |
+ return APR_SUCCESS;
|
|
|
8b0621 |
+ }
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+ /* also don't save sessions that didn't change at all */
|
|
|
8b0621 |
+ if (!z->dirty && !z->maxage) {
|
|
|
8b0621 |
+ return APR_SUCCESS;
|
|
|
8b0621 |
+ }
|
|
|
8b0621 |
+
|
|
|
8b0621 |
/* encode the session */
|
|
|
8b0621 |
rv = ap_run_session_encode(r, z);
|
|
|
8b0621 |
if (OK != rv) {
|
|
|
8b0621 |
@@ -553,6 +565,10 @@ static void *merge_session_dir_config(apr_pool_t * p, void *basev, void *addv)
|
|
|
8b0621 |
new->env_set = add->env_set || base->env_set;
|
|
|
8b0621 |
new->includes = apr_array_append(p, base->includes, add->includes);
|
|
|
8b0621 |
new->excludes = apr_array_append(p, base->excludes, add->excludes);
|
|
|
8b0621 |
+ new->expiry_update_time = (add->expiry_update_set == 0)
|
|
|
8b0621 |
+ ? base->expiry_update_time
|
|
|
8b0621 |
+ : add->expiry_update_time;
|
|
|
8b0621 |
+ new->expiry_update_set = add->expiry_update_set || base->expiry_update_set;
|
|
|
8b0621 |
|
|
|
8b0621 |
return new;
|
|
|
8b0621 |
}
|
|
|
8b0621 |
@@ -622,6 +638,21 @@ static const char *add_session_exclude(cmd_parms * cmd, void *dconf, const char
|
|
|
8b0621 |
return NULL;
|
|
|
8b0621 |
}
|
|
|
8b0621 |
|
|
|
8b0621 |
+static const char *
|
|
|
8b0621 |
+ set_session_expiry_update(cmd_parms * parms, void *dconf, const char *arg)
|
|
|
8b0621 |
+{
|
|
|
8b0621 |
+ session_dir_conf *conf = dconf;
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+ conf->expiry_update_time = atoi(arg);
|
|
|
8b0621 |
+ if (conf->expiry_update_time < 0) {
|
|
|
8b0621 |
+ return "SessionExpiryUpdateInterval must be positive or nul";
|
|
|
8b0621 |
+ }
|
|
|
8b0621 |
+ conf->expiry_update_time = apr_time_from_sec(conf->expiry_update_time);
|
|
|
8b0621 |
+ conf->expiry_update_set = 1;
|
|
|
8b0621 |
+
|
|
|
8b0621 |
+ return NULL;
|
|
|
8b0621 |
+}
|
|
|
8b0621 |
+
|
|
|
8b0621 |
|
|
|
8b0621 |
static const command_rec session_cmds[] =
|
|
|
8b0621 |
{
|
|
|
8b0621 |
@@ -637,6 +668,9 @@ static const command_rec session_cmds[] =
|
|
|
8b0621 |
"URL prefixes to include in the session. Defaults to all URLs"),
|
|
|
8b0621 |
AP_INIT_TAKE1("SessionExclude", add_session_exclude, NULL, RSRC_CONF|OR_AUTHCFG,
|
|
|
8b0621 |
"URL prefixes to exclude from the session. Defaults to no URLs"),
|
|
|
8b0621 |
+ AP_INIT_TAKE1("SessionExpiryUpdateInterval", set_session_expiry_update, NULL, RSRC_CONF|OR_AUTHCFG,
|
|
|
8b0621 |
+ "time interval for which a session's expiry time may change "
|
|
|
8b0621 |
+ "without having to be rewritten. Zero to disable"),
|
|
|
8b0621 |
{NULL}
|
|
|
8b0621 |
};
|
|
|
8b0621 |
|
|
|
8b0621 |
diff --git a/modules/session/mod_session.h b/modules/session/mod_session.h
|
|
|
8b0621 |
index a6dd5e9..bdeb532 100644
|
|
|
8b0621 |
--- a/modules/session/mod_session.h
|
|
|
8b0621 |
+++ b/modules/session/mod_session.h
|
|
|
8b0621 |
@@ -115,6 +115,9 @@ typedef struct {
|
|
|
8b0621 |
* URLs included if empty */
|
|
|
8b0621 |
apr_array_header_t *excludes; /* URL prefixes to be excluded. No
|
|
|
8b0621 |
* URLs excluded if empty */
|
|
|
8b0621 |
+ apr_time_t expiry_update_time; /* seconds the session expiry may change and
|
|
|
8b0621 |
+ * not have to be rewritten */
|
|
|
8b0621 |
+ int expiry_update_set;
|
|
|
8b0621 |
} session_dir_conf;
|
|
|
8b0621 |
|
|
|
8b0621 |
/**
|
|
|
8b0621 |
diff --git a/modules/session/mod_session_cookie.c b/modules/session/mod_session_cookie.c
|
|
|
8b0621 |
index 6a02322..4aa75e4 100644
|
|
|
8b0621 |
--- a/modules/session/mod_session_cookie.c
|
|
|
8b0621 |
+++ b/modules/session/mod_session_cookie.c
|
|
|
8b0621 |
@@ -60,9 +60,6 @@ static apr_status_t session_cookie_save(request_rec * r, session_rec * z)
|
|
|
8b0621 |
session_cookie_dir_conf *conf = ap_get_module_config(r->per_dir_config,
|
|
|
8b0621 |
&session_cookie_module);
|
|
|
8b0621 |
|
|
|
8b0621 |
- /* don't cache auth protected pages */
|
|
|
8b0621 |
- apr_table_addn(r->headers_out, "Cache-Control", "no-cache");
|
|
|
8b0621 |
-
|
|
|
8b0621 |
/* create RFC2109 compliant cookie */
|
|
|
8b0621 |
if (conf->name_set) {
|
|
|
8b0621 |
if (z->encoded && z->encoded[0]) {
|
|
|
8b0621 |
@@ -162,6 +159,9 @@ static apr_status_t session_cookie_load(request_rec * r, session_rec ** z)
|
|
|
8b0621 |
/* put the session in the notes so we don't have to parse it again */
|
|
|
8b0621 |
apr_table_setn(m->notes, note, (char *)zz);
|
|
|
8b0621 |
|
|
|
8b0621 |
+ /* don't cache auth protected pages */
|
|
|
8b0621 |
+ apr_table_addn(r->headers_out, "Cache-Control", "no-cache, private");
|
|
|
8b0621 |
+
|
|
|
8b0621 |
return OK;
|
|
|
8b0621 |
|
|
|
8b0621 |
}
|
|
|
8b0621 |
diff --git a/modules/session/mod_session_dbd.c b/modules/session/mod_session_dbd.c
|
|
|
8b0621 |
index 0be7306..f683da2 100644
|
|
|
8b0621 |
--- a/modules/session/mod_session_dbd.c
|
|
|
8b0621 |
+++ b/modules/session/mod_session_dbd.c
|
|
|
8b0621 |
@@ -245,6 +245,9 @@ static apr_status_t session_dbd_load(request_rec * r, session_rec ** z)
|
|
|
8b0621 |
/* put the session in the notes so we don't have to parse it again */
|
|
|
8b0621 |
apr_table_setn(m->notes, note, (char *)zz);
|
|
|
8b0621 |
|
|
|
8b0621 |
+ /* don't cache pages with a session */
|
|
|
8b0621 |
+ apr_table_addn(r->headers_out, "Cache-Control", "no-cache, private");
|
|
|
8b0621 |
+
|
|
|
8b0621 |
return OK;
|
|
|
8b0621 |
|
|
|
8b0621 |
}
|
|
|
8b0621 |
@@ -409,9 +412,6 @@ static apr_status_t session_dbd_save(request_rec * r, session_rec * z)
|
|
|
8b0621 |
if (conf->name_set || conf->name2_set) {
|
|
|
8b0621 |
char *oldkey = NULL, *newkey = NULL;
|
|
|
8b0621 |
|
|
|
8b0621 |
- /* don't cache pages with a session */
|
|
|
8b0621 |
- apr_table_addn(r->headers_out, "Cache-Control", "no-cache");
|
|
|
8b0621 |
-
|
|
|
8b0621 |
/* if the session is new or changed, make a new session ID */
|
|
|
8b0621 |
if (z->uuid) {
|
|
|
8b0621 |
oldkey = apr_pcalloc(r->pool, APR_UUID_FORMATTED_LENGTH + 1);
|
|
|
8b0621 |
@@ -458,7 +458,7 @@ static apr_status_t session_dbd_save(request_rec * r, session_rec * z)
|
|
|
8b0621 |
else if (conf->peruser) {
|
|
|
8b0621 |
|
|
|
8b0621 |
/* don't cache pages with a session */
|
|
|
8b0621 |
- apr_table_addn(r->headers_out, "Cache-Control", "no-cache");
|
|
|
8b0621 |
+ apr_table_addn(r->headers_out, "Cache-Control", "no-cache, private");
|
|
|
8b0621 |
|
|
|
8b0621 |
if (r->user) {
|
|
|
8b0621 |
ret = dbd_save(r, r->user, r->user, z->encoded, z->expiry);
|