--- gvfs-1.16.4/daemon/gvfsbackendmtp.c.fix-mtp-crashes 2013-12-06 19:28:25.533794671 +0100 +++ gvfs-1.16.4/daemon/gvfsbackendmtp.c 2013-12-06 19:34:20.805997988 +0100 @@ -125,6 +125,18 @@ typedef struct { } RWHandle; +#define FAIL_DURING_UNMOUNT() \ + if (g_atomic_int_get (&G_VFS_BACKEND_MTP(backend)->unmount_started)) { \ + DEBUG ("(I) aborting due to unmount"); \ + g_vfs_job_failed_literal (G_VFS_JOB (job), \ + G_IO_ERROR, G_IO_ERROR_CLOSED, \ + _("The connection is closed")); \ + goto exit; \ + } + + + + /************************************************ * Initialization ************************************************/ @@ -863,6 +875,8 @@ do_enumerate (GVfsBackend *backend, g_mutex_lock (&G_VFS_BACKEND_MTP (backend)->mutex); + FAIL_DURING_UNMOUNT(); + LIBMTP_mtpdevice_t *device; device = op_backend->device; @@ -1018,6 +1032,8 @@ do_query_info (GVfsBackend *backend, DEBUG ("(I) do_query_info (filename = %s) ", filename); g_mutex_lock (&G_VFS_BACKEND_MTP (backend)->mutex); + FAIL_DURING_UNMOUNT(); + gchar **elements = g_strsplit_set (filename, "/", -1); unsigned int ne = g_strv_length (elements); @@ -1094,6 +1110,8 @@ do_query_fs_info (GVfsBackend *backend, gchar **elements = g_strsplit_set (filename, "/", -1); unsigned int ne = g_strv_length (elements); + FAIL_DURING_UNMOUNT(); + LIBMTP_mtpdevice_t *device; device = G_VFS_BACKEND_MTP (backend)->device; @@ -1161,6 +1179,8 @@ do_make_directory (GVfsBackend *backend, gchar **elements = g_strsplit_set (filename, "/", -1); unsigned int ne = g_strv_length (elements); + FAIL_DURING_UNMOUNT(); + if (ne < 3) { g_vfs_job_failed_literal (G_VFS_JOB (job), G_IO_ERROR, G_IO_ERROR_FAILED, @@ -1217,6 +1237,8 @@ do_pull (GVfsBackend *backend, gchar **elements = g_strsplit_set (source, "/", -1); unsigned int ne = g_strv_length (elements); + FAIL_DURING_UNMOUNT(); + if (ne < 3) { g_vfs_job_failed_literal (G_VFS_JOB (job), G_IO_ERROR, G_IO_ERROR_NOT_REGULAR_FILE, @@ -1292,6 +1314,8 @@ do_push (GVfsBackend *backend, gchar **elements = g_strsplit_set (destination, "/", -1); unsigned int ne = g_strv_length (elements); + FAIL_DURING_UNMOUNT(); + if (ne < 3) { g_vfs_job_failed_literal (G_VFS_JOB (job), G_IO_ERROR, G_IO_ERROR_NOT_REGULAR_FILE, @@ -1390,6 +1414,8 @@ do_delete (GVfsBackend *backend, gchar **elements = g_strsplit_set (filename, "/", -1); unsigned int ne = g_strv_length (elements); + FAIL_DURING_UNMOUNT(); + if (ne < 3) { g_vfs_job_failed_literal (G_VFS_JOB (job), G_IO_ERROR, G_IO_ERROR_FAILED, @@ -1428,6 +1454,8 @@ do_set_display_name (GVfsBackend *backen DEBUG ("(I) do_set_display_name '%s' --> '%s' ", filename, display_name); g_mutex_lock (&G_VFS_BACKEND_MTP (backend)->mutex); + FAIL_DURING_UNMOUNT(); + gchar **elements = g_strsplit_set (filename, "/", -1); unsigned int ne = g_strv_length (elements); @@ -1531,6 +1559,8 @@ do_open_icon_for_read (GVfsBackend *back DEBUG ("(I) do_open_icon_for_read (%s)", icon_id); g_mutex_lock (&G_VFS_BACKEND_MTP (backend)->mutex); + FAIL_DURING_UNMOUNT(); + guint id = strtol (icon_id, NULL, 10); if (id > 0) { @@ -1606,6 +1636,8 @@ do_seek_on_read (GVfsBackend *backend, DEBUG ("(I) do_seek_on_read (%u %lu %ld %u)", id, old_offset, offset, type); g_mutex_lock (&G_VFS_BACKEND_MTP (backend)->mutex); + FAIL_DURING_UNMOUNT(); + if (type == G_SEEK_END) { offset = size + offset; } else if (type == G_SEEK_CUR) { @@ -1644,6 +1676,8 @@ do_read (GVfsBackend *backend, DEBUG ("(I) do_read (%u %lu %lu)", id, offset, bytes_requested); g_mutex_lock (&G_VFS_BACKEND_MTP (backend)->mutex); + FAIL_DURING_UNMOUNT(); + uint32_t actual; if (handle->handle_type == HANDLE_FILE) { unsigned char *temp;