|
 |
25dd04 |
From 3709475e8d743bf3c4e479900918ee87f938a2e3 Mon Sep 17 00:00:00 2001
|
|
|
25dd04 |
From: Matthias Clasen <mclasen@redhat.com>
|
|
|
25dd04 |
Date: Fri, 17 Jul 2015 15:54:40 -0400
|
|
|
25dd04 |
Subject: [PATCH 3/7] gtkicontheme: Check a return value
|
|
|
25dd04 |
|
|
|
25dd04 |
We were already looking at the error anyway, but rewriting things
|
|
|
25dd04 |
this way lets coverity see the light.
|
|
|
25dd04 |
---
|
|
|
25dd04 |
gtk/gtkicontheme.c | 5 ++---
|
|
|
25dd04 |
1 file changed, 2 insertions(+), 3 deletions(-)
|
|
|
25dd04 |
|
|
|
25dd04 |
diff --git a/gtk/gtkicontheme.c b/gtk/gtkicontheme.c
|
|
|
25dd04 |
index deb7035..68e33e2 100644
|
|
|
25dd04 |
--- a/gtk/gtkicontheme.c
|
|
|
25dd04 |
+++ b/gtk/gtkicontheme.c
|
|
|
25dd04 |
@@ -1154,8 +1154,7 @@ insert_theme (GtkIconTheme *icon_theme,
|
|
|
25dd04 |
{
|
|
|
25dd04 |
theme_file = g_key_file_new ();
|
|
|
25dd04 |
g_key_file_set_list_separator (theme_file, ',');
|
|
|
25dd04 |
- g_key_file_load_from_file (theme_file, path, 0, &error);
|
|
|
25dd04 |
- if (error)
|
|
|
25dd04 |
+ if (!g_key_file_load_from_file (theme_file, path, 0, &error))
|
|
|
25dd04 |
{
|
|
|
25dd04 |
g_key_file_free (theme_file);
|
|
|
25dd04 |
theme_file = NULL;
|
|
|
25dd04 |
@@ -4093,7 +4092,7 @@ load_icon_thread (GTask *task,
|
|
|
25dd04 |
{
|
|
|
25dd04 |
GtkIconInfo *dup = task_data;
|
|
|
25dd04 |
|
|
|
25dd04 |
- icon_info_ensure_scale_and_pixbuf (dup);
|
|
|
25dd04 |
+ (void)icon_info_ensure_scale_and_pixbuf (dup);
|
|
|
25dd04 |
g_task_return_pointer (task, NULL, NULL);
|
|
|
25dd04 |
}
|
|
|
25dd04 |
|
|
|
25dd04 |
--
|
|
|
25dd04 |
2.4.5
|
|
|
25dd04 |
|