|
 |
249a24 |
From 4b202fd478ccbdb504c9c2a52b5ef4ddcc50838f Mon Sep 17 00:00:00 2001
|
|
|
249a24 |
From: "Daniel P. Berrange" <berrange@redhat.com>
|
|
|
249a24 |
Date: Tue, 11 Apr 2017 10:47:56 +0100
|
|
|
249a24 |
Subject: [PATCH] Fix crash when no error is set after connection failure
|
|
|
249a24 |
|
|
|
249a24 |
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
|
|
|
249a24 |
(cherry picked from commit a51e6a6973e9bdfcba0e52d3f9ee37686cd95db9)
|
|
|
249a24 |
---
|
|
|
249a24 |
src/vncconnection.c | 7 ++++---
|
|
|
249a24 |
1 file changed, 4 insertions(+), 3 deletions(-)
|
|
|
249a24 |
|
|
|
249a24 |
diff --git a/src/vncconnection.c b/src/vncconnection.c
|
|
|
249a24 |
index 8cec1af..e5b43a0 100644
|
|
|
249a24 |
--- a/src/vncconnection.c
|
|
|
249a24 |
+++ b/src/vncconnection.c
|
|
|
249a24 |
@@ -5428,7 +5428,7 @@ static gboolean vnc_connection_open_addr_internal(VncConnection *conn)
|
|
|
249a24 |
return TRUE;
|
|
|
249a24 |
}
|
|
|
249a24 |
vnc_connection_set_error(conn, "Unable to connect: %s",
|
|
|
249a24 |
- conn_error ? conn_error->message : "");
|
|
|
249a24 |
+ conn_error ? conn_error->message : "Unknown problem");
|
|
|
249a24 |
g_clear_error(&conn_error);
|
|
|
249a24 |
return FALSE;
|
|
|
249a24 |
}
|
|
|
249a24 |
@@ -5466,8 +5466,9 @@ static gboolean vnc_connection_open_host_internal(VncConnection *conn)
|
|
|
249a24 |
}
|
|
|
249a24 |
g_object_unref(enumerator);
|
|
|
249a24 |
if (!sock) {
|
|
|
249a24 |
- vnc_connection_set_error(conn, "Unable to connect: %s",
|
|
|
249a24 |
- conn_error->message);
|
|
|
249a24 |
+ vnc_connection_set_error(conn, "Unable to connect to %s:%s: %s",
|
|
|
249a24 |
+ priv->host, priv->port,
|
|
|
249a24 |
+ conn_error ? conn_error->message : "Unknown problem");
|
|
|
249a24 |
}
|
|
|
249a24 |
g_clear_error(&conn_error);
|
|
|
249a24 |
if (sock) {
|